• 
      

    Fix regressions in expanding diffs.

    Review Request #7187 — Created April 9, 2015 and submitted

    Information

    Review Board
    release-2.0.x
    7bfb5e6...

    Reviewers

    The recent work to refactor the diff fragment rendering code and the
    view broke diff expanding, due to the lack of a **kwargs in
    process_diffset_info(), and a captured URL parameter name that wasn't
    updated. This affected both diffs and interdiffs, with slightly
    different breakages.

    The **kwargs argument has been added, and the URL capture name fixed,
    restoring expansion support.

    Expansion worked again, for both diffs and interdiffs.

    reviewbot
    1. Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/diffviewer/views.py
          reviewboard/reviews/urls.py
      
      
      
      Tool: Pyflakes
      Processed Files:
          reviewboard/diffviewer/views.py
          reviewboard/reviews/urls.py
      
      
    2. 
        
    brennie
    1. Ship It!
    2. 
        
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.0.x (0518303)