More robust parsing of SVN client version

Review Request #7182 — Created April 7, 2015 and submitted — Latest diff uploaded

Information

RBTools
master
dbd0aac...

Reviewers

A user of SlikSvn reported an error when parsing the svn client
version string.  For SlikSvn the version string is of the form:
  1.6.1-SlikSvn-tag-1.6.1
which is more complicated than the version string produced by
other svn clients where the format is:
  1.6.1

String parsing is updated to extract exactly the first three 
numbers in the version string.  If less than three numbers are
present, which is an unlikely occurrence based on historical 
SVN version numbers (https://subversion.apache.org/docs/release-notes/release-history.html)
then a warning is logged and a default version number of
0.0.0 is assumed.
1) Tested with simple version string produced by stock subversion client in CentOS 7.x.
2) Stepped through code and manually tested with more complicated SlikSvn version string.
3) Ran unit tests.

Diff Revision 4 (Latest)

orig
1
2
3
4
rbtools/clients/svn.py
Loading...