Summary

Fix Review UI sandbox tests.

Review Request #7177 — Created April 7, 2015 and submitted April 9, 2015, 3:53 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-2.5.x

Bugs

Depends On

Commit

73e9c9f...

Reviewers

Groups

reviewboard

People

Description

A few of the unit tests for sandboxing of review UI methods were broken on
release-2.5.x. The cause appears to be a difference in caching between the
file attachment's review_ui member and the file attachment comment's
review_ui member. I've cleaned this up to make sure we're spying on the right
thing. While I was in here, I also fixed up some bad naming.

Testing Done

Ran unit tests.

Expand All
Collapse All

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/ui/tests.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/ui/tests.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.5.x (ab3845b)