Support for multi commit review requests in patch
Review Request #7175 — Created April 6, 2015 and submitted — Latest diff uploaded
The patch command now supports applying review requests with commit
history. If requested via command line arguments, each commit in the
review request will be applied in sequence on the current branch,
optionally committing each patch. The default behaviour is to replicate
what ever format of review request was uploaded, but this can be
overridden via flags.
Ran unit tests.
Manually tested the following against review requests with multiple
commits:
- Ran
rbt patch
. The commits were not committed. The output of
git diff
was correct. - Ran
rbt patch -C
. The commits were all created client side. The
output ofgit diff
was correct. - Ran
rbt patch -S
. The commits were not committed. The output of
git diff
was correct. Verified via the--debug
flag that we only
request the condensed diff from the server. - Ran
rbt patch -SC
against a review request with multiple commits.
The resulting commit was of the old format (description, testing done,
bugs fixed, etc.).
Manually tested the following against review request without multiple
commits:
- Ran
rbt patch
. No commits were created. The output ofgit diff
was correct. - Ran
rbt patch -C
. One commit was created and it was of the old
format (as specified above). The output ofgit diff
was correct. - Ran
rbt patch -SC
. Same behaviour ofrbt patch -C
.