Summary

Support showing attachment diff info and thumbnails in reviews.

Review Request #7121 — Created March 25, 2015 and submitted April 4, 2015, 2:19 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-2.5.x

Bugs

Depends On

Commit

98195f8...

Reviewers

Groups

reviewboard

People

Description

When reviewing a diff of a file attachment, we store some data on the
attachment being diffed against. However, we weren't using this data
when showing thumbnails of comments in the review dialog or in reviews.

Before, a ReviewUI would be created that pointed to the attachment being
commented on, but without the diff information, leaving the ReviewUI to
have to grab it itself from the comment. To fix this, we now have a
review_ui property on FileAttachmentComment that builds its own ReviewUI
with the diff information.

Now, both the review dialog and reviews show the revision ranges for the
attachments, and both set things up to use an appropriate thumbnail. The
reviews page also reduces queries for diffed file attachments by
re-associating attachments, like we do elsewhere.

Testing Done

Tested with older file attachments, with newer attachments (single revision),
and with diffs of file attachments.

Note that in the screenshots, there are differences between the presentation and
style of both thumbnails. This needs to be dealt with still, but is a separate
issue.

Files

Issues

Description	From	Last Updated
'render' imported but unused	reviewbot	March 25, 2015, 7:11 p.m.
Can we double-check review_ui.supports_diffing?	david	April 1, 2015, 2:26 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/reviews/models/file_attachment_comment.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewDialogView.js
    reviewboard/templates/reviews/boxes/review.html



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/reviews/models/file_attachment_comment.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewDialogView.js
    reviewboard/templates/reviews/boxes/review.html

reviewboard/reviews/views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'render' imported but unused
```

Change Summary:

Removed an unused import.

Commit:

6452f1151e1071d99dbbd33de88bdedc37fcdad5

03227e48fe71796a5ce96e0e7833cff8dfaf761a

Diff:

Revision 2 (+73 -5)

Show changes

	reviewboard/reviews/views.py
	reviewboard/reviews/models/file_attachment_comment.py
	reviewboard/static/rb/js/views/reviewDialogView.js
	reviewboard/templates/reviews/boxes/review.html

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/reviews/models/file_attachment_comment.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewDialogView.js
    reviewboard/templates/reviews/boxes/review.html



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/reviews/models/file_attachment_comment.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewDialogView.js
    reviewboard/templates/reviews/boxes/review.html

reviewboard/reviews/models/file_attachment_comment.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Can we double-check review_ui.supports_diffing?
```

Change Summary:

Updated a check to make sure the ReviewUI supports diffing.

Commit:

03227e48fe71796a5ce96e0e7833cff8dfaf761a

98195f81bd153616fd3c61cccca78d9dd5c443df

Diff:

Revision 3 (+73 -5)

Show changes

	reviewboard/reviews/views.py
	reviewboard/reviews/models/file_attachment_comment.py
	reviewboard/static/rb/js/views/reviewDialogView.js
	reviewboard/templates/reviews/boxes/review.html

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/reviews/models/file_attachment_comment.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewDialogView.js
    reviewboard/templates/reviews/boxes/review.html



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/reviews/models/file_attachment_comment.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewDialogView.js
    reviewboard/templates/reviews/boxes/review.html

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.5.x (9c97765)