Summary

Initialize the PyCrypto random number generator for each thread/process.

Review Request #7111 — Created March 24, 2015 and submitted March 24, 2015, 6:32 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-2.0.x

Bugs

Depends On

Blocks

7413

Commit

d0b8b3f...

Reviewers

Groups

reviewboard

People

Description

PyCrypto requires that the random number be re-generated for every
forked process. While this should already be happening, it seems that
there are cases where it doesn't. (This may be dependent on the version
of PyCrypto.)

In order to guarantee that PyCrypto is happy, we'll initialize it during
Review Board initialization.

Testing Done

Unit tests pass.

Navigating around Review Board works.

I was not able to reproduce the original bug here, but this should satisfy
the requirements.

Issues

Description	From	Last Updated
'reviewboard' imported but unused	reviewbot	March 24, 2015, 5:53 p.m.
'reviewboard' imported but unused	reviewbot	March 24, 2015, 6:07 p.m.

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/__init__.py



Tool: Pyflakes
Processed Files:
    reviewboard/__init__.py

reviewboard/__init__.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'reviewboard' imported but unused
```

reviewboard/__init__.py (Diff revision 1)

Not familiar with combining forking and test cases, but is it possible to use `forkpty()` or `fork()` and verify each process has a different random number?

chipx86 March 24, 2015, 6:04 p.m.

I'm actually going to change this to not run this when running tests, to prevent an impact on the test suite.

Tests don't fork, though, so there's not really anything there to worry about. This is more about runtime when in certain server configurations with certain versions of dependencies.

Change Summary:

We no longer run this during tests.

Commit:

6a5ee123d22fc5a6f163e0b1bb6f0dd453f1a4b3

d0b8b3f570b26f137da6d59ad61038f494a75243

Diff:

Revision 2 (+4)

Show changes

reviewboard/__init__.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/__init__.py



Tool: Pyflakes
Processed Files:
    reviewboard/__init__.py

reviewboard/__init__.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'reviewboard' imported but unused
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.5.x (47807d5)