• 
      

    Fix querying accessible review requests on a Local Site.

    Review Request #7094 — Created March 20, 2015 and submitted

    Information

    Review Board
    release-2.0.x
    7ff73fe...

    Reviewers

    The recent search work failed to pass the local_site parameter to the
    new accessible_ids() functions, preventing review requests from showing
    up in the All Review Requests page.

    We now include the local_site parameter in these queries. Unit tests
    were also added to check for these conditions.

    Some of the new unit tests failed before this change. They all pass now.

    Verified this problem with a non-admin account on RBCommons. Couldn't see
    any review requests. I then deployed this to RBCommons (a customer was
    blocked on it) after ensuring the tests passed. After, my non-admin user
    could see the expected review requests.

    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/reviews/tests.py
          reviewboard/reviews/managers.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/reviews/tests.py
          reviewboard/reviews/managers.py
      
      
    2. 
        
    brennie
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.0.x (b2c2f3e)