Pass URL arguments down to the ETag functions in the web API.

Review Request #7079 — Created March 18, 2015 and submitted

Information

Djblets
release-0.8.x
1f0170c...

Reviewers

Some of the new caching improvements neglected to pass keyword arguments
down to the ETag generation functions, which meant that any subclasses
of WebAPIResource that needed to generate URLs based off these would
fail.

We now pass kwargs in all places in this code path.

There was also a bug where kwargs was treated as an args list, meaning
we just passed the key names. This caused some confusing errors after
applying the real fixes.

Djblets, Review Board, and RBCommons unit tests pass.

reviewbot
  1. Tool: Pyflakes
    Processed Files:
        djblets/webapi/resources.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        djblets/webapi/resources.py
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-0.8.x (9721bfd)