Fix the close-submitted hook to work with un-published review requests.
Review Request #7071 — Created March 17, 2015 and submitted
The recent fix to disallow closing review requests as "submitted" before they
were ever published wasn't coexisting well with the close-submitted webhooks.
In the case where a user put the review request ID in for something that hadn't
been published, the webhook would throw a 500 error and e-mail the admins.This change adds a step to publish the review request first before closing.
This ensures that any draft fields get copied over to the review request, and
that all the counters are correct.
Added a new unit test which failed before the change and succeeds after.
| Description | From | Last Updated |
|---|---|---|
|
""" on the next line. |
 chipx86
|
Tool: Pyflakes Processed Files: reviewboard/hostingsvcs/hook_utils.py reviewboard/hostingsvcs/tests.py Tool: PEP8 Style Checker Processed Files: reviewboard/hostingsvcs/hook_utils.py reviewboard/hostingsvcs/tests.py