Summary

Support Local Sites in search.

Review Request #7062 — Created March 14, 2015 and submitted March 16, 2015, 7:12 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-2.0.x

Bugs

Depends On

Commit

cc05769...

Reviewers

Groups

reviewboard

People

Description

Review requests and users on Local Sites are now indexed. When
searching, the Local Site (or lack thereof) is taken into account, and
only the appropriate results will be returned.

There's a BaseSearchIndex that all other search indexes must subclass.
This takes care of storing information on the associated local site(s)
in a consistent manner, to ease search queries. If no local sites are
associated with the object being indexed, the list will consist of a
single item: 0. This value indicates no local sites, and is easy to
query. This replaces the need for a separate boolean field. Empty lists
cannot be used, since there's no way to filter on these in any
consistent way across search backends.

As part of this, I had to remove usage of Haystack's
search_view_factory, which doesn't accept URL arguments. We now have our
own wrapper view that constructs the RBSearchView.

This requires a full re-index.

Testing Done

On a non-local site, I tried searching for both non-local site review requests
and local site review requests. Only the ones not on a local site were returned.

I repeated the same test when searching on a local site. Only the ones on that
local site were returned.

Issues

Description	From	Last Updated
Blank line after this.	david	March 16, 2015, 2:37 p.m.
Blank line after this.	david	March 16, 2015, 2:37 p.m.
Col: 63 E703 statement ends with a semicolon	reviewbot	March 15, 2015, 3:08 p.m.
How about combining these lines?	david	March 16, 2015, 4:13 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/search/views.py
    reviewboard/search/urls.py
    reviewboard/reviews/search_indexes.py
    reviewboard/reviews/managers.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/search/views.py
    reviewboard/search/urls.py
    reviewboard/reviews/search_indexes.py
    reviewboard/reviews/managers.py

Change Summary:


Fixed support for indexing/querying users on Local Sites.
To ease the maintenance of search indexes with Local Sites, and to keep things consistent, there's now a BaseSearchIndex class that takes care of all the Local Site information preparation. It handles objects associated with a single LocalSite (like a ReviewRequest) and those with potentially many (User).

Description:

~		Review requests on Local Sites are now indexed. When searching, the
~		Local Site (or lack thereof) is taken into account, and only the
~		appropriate results will be returned.
	~	Review requests and users on Local Sites are now indexed. When
	~	searching, the Local Site (or lack thereof) is taken into account, and
	~	only the appropriate results will be returned.
	+
	+	There's a `BaseSearchIndex` that all other search indexes must subclass.
	+	This takes care of storing information on the associated local site(s)
	+	in a consistent manner, to ease search queries. If no local sites are
	+	associated with the object being indexed, the list will consist of a
	+	single item: `0`. This value indicates no local sites, and is easy to
	+	query. This replaces the need for a separate boolean field. Empty lists
	+	cannot be used, since there's no way to filter on these in any
	+	consistent way across search backends.

		As part of this, I had to remove usage of Haystack's
		`search_view_factory`, which doesn't accept URL arguments. We now have our
		own wrapper view that constructs the `RBSearchView`.

		This requires a full re-index.

Commit:

d07fb4002a26cf590d97aeafc1e91b46ba441ef8

79e7d415b6c108f785100949486972a84022235c

Diff:

Revision 2 (+102 -29)

Show changes

	reviewboard/accounts/search_indexes.py
	reviewboard/reviews/managers.py
	reviewboard/reviews/search_indexes.py
	reviewboard/search/indexes.py
	reviewboard/search/urls.py
	reviewboard/search/views.py

Tool: Pyflakes
Processed Files:
    reviewboard/search/indexes.py
    reviewboard/search/views.py
    reviewboard/reviews/search_indexes.py
    reviewboard/reviews/managers.py
    reviewboard/accounts/search_indexes.py
    reviewboard/search/urls.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/search/indexes.py
    reviewboard/search/views.py
    reviewboard/reviews/search_indexes.py
    reviewboard/reviews/managers.py
    reviewboard/accounts/search_indexes.py
    reviewboard/search/urls.py

reviewboard/search/indexes.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 63
 E703 statement ends with a semicolon
```

reviewboard/accounts/search_indexes.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Blank line after this.
```
reviewboard/search/indexes.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Blank line after this.
```

reviewboard/search/views.py (Diff revision 2)

The issue has been dropped. Show all issues

How about combining these lines?

chipx86 March 16, 2015, 2:38 p.m.

I thought about that, but it's kinda funky-looking with the double parens. I like it being more explicit, so it's clear what's going on here.

david March 16, 2015, 4:13 p.m.
```
Sure.
```

Change Summary:

Added a couple blank lines.

Commit:

79e7d415b6c108f785100949486972a84022235c

cc05769efe58869779ace9c3ae9371eda521d146

Diff:

Revision 3 (+103 -28)

Show changes

	reviewboard/accounts/search_indexes.py
	reviewboard/reviews/managers.py
	reviewboard/reviews/search_indexes.py
	reviewboard/search/indexes.py
	reviewboard/search/urls.py
	reviewboard/search/views.py

Tool: Pyflakes
Processed Files:
    reviewboard/search/indexes.py
    reviewboard/search/views.py
    reviewboard/reviews/search_indexes.py
    reviewboard/reviews/managers.py
    reviewboard/accounts/search_indexes.py
    reviewboard/search/urls.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/search/indexes.py
    reviewboard/search/views.py
    reviewboard/reviews/search_indexes.py
    reviewboard/reviews/managers.py
    reviewboard/accounts/search_indexes.py
    reviewboard/search/urls.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.0.x (3757cbe)