• 
      

    Move the search functionality into a top-level app and URL.

    Review Request #7061 — Created March 14, 2015 and submitted

    Information

    Review Board
    release-2.0.x
    e707437...

    Reviewers

    Search functionality is branching out from just being about review
    requests. It's time to move the code out into its own app, and to make
    /search/ a top-level URL.

    This is just code shuffle. Nothing of any substance has changed,
    implementation-wise, with one exception. SearchView, it turns out, is
    not thread-safe. We now use Haystack's search_view_factory wrapper,
    which will instantiate a SearchView for every request, fixing the thread
    safety.

    Performed searches successfully.

    reviewbot
    1. Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/reviews/views.py
          reviewboard/search/urls.py
          reviewboard/search/views.py
          reviewboard/reviews/urls.py
          reviewboard/urls.py
      
      Ignored Files:
          reviewboard/search/__init__.py
      
      
      
      Tool: Pyflakes
      Processed Files:
          reviewboard/reviews/views.py
          reviewboard/search/urls.py
          reviewboard/search/views.py
          reviewboard/reviews/urls.py
          reviewboard/urls.py
      
      Ignored Files:
          reviewboard/search/__init__.py
      
      
    2. 
        
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.0.x (5460cbc)