Summary

Move the search functionality into a top-level app and URL.

Review Request #7061 — Created March 14, 2015 and submitted March 16, 2015, 7:11 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-2.0.x

Bugs

Depends On

Commit

e707437...

Reviewers

Groups

reviewboard

People

Description

Search functionality is branching out from just being about review
requests. It's time to move the code out into its own app, and to make
/search/ a top-level URL.

This is just code shuffle. Nothing of any substance has changed,
implementation-wise, with one exception. SearchView, it turns out, is
not thread-safe. We now use Haystack's search_view_factory wrapper,
which will instantiate a SearchView for every request, fixing the thread
safety.

Testing Done

Performed searches successfully.

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/search/urls.py
    reviewboard/search/views.py
    reviewboard/reviews/urls.py
    reviewboard/urls.py

Ignored Files:
    reviewboard/search/__init__.py



Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/search/urls.py
    reviewboard/search/views.py
    reviewboard/reviews/urls.py
    reviewboard/urls.py

Ignored Files:
    reviewboard/search/__init__.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.0.x (5460cbc)