• 
      

    Improve quick search to factor in provided full names.

    Review Request #7059 — Created March 13, 2015 and submitted

    Information

    Review Board
    release-2.0.x
    f77e384...

    Reviewers

    When searching for a full name using quick search, we end up not showing
    any results. The string "firstname lastname" is no longer considered
    something that either first_name or last_name starts with, given the
    space.

    We now look for the space and attempt to do a more intelligent full name
    search. We break it into two strings and check the first/last name
    against that, and then the last/first name, in case the ordering is
    different in the profile.

    I also cleaned up a bunch of redundant code that didn't need to be there.

    Tested all the existing quick search functionality.

    Tested typing "Christian H", and saw the matches. Also tried "Hammond C".

    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/webapi/resources/search.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/webapi/resources/search.py
      
      
    2. 
        
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.0.x (44939c6)