• 
      

    Don't log output from 'diff' commands that return rc != 0.

    Review Request #7056 — Created March 13, 2015 and submitted

    Information

    RBTools
    release-0.7.x
    ba3b51e...

    Reviewers

    Many diff commands use a non-zero return code to indicate that the given files
    are different. This is fine, except we log the output of commands even when
    we're expecting non-zero return codes. This was causing issues when the output
    of the diff command wasn't ASCII, and we tried to format it into a logging
    call.

    We don't actually care about logging the output of diffs, since it makes our
    debug output pretty verbose. This change adds a new argument and some plumbing
    to make sure that we don't log the output of diff commands.

    • Ran unit tests.
    • Verified that diff contents were no longer logged with SCMs where they were
      previously (perforce, svn)
    reviewbot
    1. Tool: PEP8 Style Checker
      Processed Files:
          rbtools/clients/cvs.py
          rbtools/clients/mercurial.py
          rbtools/clients/git.py
          rbtools/clients/perforce.py
          rbtools/clients/bazaar.py
          rbtools/clients/svn.py
          rbtools/utils/process.py
      
      
      
      Tool: Pyflakes
      Processed Files:
          rbtools/clients/cvs.py
          rbtools/clients/mercurial.py
          rbtools/clients/git.py
          rbtools/clients/perforce.py
          rbtools/clients/bazaar.py
          rbtools/clients/svn.py
          rbtools/utils/process.py
      
      
    2. 
        
    chipx86
    1. Ship It!
    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-0.7.x (c2cb0ea)