• 
      

    Add overrides for djblets backbone and underscore templates.

    Review Request #7051 — Created March 12, 2015 and submitted

    Information

    Review Board
    release-2.0.x
    adde41a...

    Reviewers

    In djblets, we reference cdnjs.cloudflare.com to load things like jquery and
    backbone (with the idea being that we don't want to have to ship things twice,
    and users of djblets can override this if they don't want to use the CDN). In
    Review Board, we had overrides for jquery and jquery-ui in order to load the
    ones that we ship. However, we didn't have these overrides for underscore and
    backbone. This was only visible in the extensions pages in the admin, which
    use those templates to load the lib js. Most Review Board pages load underscore
    and backbone through the normal bundles.

    Loaded the extension list and saw that it was loading local copies of
    underscore and backbone rather than CDN ones.

    reviewbot
    1. Tool: Pyflakes
      Ignored Files:
          reviewboard/templates/js/backbone.html
          reviewboard/templates/js/underscore.html
      
      
      
      Tool: PEP8 Style Checker
      Ignored Files:
          reviewboard/templates/js/backbone.html
          reviewboard/templates/js/underscore.html
      
      
    2. 
        
    brennie
    1. Ship It!
    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.0.x (cb12831)