Summary

Make draft comments in diffviewer and text based attachments resizable and movable

Review Request #7032 — Created March 9, 2015 and updated April 23, 2015, 9:57 a.m.

Information

Owner

wudi

Repository

Review Board

Branch

master

Bugs

Depends On

Commit

2f1b795...

Reviewers

Groups

reviewboard, students

People

Description

Currently if a draft comment is made with the wrong range of lines, there is no way to correct it other than to delete it and make a new one. This fix aims to make the comment bubbles movable and resizable to update the line range.

Testing Done

Manual testing by dragging comment blocks.

Dragging:
Checked that the comment block can only be dragged if it is a new draft comment and not one made to an existing comment thread.

Resizing:
Checked that begin row cannot be resized to rows after end row.
Checked that end row cannot be resized to rows before begin row.
Checked that begin/end row is resized to a valid row (not headers).
Checked that dragging can be done across compressed diff headers.
Checked that dragging cannot be done across different files.

Moving:
Checked that line range stays the same when moving.
Checked that comment block can only be moved within visible lines.
Checked that line range cannot contain invalid rows.
Checked that dragging cannot be done across different files.

Triggering of comment dialog:
Checked that the comment dialog is triggered on click of the comment block.
Checked that the comment dialog is triggered on click of a row number in the diffviewer.

Files

Issues

Description	From	Last Updated
For readability, can you put a space around the > on each of these in this change?	chipx86	April 23, 2015, 9:47 a.m.
It's not immediately obvious to me how these are used. At the very least, there should be some documentation somewhere …	chipx86	April 13, 2015, 1:18 p.m.
Each function you introduce should have a doc comment.	chipx86	April 23, 2015, 9:47 a.m.
This all feels really, really iffy. Can you explain it more? Why can't this just listen in render()?	chipx86	April 23, 2015, 9:47 a.m.
Should use listenTo instead of on.	chipx86	April 23, 2015, 9:47 a.m.
Can we put this inline in the startDragging call below?	chipx86	April 23, 2015, 9:47 a.m.
Hmm, why not just compare against null?	chipx86	April 23, 2015, 9:47 a.m.
Same here about inlining.	chipx86	April 23, 2015, 9:47 a.m.
Blank line between these.	chipx86	April 23, 2015, 9:47 a.m.
Same here about inlining.	chipx86	April 23, 2015, 9:48 a.m.
Blank line between these.	chipx86	April 23, 2015, 9:48 a.m.
The second line's $row... should align with that on the first line. Also, no need to do typeof ... to …	chipx86	April 23, 2015, 9:48 a.m.
These need doc comments.	chipx86	April 23, 2015, 9:49 a.m.
Blank line between these.	chipx86	April 23, 2015, 9:49 a.m.
This is probably a good place for that documentation I mentioned.	chipx86	April 13, 2015, 1:18 p.m.
Best to pull out moveState into a local variable first, since it'll save on attribute lookups.	chipx86	April 13, 2015, 1:18 p.m.
Given that we're doing this, I'd like you to look into what jquery provides, since they have all this done …	chipx86	April 13, 2015, 1:18 p.m.
Only one var statement per function.	chipx86	April 23, 2015, 9:49 a.m.
A lot of this code looks the same as above. Can you factor it out into a mixin?	chipx86	April 13, 2015, 1:18 p.m.
Should be inline. Same with others.	chipx86	April 23, 2015, 9:49 a.m.
Should also compare against null directly.	chipx86	April 23, 2015, 9:49 a.m.
Blank line between these. Same below.	chipx86	April 23, 2015, 9:49 a.m.
Why this change?	chipx86	April 13, 2015, 1:18 p.m.
Not necessarily a "diff" comment bubble, since this works on plain text files as well.	chipx86	April 23, 2015, 9:50 a.m.
Missing a semicolon.	chipx86	April 23, 2015, 9:50 a.m.

Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/js/diffviewer/models/diffCommentBlockModel.js
    reviewboard/static/rb/js/views/textBasedCommentBlockView.js
    reviewboard/static/rb/css/pages/diffviewer.less



Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/js/diffviewer/models/diffCommentBlockModel.js
    reviewboard/static/rb/js/views/textBasedCommentBlockView.js
    reviewboard/static/rb/css/pages/diffviewer.less

Commit:

64f619ddc92b8ef1fd669976d7a8a3a319b3a253

02362039732496a6b287ffb4e9e1a1cae9df3ab7

Diff:

Revision 2 (+305 -19)

Show changes

	reviewboard/static/rb/css/pages/diffviewer.less
	reviewboard/static/rb/js/diffviewer/models/diffCommentBlockModel.js
	reviewboard/static/rb/js/diffviewer/views/diffCommentBlockView.js
	reviewboard/static/rb/js/views/textCommentRowSelector.js

Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/js/diffviewer/models/diffCommentBlockModel.js
    reviewboard/static/rb/js/diffviewer/views/diffCommentBlockView.js
    reviewboard/static/rb/js/views/textCommentRowSelector.js
    reviewboard/static/rb/css/pages/diffviewer.less



Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/js/diffviewer/models/diffCommentBlockModel.js
    reviewboard/static/rb/js/diffviewer/views/diffCommentBlockView.js
    reviewboard/static/rb/js/views/textCommentRowSelector.js
    reviewboard/static/rb/css/pages/diffviewer.less

Change Summary:

Fix issue with the resizing not working on first load because $beginRow and $endRow are not initialized in the model.

Commit:

02362039732496a6b287ffb4e9e1a1cae9df3ab7

8cb46128d2b557cd2533346e3e4495cd51eaf08f

Diff:

Revision 3 (+315 -19)

Show changes

	reviewboard/static/rb/css/pages/diffviewer.less
	reviewboard/static/rb/js/diffviewer/models/diffCommentBlockModel.js
	reviewboard/static/rb/js/diffviewer/views/diffCommentBlockView.js
	reviewboard/static/rb/js/views/textCommentRowSelector.js

Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/js/diffviewer/models/diffCommentBlockModel.js
    reviewboard/static/rb/js/diffviewer/views/diffCommentBlockView.js
    reviewboard/static/rb/js/views/textCommentRowSelector.js
    reviewboard/static/rb/css/pages/diffviewer.less



Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/js/diffviewer/models/diffCommentBlockModel.js
    reviewboard/static/rb/js/diffviewer/views/diffCommentBlockView.js
    reviewboard/static/rb/js/views/textCommentRowSelector.js
    reviewboard/static/rb/css/pages/diffviewer.less

Change Summary:

Implement moving of comment bubbles.

Testing Done:

	+	Manual testing by dragging comment blocks.
	+
	+	Resizing:
	+	Checked that begin row cannot be resized to rows after end row.
	+	Checked that end row cannot be resized to rows before begin row.
	+	Checked that begin/end row is resized to a valid row (not headers).
	+	Checked that dragging can be done across compressed diff headers.
	+	Checked that dragging cannot be done across different files.
	+
	+	Moving:
	+	Checked that line range stays the same when moving.
	+	Checked that comment block can only be moved within visible lines.
	+	Checked that line range cannot contain invalid rows.
	+	Checked that dragging cannot be done across different files.

Commit:

8cb46128d2b557cd2533346e3e4495cd51eaf08f

71d84129307056a5c983da1874119dd441bd385f

Diff:

Revision 4 (+388 -19)

Show changes

	reviewboard/static/rb/css/pages/diffviewer.less
	reviewboard/static/rb/js/diffviewer/models/diffCommentBlockModel.js
	reviewboard/static/rb/js/diffviewer/views/diffCommentBlockView.js
	reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js
	reviewboard/static/rb/js/views/textCommentRowSelector.js

Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/js/diffviewer/models/diffCommentBlockModel.js
    reviewboard/static/rb/js/diffviewer/views/diffCommentBlockView.js
    reviewboard/static/rb/js/views/textCommentRowSelector.js
    reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js
    reviewboard/static/rb/css/pages/diffviewer.less



Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/js/diffviewer/models/diffCommentBlockModel.js
    reviewboard/static/rb/js/diffviewer/views/diffCommentBlockView.js
    reviewboard/static/rb/js/views/textCommentRowSelector.js
    reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js
    reviewboard/static/rb/css/pages/diffviewer.less

Summary:

[WIP] Make draft comments in diffviewer resizable and movable

[WIP] Make draft comments in diffviewer and text based attachments resizable and movable

Commit:

71d84129307056a5c983da1874119dd441bd385f

76589bd80e15a23686493adf0d0b5a79316fbee4

Diff:

Revision 5 (+524 -21)

Show changes

	reviewboard/static/rb/css/pages/diffviewer.less
	reviewboard/static/rb/js/diffviewer/models/diffCommentBlockModel.js
	reviewboard/static/rb/js/diffviewer/views/diffCommentBlockView.js
	reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js
	reviewboard/static/rb/js/models/textBasedCommentBlockModel.js
	reviewboard/static/rb/js/views/textBasedCommentBlockView.js
	reviewboard/static/rb/js/views/textBasedReviewableView.js
	reviewboard/static/rb/js/views/textCommentRowSelector.js

Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/js/views/textBasedCommentBlockView.js
    reviewboard/static/rb/css/pages/diffviewer.less
    reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js
    reviewboard/static/rb/js/models/textBasedCommentBlockModel.js
    reviewboard/static/rb/js/diffviewer/models/diffCommentBlockModel.js
    reviewboard/static/rb/js/views/textBasedReviewableView.js
    reviewboard/static/rb/js/diffviewer/views/diffCommentBlockView.js
    reviewboard/static/rb/js/views/textCommentRowSelector.js



Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/js/views/textBasedCommentBlockView.js
    reviewboard/static/rb/css/pages/diffviewer.less
    reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js
    reviewboard/static/rb/js/models/textBasedCommentBlockModel.js
    reviewboard/static/rb/js/diffviewer/models/diffCommentBlockModel.js
    reviewboard/static/rb/js/views/textBasedReviewableView.js
    reviewboard/static/rb/js/diffviewer/views/diffCommentBlockView.js
    reviewboard/static/rb/js/views/textCommentRowSelector.js

reviewboard/static/rb/js/views/textBasedCommentBlockView.js (Diff revision 5)

Why not
$('<div/>').addClass('...')
           .appendTo(this.$el);

instead?

wudi March 15, 2015, 7:12 a.m.

I've followed the coding style from other parts of the codebase for consistency.

Summary:

[WIP] Make draft comments in diffviewer and text based attachments resizable and movable

Make draft comments in diffviewer and text based attachments resizable and movable

Testing Done:

		Manual testing by dragging comment blocks.

	+	Dragging:
	+	Checked that the comment block can only be dragged if it is a new draft comment and not one made to an existing comment thread.
	+
		Resizing:
		Checked that begin row cannot be resized to rows after end row.
		Checked that end row cannot be resized to rows before begin row.
		Checked that begin/end row is resized to a valid row (not headers).
		Checked that dragging can be done across compressed diff headers.
		Checked that dragging cannot be done across different files.

		Moving:
		Checked that line range stays the same when moving.
		Checked that comment block can only be moved within visible lines.
		Checked that line range cannot contain invalid rows.
		Checked that dragging cannot be done across different files.
	+
	+	Triggering of comment dialog:
	+	Checked that the comment dialog is triggered on click of the comment block.
	+	Checked that the comment dialog is triggered on click of a row number in the diffviewer.

Commit:

76589bd80e15a23686493adf0d0b5a79316fbee4

7e2c958d8a053d3edc18916c771736371eb07a91

Diff:

Revision 6 (+529 -23)

Show changes

	reviewboard/static/rb/css/pages/diffviewer.less
	reviewboard/static/rb/css/pages/search.less
	reviewboard/static/rb/js/diffviewer/models/diffCommentBlockModel.js
	reviewboard/static/rb/js/diffviewer/views/diffCommentBlockView.js
	reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js
	reviewboard/static/rb/js/models/textBasedCommentBlockModel.js
	reviewboard/static/rb/js/views/textBasedCommentBlockView.js
	reviewboard/static/rb/js/views/textBasedReviewableView.js
	1 more

Added Files:

Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/js/views/textBasedCommentBlockView.js
    reviewboard/static/rb/css/pages/diffviewer.less
    reviewboard/static/rb/css/pages/search.less
    reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js
    reviewboard/static/rb/js/models/textBasedCommentBlockModel.js
    reviewboard/static/rb/js/diffviewer/models/diffCommentBlockModel.js
    reviewboard/static/rb/js/views/textBasedReviewableView.js
    reviewboard/static/rb/js/diffviewer/views/diffCommentBlockView.js
    reviewboard/static/rb/js/views/textCommentRowSelector.js



Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/js/views/textBasedCommentBlockView.js
    reviewboard/static/rb/css/pages/diffviewer.less
    reviewboard/static/rb/css/pages/search.less
    reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js
    reviewboard/static/rb/js/models/textBasedCommentBlockModel.js
    reviewboard/static/rb/js/diffviewer/models/diffCommentBlockModel.js
    reviewboard/static/rb/js/views/textBasedReviewableView.js
    reviewboard/static/rb/js/diffviewer/views/diffCommentBlockView.js
    reviewboard/static/rb/js/views/textCommentRowSelector.js

Change Summary:

Previously, the commenting in the text-based file attachments were broken and a workaround was used to complete the project. The issue is resolved now.

This change fixes the issue with comment blocks being placed at the wrong rows due to the change in row indexes.

Commit:

7e2c958d8a053d3edc18916c771736371eb07a91

3ce7b8ab9dd0d7c489bbf0016ec199ab2009ad46

Diff:

Revision 7 (+530 -25)

Show changes

	reviewboard/static/rb/css/pages/diffviewer.less
	reviewboard/static/rb/js/diffviewer/models/diffCommentBlockModel.js
	reviewboard/static/rb/js/diffviewer/views/diffCommentBlockView.js
	reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js
	reviewboard/static/rb/js/models/textBasedCommentBlockModel.js
	reviewboard/static/rb/js/views/textBasedCommentBlockView.js
	reviewboard/static/rb/js/views/textBasedReviewableView.js
	reviewboard/static/rb/js/views/textCommentRowSelector.js

Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/js/views/textBasedCommentBlockView.js
    reviewboard/static/rb/css/pages/diffviewer.less
    reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js
    reviewboard/static/rb/js/models/textBasedCommentBlockModel.js
    reviewboard/static/rb/js/diffviewer/models/diffCommentBlockModel.js
    reviewboard/static/rb/js/views/textBasedReviewableView.js
    reviewboard/static/rb/js/diffviewer/views/diffCommentBlockView.js
    reviewboard/static/rb/js/views/textCommentRowSelector.js



Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/js/views/textBasedCommentBlockView.js
    reviewboard/static/rb/css/pages/diffviewer.less
    reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js
    reviewboard/static/rb/js/models/textBasedCommentBlockModel.js
    reviewboard/static/rb/js/diffviewer/models/diffCommentBlockModel.js
    reviewboard/static/rb/js/views/textBasedReviewableView.js
    reviewboard/static/rb/js/diffviewer/views/diffCommentBlockView.js
    reviewboard/static/rb/js/views/textCommentRowSelector.js

Fix it!

reviewboard/static/rb/css/pages/diffviewer.less (Diff revision 7)
The issue has been resolved. Show all issues
```
For readability, can you put a space around the > on each of these in this change?
```

reviewboard/static/rb/css/pages/diffviewer.less (Diff revision 7)

An issue was opened. Show all issues

It's not immediately obvious to me how these are used. At the very least, there should be some documentation somewhere about these. However, I wonder if you could instead use the jquery-ui stuff for move/resize support.

wudi April 17, 2015, 7:09 a.m.

I've looked into it but found it unsuitable, I've listed the reasons in my notes on hackpad.

Currently the dragging doesn't work as _findLineNumRow is moved to textCommentRowSelector and cannot be called in diffReviewableView. I was thinking of using the change in vertical pixels of the mouse movement (e.clientY) to calculate the new rows, instead of using e.target to find the new start row. This should make it more obvious how to drag them as the user can click anywhere on the comment block to move it.

reviewboard/static/rb/js/diffviewer/models/diffCommentBlockModel.js (Diff revision 7)
The issue has been resolved. Show all issues
```
Each function you introduce should have a doc comment.
```

reviewboard/static/rb/js/diffviewer/views/diffCommentBlockView.js (Diff revision 7)

The issue has been resolved. Show all issues

This all feels really, really iffy. Can you explain it more?

Why can't this just listen in render()?

wudi April 17, 2015, 7:09 a.m.

I can changed this to start listening on mousedown and stop listening on mouseup.

reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js (Diff revision 7)

The issue has been resolved. Show all issues

Should use listenTo instead of on.

reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js (Diff revision 7)
The issue has been resolved. Show all issues
```
Can we put this inline in the startDragging call below?
```
reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js (Diff revision 7)
The issue has been resolved. Show all issues
```
Hmm, why not just compare against null?
```
reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js (Diff revision 7)
The issue has been resolved. Show all issues
```
Same here about inlining.
```
reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js (Diff revision 7)
The issue has been resolved. Show all issues
```
Blank line between these.
```
reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js (Diff revision 7)
The issue has been resolved. Show all issues
```
Same here about inlining.
```
reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js (Diff revision 7)
The issue has been resolved. Show all issues
```
Blank line between these.
```

reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js (Diff revision 7)

The issue has been resolved. Show all issues

The second line's $row... should align with that on the first line.

Also, no need to do typeof ... to compare against undefined. Just compare against undefined.

reviewboard/static/rb/js/models/textBasedCommentBlockModel.js (Diff revision 7)
The issue has been resolved. Show all issues
```
These need doc comments.
```
reviewboard/static/rb/js/models/textBasedCommentBlockModel.js (Diff revision 7)
The issue has been resolved. Show all issues
```
Blank line between these.
```

reviewboard/static/rb/js/views/textBasedCommentBlockView.js (Diff revision 7)

An issue was opened. Show all issues

This is probably a good place for that documentation I mentioned.

reviewboard/static/rb/js/views/textBasedCommentBlockView.js (Diff revision 7)

An issue was opened. Show all issues

Best to pull out moveState into a local variable first, since it'll save on attribute lookups.

reviewboard/static/rb/js/views/textBasedCommentBlockView.js (Diff revision 7)

An issue was opened. Show all issues

Given that we're doing this, I'd like you to look into what jquery provides, since they have all this done in a way that works cross-browser and on mobile.

reviewboard/static/rb/js/views/textBasedReviewableView.js (Diff revision 7)
The issue has been resolved. Show all issues
```
Only one var statement per function.
```
reviewboard/static/rb/js/views/textBasedReviewableView.js (Diff revision 7)
An issue was opened. Show all issues
```
A lot of this code looks the same as above. Can you factor it out into a mixin?
```
reviewboard/static/rb/js/views/textBasedReviewableView.js (Diff revision 7)
The issue has been resolved. Show all issues
```
Should be inline.
Same with others.
```
reviewboard/static/rb/js/views/textBasedReviewableView.js (Diff revision 7)
The issue has been resolved. Show all issues
```
Should also compare against null directly.
```
reviewboard/static/rb/js/views/textBasedReviewableView.js (Diff revision 7)
The issue has been resolved. Show all issues
```
Blank line between these.
Same below.
```

reviewboard/static/rb/js/views/textCommentRowSelector.js (Diff revision 7)

An issue was opened. Show all issues

Why this change?

wudi April 17, 2015, 7:09 a.m.

.click() does not work after I defined mousedown for the commentBlockView but .dblclick() works. What would be a better solution for this?

reviewboard/static/rb/js/views/textCommentRowSelector.js (Diff revision 7)
The issue has been resolved. Show all issues
```
Not necessarily a "diff" comment bubble, since this works on plain text files as well.
```
reviewboard/static/rb/js/views/textCommentRowSelector.js (Diff revision 7)
The issue has been resolved. Show all issues
```
Missing a semicolon.
```

Commit:

3ce7b8ab9dd0d7c489bbf0016ec199ab2009ad46

dde5ad8278ba8441fb6bb8ae42a2e43f05559a81

Diff:

Revision 8 (+489 -21)

Show changes

	reviewboard/static/rb/css/pages/diffviewer.less
	reviewboard/static/rb/js/diffviewer/models/diffCommentBlockModel.js
	reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js
	reviewboard/static/rb/js/models/textBasedCommentBlockModel.js
	reviewboard/static/rb/js/views/textBasedCommentBlockView.js
	reviewboard/static/rb/js/views/textBasedReviewableView.js
	reviewboard/static/rb/js/views/textCommentRowSelector.js

Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/js/views/textBasedCommentBlockView.js
    reviewboard/static/rb/css/pages/diffviewer.less
    reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js
    reviewboard/static/rb/js/models/textBasedCommentBlockModel.js
    reviewboard/static/rb/js/diffviewer/models/diffCommentBlockModel.js
    reviewboard/static/rb/js/views/textBasedReviewableView.js
    reviewboard/static/rb/js/views/textCommentRowSelector.js



Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/js/views/textBasedCommentBlockView.js
    reviewboard/static/rb/css/pages/diffviewer.less
    reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js
    reviewboard/static/rb/js/models/textBasedCommentBlockModel.js
    reviewboard/static/rb/js/diffviewer/models/diffCommentBlockModel.js
    reviewboard/static/rb/js/views/textBasedReviewableView.js
    reviewboard/static/rb/js/views/textCommentRowSelector.js

Change Summary:


Fix undefined comparison
Update docs to use imperative mood

Commit:

dde5ad8278ba8441fb6bb8ae42a2e43f05559a81

2f1b7959a2a8a53ad946fe4ca03d3841e723479d

Diff:

Revision 9 (+489 -21)

Show changes

	reviewboard/static/rb/css/pages/diffviewer.less
	reviewboard/static/rb/js/diffviewer/models/diffCommentBlockModel.js
	reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js
	reviewboard/static/rb/js/models/textBasedCommentBlockModel.js
	reviewboard/static/rb/js/views/textBasedCommentBlockView.js
	reviewboard/static/rb/js/views/textBasedReviewableView.js
	reviewboard/static/rb/js/views/textCommentRowSelector.js

Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/js/views/textBasedCommentBlockView.js
    reviewboard/static/rb/css/pages/diffviewer.less
    reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js
    reviewboard/static/rb/js/models/textBasedCommentBlockModel.js
    reviewboard/static/rb/js/diffviewer/models/diffCommentBlockModel.js
    reviewboard/static/rb/js/views/textBasedReviewableView.js
    reviewboard/static/rb/js/views/textCommentRowSelector.js



Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/js/views/textBasedCommentBlockView.js
    reviewboard/static/rb/css/pages/diffviewer.less
    reviewboard/static/rb/js/diffviewer/views/diffReviewableView.js
    reviewboard/static/rb/js/models/textBasedCommentBlockModel.js
    reviewboard/static/rb/js/diffviewer/models/diffCommentBlockModel.js
    reviewboard/static/rb/js/views/textBasedReviewableView.js
    reviewboard/static/rb/js/views/textCommentRowSelector.js