Summary

"Trivial" publishes for review requests

Review Request #7022 — Created March 7, 2015 and submitted May 16, 2015, 3:07 p.m.

Information

Owner

jessq

Repository

Review Board

Branch

master

Bugs

Depends On

Commit

253d8e5...

Reviewers

Groups

reviewboard

People

Description

Each time a review request is published, it will send an e-mail (assuming e-mails are turned on for the server as a whole). We want to add a checkbox with the label "Send E-Mail", in the green draft header. If the user un-checks this box before publishing, it will publish without sending an e-mail.

Testing Done

Tested with new diff, checked and unchecked for "Send E-Mail".

Tested with attachment only draft, checked and unchecked for "Send E-Mail".

Issues

Description	From	Last Updated
Col: 80 E501 line too long (82 > 79 characters)	reviewbot	March 15, 2015, 10:02 p.m.
Col: 80 E501 line too long (86 > 79 characters)	reviewbot	March 15, 2015, 10:02 p.m.
'django_reset' imported but unused	reviewbot	March 7, 2015, 11:45 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	March 7, 2015, 11:45 p.m.
'PIPELINE_JS' imported but unused	reviewbot	March 7, 2015, 11:45 p.m.
'PIPELINE_CSS' imported but unused	reviewbot	March 7, 2015, 11:45 p.m.
Col: 33 W292 no newline at end of file	reviewbot	March 15, 2015, 10:02 p.m.
Col: 18 E231 missing whitespace after ':'	reviewbot	March 15, 2015, 10:02 p.m.
Col: 80 E501 line too long (82 > 79 characters)	reviewbot	March 15, 2015, 10:02 p.m.
Col: 80 E501 line too long (86 > 79 characters)	reviewbot	March 15, 2015, 10:03 p.m.
'django_reset' imported but unused	reviewbot	March 15, 2015, 9:59 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	March 15, 2015, 9:59 p.m.
'PIPELINE_CSS' imported but unused	reviewbot	March 15, 2015, 9:59 p.m.
'PIPELINE_JS' imported but unused	reviewbot	March 15, 2015, 9:59 p.m.
Col: 33 W292 no newline at end of file	reviewbot	March 15, 2015, 10:12 p.m.
Col: 18 E231 missing whitespace after ':'	reviewbot	March 15, 2015, 10:12 p.m.
Col: 1 E101 indentation contains mixed spaces and tabs	reviewbot	March 15, 2015, 10:17 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	March 15, 2015, 10:17 p.m.
Col: 15 E128 continuation line under-indented for visual indent	reviewbot	March 15, 2015, 10:17 p.m.
We should hide this if siteconfig.get("mail_send_review_mail") is False.	david	March 22, 2015, 12:10 p.m.
Please un-do this line.	david	March 22, 2015, 12:10 p.m.
You could just add trivial=None in the argument list instead of this.	david	March 22, 2015, 12:10 p.m.
No parens after not. Should just be ... and not trivial.	chipx86	March 26, 2015, 1:36 p.m.
Space before the />.	chipx86	March 26, 2015, 1:36 p.m.
No comma after "not".	chipx86	March 26, 2015, 1:36 p.m.
Can you change this to use single quotes?	brennie	April 28, 2015, 12:11 a.m.
Can you change these to use single quotes?	brennie	April 28, 2015, 12:12 a.m.
Single quotes.	brennie	April 28, 2015, 12:12 a.m.
See next issue. This should be something like !this.$('#not-trivial').prop('checked') to make more sense semantically.	brennie	April 28, 2015, 12:13 a.m.
So the property is trivial and the id for the checkbox is #trivial. However, the label associated for the checkbox …	brennie	April 4, 2015, 6:47 p.m.
This should read something like "Determines if the review request's publish will not send an E-Mail."	brennie	March 27, 2015, 7:30 p.m.
Can we call this context varable send_email?	david	April 28, 2015, 12:14 a.m.
Because trivial is internally a boolean value, can you use options.trivial ? 1 : 0 ?	david	April 28, 2015, 12:15 a.m.
Because trivial is internally a boolean value, can you use options.trivial ? 1 : 0 ?	david	April 28, 2015, 12:16 a.m.
Please verify that trivial is false when e-mail is turned off (in case other people add handlers for the signal …	david	May 1, 2015, 6:06 p.m.
Can you test to make sure that there are no javascript errors if e-mail is turned off?	david	April 28, 2015, 12:17 a.m.
Col: 56 W291 trailing whitespace	reviewbot	April 4, 2015, 6:30 p.m.
Col: 8 W291 trailing whitespace	reviewbot	April 4, 2015, 6:29 p.m.
Col: 38 E226 missing whitespace around arithmetic operator	reviewbot	April 4, 2015, 6:29 p.m.
Col: 74 W291 trailing whitespace	reviewbot	April 4, 2015, 6:30 p.m.
Col: 21 E231 missing whitespace after ','	reviewbot	April 4, 2015, 6:29 p.m.
Col: 35 E226 missing whitespace around arithmetic operator	reviewbot	April 4, 2015, 6:29 p.m.
Col: 25 E231 missing whitespace after ','	reviewbot	April 4, 2015, 6:29 p.m.
Col: 22 E225 missing whitespace around operator	reviewbot	April 4, 2015, 6:29 p.m.
Col: 34 E226 missing whitespace around arithmetic operator	reviewbot	April 4, 2015, 6:29 p.m.
Col: 34 E226 missing whitespace around arithmetic operator	reviewbot	April 4, 2015, 6:29 p.m.
Col: 18 W291 trailing whitespace	reviewbot	April 4, 2015, 6:29 p.m.
Col: 67 E225 missing whitespace around operator	reviewbot	April 4, 2015, 6:29 p.m.
Col: 80 E501 line too long (99 > 79 characters)	reviewbot	April 4, 2015, 6:29 p.m.
Col: 24 E228 missing whitespace around modulo operator	reviewbot	April 4, 2015, 6:29 p.m.
Col: 65 E228 missing whitespace around modulo operator	reviewbot	April 4, 2015, 6:29 p.m.
Col: 26 E225 missing whitespace around operator	reviewbot	April 4, 2015, 6:29 p.m.
Col: 46 E231 missing whitespace after ','	reviewbot	April 4, 2015, 6:29 p.m.
Col: 50 E226 missing whitespace around arithmetic operator	reviewbot	April 4, 2015, 6:29 p.m.
Col: 55 E226 missing whitespace around arithmetic operator	reviewbot	April 4, 2015, 6:29 p.m.
Col: 38 E226 missing whitespace around arithmetic operator	reviewbot	April 4, 2015, 6:29 p.m.
Col: 44 E226 missing whitespace around arithmetic operator	reviewbot	April 4, 2015, 6:29 p.m.
Col: 71 E228 missing whitespace around modulo operator	reviewbot	April 4, 2015, 6:29 p.m.
Col: 30 E225 missing whitespace around operator	reviewbot	April 4, 2015, 6:29 p.m.
Col: 68 E226 missing whitespace around arithmetic operator	reviewbot	April 4, 2015, 6:29 p.m.
Col: 80 E501 line too long (105 > 79 characters)	reviewbot	April 4, 2015, 6:29 p.m.
Col: 28 E228 missing whitespace around modulo operator	reviewbot	April 4, 2015, 6:29 p.m.
Col: 73 E225 missing whitespace around operator	reviewbot	April 4, 2015, 6:29 p.m.
Col: 25 E226 missing whitespace around arithmetic operator	reviewbot	April 4, 2015, 6:29 p.m.
Col: 44 E231 missing whitespace after ','	reviewbot	April 4, 2015, 6:29 p.m.
Col: 38 E226 missing whitespace around arithmetic operator	reviewbot	April 4, 2015, 6:29 p.m.
The "for" name no longer matches the ID of the input element.	david	April 28, 2015, 12:21 a.m.
Undo this change. A trailing comma in a JS object causes an error in some browsers.	brennie	May 16, 2015, 3:06 p.m.

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/notifications/email.py
    reviewboard/webapi/resources/review_request_draft.py
    reviewboard/settings.py
    reviewboard/reviews/signals.py
    reviewboard/reviews/models/review_request.py

Ignored Files:
    reviewboard/templates/reviews/review_header.html



Tool: Pyflakes
Processed Files:
    reviewboard/notifications/email.py
    reviewboard/webapi/resources/review_request_draft.py
    reviewboard/settings.py
    reviewboard/reviews/signals.py
    reviewboard/reviews/models/review_request.py

Ignored Files:
    reviewboard/templates/reviews/review_header.html

reviewboard/notifications/email.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (82 > 79 characters)
```
reviewboard/reviews/signals.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (86 > 79 characters)
```
reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```
reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'PIPELINE_JS' imported but unused
```
reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'PIPELINE_CSS' imported but unused
```
reviewboard/settings.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 33
 W292 no newline at end of file
```
reviewboard/webapi/resources/review_request_draft.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 18
 E231 missing whitespace after ':'
```

Summary:

[WIP] "Trivial" publishes for review requests

"Trivial" publishes for review requests

Description:

~		Each time a review request is published, it will send an e-mail (assuming e-mails are turned on for the server as a whole). This is done by adding a checkbox within the green draft bars that says "Send e-mail". If the user then un-checks this box before publishing, it would publish without sending an e-mail.
	~	Each time a review request is published, it will send an e-mail (assuming e-mails are turned on for the server as a whole). We want to add a checkbox with the label "Send E-Mail", in the green draft header. If the user un-checks this box before publishing, it will publish without sending an e-mail.

Testing Done:

~		I used Postman to send a PUT request to //0.0.0.0:8080/api/review-requests/1/draft/ with key = 'trivial'. If the value of 'trivial' is True, then an email log will not be created.
	~	Tested with new diff, checked and unchecked for "Send E-Mail".
	+
	+	Tested with attachment only draft, checked and unchecked for "Send E-Mail".

Commit:

1f6e4961f325b35be0176084751606d131d335a4

79b39d51af00325dbc1875a2c8a52b25173fb4a7

Diff:

Revision 2 (+27 -10)

Show changes

	reviewboard/settings.py
	reviewboard/notifications/email.py
	reviewboard/reviews/signals.py
	reviewboard/reviews/models/review_request.py
	reviewboard/static/rb/js/models/reviewRequestEditorModel.js
	reviewboard/static/rb/js/resources/models/draftReviewRequestModel.js
	reviewboard/static/rb/js/views/reviewRequestEditorView.js
	reviewboard/templates/reviews/review_header.html
	1 more

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/notifications/email.py
    reviewboard/webapi/resources/review_request_draft.py
    reviewboard/settings.py
    reviewboard/reviews/signals.py
    reviewboard/reviews/models/review_request.py

Ignored Files:
    reviewboard/static/rb/js/resources/models/draftReviewRequestModel.js
    reviewboard/static/rb/js/models/reviewRequestEditorModel.js
    reviewboard/templates/reviews/review_header.html
    reviewboard/static/rb/js/views/reviewRequestEditorView.js



Tool: Pyflakes
Processed Files:
    reviewboard/notifications/email.py
    reviewboard/webapi/resources/review_request_draft.py
    reviewboard/settings.py
    reviewboard/reviews/signals.py
    reviewboard/reviews/models/review_request.py

Ignored Files:
    reviewboard/static/rb/js/resources/models/draftReviewRequestModel.js
    reviewboard/static/rb/js/models/reviewRequestEditorModel.js
    reviewboard/templates/reviews/review_header.html
    reviewboard/static/rb/js/views/reviewRequestEditorView.js

reviewboard/notifications/email.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (82 > 79 characters)
```
reviewboard/reviews/signals.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (86 > 79 characters)
```
reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```
reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'PIPELINE_CSS' imported but unused
```
reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'PIPELINE_JS' imported but unused
```
reviewboard/settings.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 33
 W292 no newline at end of file
```
reviewboard/webapi/resources/review_request_draft.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 18
 E231 missing whitespace after ':'
```

Commit:

79b39d51af00325dbc1875a2c8a52b25173fb4a7

8c81d99d468a7cd742b05f0bea99ece26ed4801a

Diff:

Revision 3 (+25 -11)

Show changes

	reviewboard/notifications/email.py
	reviewboard/reviews/signals.py
	reviewboard/reviews/models/review_request.py
	reviewboard/static/rb/js/models/reviewRequestEditorModel.js
	reviewboard/static/rb/js/resources/models/draftReviewRequestModel.js
	reviewboard/static/rb/js/views/reviewRequestEditorView.js
	reviewboard/templates/reviews/review_header.html
	reviewboard/webapi/resources/review_request_draft.py

Tool: Pyflakes
Processed Files:
    reviewboard/notifications/email.py
    reviewboard/webapi/resources/review_request_draft.py
    reviewboard/reviews/signals.py
    reviewboard/reviews/models/review_request.py

Ignored Files:
    reviewboard/static/rb/js/resources/models/draftReviewRequestModel.js
    reviewboard/static/rb/js/models/reviewRequestEditorModel.js
    reviewboard/templates/reviews/review_header.html
    reviewboard/static/rb/js/views/reviewRequestEditorView.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/notifications/email.py
    reviewboard/webapi/resources/review_request_draft.py
    reviewboard/reviews/signals.py
    reviewboard/reviews/models/review_request.py

Ignored Files:
    reviewboard/static/rb/js/resources/models/draftReviewRequestModel.js
    reviewboard/static/rb/js/models/reviewRequestEditorModel.js
    reviewboard/templates/reviews/review_header.html
    reviewboard/static/rb/js/views/reviewRequestEditorView.js

reviewboard/reviews/signals.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 1
 E101 indentation contains mixed spaces and tabs
```
reviewboard/reviews/signals.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/reviews/signals.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 15
 E128 continuation line under-indented for visual indent
```

Commit:

8c81d99d468a7cd742b05f0bea99ece26ed4801a

7f0baa51816b317f3e8365ec00b461c47a958e98

Diff:

Revision 4 (+25 -11)

Show changes

	reviewboard/notifications/email.py
	reviewboard/reviews/signals.py
	reviewboard/reviews/models/review_request.py
	reviewboard/static/rb/js/models/reviewRequestEditorModel.js
	reviewboard/static/rb/js/resources/models/draftReviewRequestModel.js
	reviewboard/static/rb/js/views/reviewRequestEditorView.js
	reviewboard/templates/reviews/review_header.html
	reviewboard/webapi/resources/review_request_draft.py

Tool: Pyflakes
Processed Files:
    reviewboard/notifications/email.py
    reviewboard/webapi/resources/review_request_draft.py
    reviewboard/reviews/signals.py
    reviewboard/reviews/models/review_request.py

Ignored Files:
    reviewboard/static/rb/js/resources/models/draftReviewRequestModel.js
    reviewboard/static/rb/js/models/reviewRequestEditorModel.js
    reviewboard/templates/reviews/review_header.html
    reviewboard/static/rb/js/views/reviewRequestEditorView.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/notifications/email.py
    reviewboard/webapi/resources/review_request_draft.py
    reviewboard/reviews/signals.py
    reviewboard/reviews/models/review_request.py

Ignored Files:
    reviewboard/static/rb/js/resources/models/draftReviewRequestModel.js
    reviewboard/static/rb/js/models/reviewRequestEditorModel.js
    reviewboard/templates/reviews/review_header.html
    reviewboard/static/rb/js/views/reviewRequestEditorView.js

```
Can you attach a screenshot?
```
reviewboard/templates/reviews/review_header.html (Diff revision 4)
The issue has been resolved. Show all issues
```
We should hide this if siteconfig.get("mail_send_review_mail") is False.
```
reviewboard/webapi/resources/review_request_draft.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Please un-do this line.
```
reviewboard/webapi/resources/review_request_draft.py (Diff revision 4)
The issue has been resolved. Show all issues
```
You could just add trivial=None in the argument list instead of this.
```

Commit:

7f0baa51816b317f3e8365ec00b461c47a958e98

34270eeb4b635746b1a5a915ea033163bf8ef07d

Diff:

Revision 5 (+29 -12)

Show changes

	reviewboard/notifications/email.py
	reviewboard/reviews/signals.py
	reviewboard/reviews/views.py
	reviewboard/reviews/models/review_request.py
	reviewboard/static/rb/js/models/reviewRequestEditorModel.js
	reviewboard/static/rb/js/resources/models/draftReviewRequestModel.js
	reviewboard/static/rb/js/views/reviewRequestEditorView.js
	reviewboard/templates/reviews/review_header.html
	1 more

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/notifications/email.py
    reviewboard/webapi/resources/review_request_draft.py
    reviewboard/reviews/signals.py
    reviewboard/reviews/models/review_request.py

Ignored Files:
    reviewboard/static/rb/js/resources/models/draftReviewRequestModel.js
    reviewboard/static/rb/js/models/reviewRequestEditorModel.js
    reviewboard/templates/reviews/review_header.html
    reviewboard/static/rb/js/views/reviewRequestEditorView.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/notifications/email.py
    reviewboard/webapi/resources/review_request_draft.py
    reviewboard/reviews/signals.py
    reviewboard/reviews/models/review_request.py

Ignored Files:
    reviewboard/static/rb/js/resources/models/draftReviewRequestModel.js
    reviewboard/static/rb/js/models/reviewRequestEditorModel.js
    reviewboard/templates/reviews/review_header.html
    reviewboard/static/rb/js/views/reviewRequestEditorView.js

reviewboard/notifications/email.py (Diff revision 5)
The issue has been resolved. Show all issues
```
No parens after not. Should just be ... and not trivial.
```
reviewboard/templates/reviews/review_header.html (Diff revision 5)
The issue has been resolved. Show all issues
```
Space before the />.
```
reviewboard/webapi/resources/review_request_draft.py (Diff revision 5)
The issue has been resolved. Show all issues
```
No comma after "not".
```

Testing Done:: Tested with new diff, checked and unchecked for "Send E-Mail".

~
Tested with attachment only draft, checked and unchecked for "Send E-Mail".
~
Tested with attachment only draft, checked and unchecked for "Send E-Mail".dfdf

Testing Done:: Tested with new diff, checked and unchecked for "Send E-Mail".

~
Tested with attachment only draft, checked and unchecked for "Send E-Mail".dfdf
~
Tested with attachment only draft, checked and unchecked for "Send E-Mail".

Commit:

34270eeb4b635746b1a5a915ea033163bf8ef07d

a536edb00656dc6d6526a1a60c2e74327ac768a6

Diff:

Revision 6 (+29 -12)

Show changes

	reviewboard/notifications/email.py
	reviewboard/reviews/signals.py
	reviewboard/reviews/views.py
	reviewboard/reviews/models/review_request.py
	reviewboard/static/rb/js/models/reviewRequestEditorModel.js
	reviewboard/static/rb/js/resources/models/draftReviewRequestModel.js
	reviewboard/static/rb/js/views/reviewRequestEditorView.js
	reviewboard/templates/reviews/review_header.html
	1 more

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/notifications/email.py
    reviewboard/webapi/resources/review_request_draft.py
    reviewboard/reviews/signals.py
    reviewboard/reviews/models/review_request.py

Ignored Files:
    reviewboard/static/rb/js/resources/models/draftReviewRequestModel.js
    reviewboard/static/rb/js/models/reviewRequestEditorModel.js
    reviewboard/templates/reviews/review_header.html
    reviewboard/static/rb/js/views/reviewRequestEditorView.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/notifications/email.py
    reviewboard/webapi/resources/review_request_draft.py
    reviewboard/reviews/signals.py
    reviewboard/reviews/models/review_request.py

Ignored Files:
    reviewboard/static/rb/js/resources/models/draftReviewRequestModel.js
    reviewboard/static/rb/js/models/reviewRequestEditorModel.js
    reviewboard/templates/reviews/review_header.html
    reviewboard/static/rb/js/views/reviewRequestEditorView.js

reviewboard/notifications/email.py (Diff revision 6)

The issue has been resolved. Show all issues

Can you change this to use single quotes?

jessq March 27, 2015, 7:31 p.m.

The other methods of email.py all use double quotes for siteconfig.get() method.

brennie March 28, 2015, 11:19 a.m.

In the past we have used both double and single quotes, but we are moving towards using only single quotes in the code base (with some exceptions).

reviewboard/reviews/signals.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Can you change these to use single quotes?
```
1. JE
  
  jessq March 27, 2015, 7:31 p.m.
  The other methods of signals.py all use double quotes.
reviewboard/reviews/views.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Single quotes.
```
1. JE
  
  jessq March 27, 2015, 7:31 p.m.
  The other methods of views.py all use double quotes for siteconfig.get() method.

reviewboard/static/rb/js/views/reviewRequestEditorView.js (Diff revision 6)

The issue has been resolved. Show all issues

See next issue. This should be something like !this.$('#not-trivial').prop('checked') to make more sense semantically.

reviewboard/templates/reviews/review_header.html (Diff revision 6)

The issue has been resolved. Show all issues

So the property is trivial and the id for the checkbox is #trivial. However, the label associated for the checkbox is "Send E-Mail."

Semantically, I believe that the ID for the field should be #not-trivial so that the state of the check box is not the inverse of the state of the publish being trivial.

reviewboard/webapi/resources/review_request_draft.py (Diff revision 6)

The issue has been resolved. Show all issues

This should read something like "Determines if the review request's publish will not send an E-Mail."

Commit:

a536edb00656dc6d6526a1a60c2e74327ac768a6

cca13ebe591eae71ac65c6384ccbff913902a175

Diff:

Revision 7 (+29 -12)

Show changes

	reviewboard/notifications/email.py
	reviewboard/reviews/signals.py
	reviewboard/reviews/views.py
	reviewboard/reviews/models/review_request.py
	reviewboard/static/rb/js/models/reviewRequestEditorModel.js
	reviewboard/static/rb/js/resources/models/draftReviewRequestModel.js
	reviewboard/static/rb/js/views/reviewRequestEditorView.js
	reviewboard/templates/reviews/review_header.html
	1 more

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/notifications/email.py
    reviewboard/webapi/resources/review_request_draft.py
    reviewboard/reviews/signals.py
    reviewboard/reviews/models/review_request.py

Ignored Files:
    reviewboard/static/rb/js/resources/models/draftReviewRequestModel.js
    reviewboard/static/rb/js/models/reviewRequestEditorModel.js
    reviewboard/templates/reviews/review_header.html
    reviewboard/static/rb/js/views/reviewRequestEditorView.js



Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/notifications/email.py
    reviewboard/webapi/resources/review_request_draft.py
    reviewboard/reviews/signals.py
    reviewboard/reviews/models/review_request.py

Ignored Files:
    reviewboard/static/rb/js/resources/models/draftReviewRequestModel.js
    reviewboard/static/rb/js/models/reviewRequestEditorModel.js
    reviewboard/templates/reviews/review_header.html
    reviewboard/static/rb/js/views/reviewRequestEditorView.js

reviewboard/reviews/views.py (Diff revision 7)
The issue has been resolved. Show all issues
```
Can we call this context varable send_email?
```
reviewboard/static/rb/js/models/reviewRequestEditorModel.js (Diff revision 7)
The issue has been resolved. Show all issues
```
Because trivial is internally a boolean value, can you use options.trivial ? 1 : 0 ?
```
reviewboard/static/rb/js/resources/models/draftReviewRequestModel.js (Diff revision 7)
The issue has been resolved. Show all issues
```
Because trivial is internally a boolean value, can you use options.trivial ? 1 : 0 ?
```

reviewboard/static/rb/js/views/reviewRequestEditorView.js (Diff revision 7)

The issue has been resolved. Show all issues

Please verify that trivial is false when e-mail is turned off (in case other people add handlers for the signal on the backend).

reviewboard/templates/reviews/review_header.html (Diff revision 7)
The issue has been resolved. Show all issues
```
Can you test to make sure that there are no javascript errors if e-mail is turned off?
```

Diff:

Revision 8 (+37)

Show changes

solution_template.py

Tool: Pyflakes
Processed Files:
    solution_template.py



Tool: PEP8 Style Checker
Processed Files:
    solution_template.py


WARNING: Number of comments exceeded maximum, showing 30 of 38.

solution_template.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 56
 W291 trailing whitespace
```
solution_template.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 8
 W291 trailing whitespace
```
solution_template.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 38
 E226 missing whitespace around arithmetic operator
```
solution_template.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 74
 W291 trailing whitespace
```
solution_template.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 21
 E231 missing whitespace after ','
```
solution_template.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 35
 E226 missing whitespace around arithmetic operator
```
solution_template.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 25
 E231 missing whitespace after ','
```
solution_template.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 22
 E225 missing whitespace around operator
```
solution_template.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 34
 E226 missing whitespace around arithmetic operator
```
solution_template.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 34
 E226 missing whitespace around arithmetic operator
```
solution_template.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 18
 W291 trailing whitespace
```
solution_template.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 67
 E225 missing whitespace around operator
```
solution_template.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (99 > 79 characters)
```
solution_template.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 24
 E228 missing whitespace around modulo operator
```
solution_template.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 65
 E228 missing whitespace around modulo operator
```
solution_template.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 26
 E225 missing whitespace around operator
```
solution_template.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 46
 E231 missing whitespace after ','
```
solution_template.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 50
 E226 missing whitespace around arithmetic operator
```
solution_template.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 55
 E226 missing whitespace around arithmetic operator
```
solution_template.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 38
 E226 missing whitespace around arithmetic operator
```
solution_template.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 44
 E226 missing whitespace around arithmetic operator
```
solution_template.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 71
 E228 missing whitespace around modulo operator
```
solution_template.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 30
 E225 missing whitespace around operator
```
solution_template.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 68
 E226 missing whitespace around arithmetic operator
```
solution_template.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (105 > 79 characters)
```
solution_template.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 28
 E228 missing whitespace around modulo operator
```
solution_template.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 73
 E225 missing whitespace around operator
```
solution_template.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 25
 E226 missing whitespace around arithmetic operator
```
solution_template.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 44
 E231 missing whitespace after ','
```
solution_template.py (Diff revision 8)
The issue has been dropped. Show all issues
```
Col: 38
 E226 missing whitespace around arithmetic operator
```

Diff:

Revision 9 (+29 -12)

Show changes

	reviewboard/notifications/email.py
	reviewboard/reviews/signals.py
	reviewboard/reviews/views.py
	reviewboard/reviews/models/review_request.py
	reviewboard/static/rb/js/models/reviewRequestEditorModel.js
	reviewboard/static/rb/js/resources/models/draftReviewRequestModel.js
	reviewboard/static/rb/js/views/reviewRequestEditorView.js
	reviewboard/templates/reviews/review_header.html
	1 more

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/notifications/email.py
    reviewboard/webapi/resources/review_request_draft.py
    reviewboard/reviews/signals.py
    reviewboard/reviews/models/review_request.py

Ignored Files:
    reviewboard/static/rb/js/resources/models/draftReviewRequestModel.js
    reviewboard/static/rb/js/models/reviewRequestEditorModel.js
    reviewboard/templates/reviews/review_header.html
    reviewboard/static/rb/js/views/reviewRequestEditorView.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/notifications/email.py
    reviewboard/webapi/resources/review_request_draft.py
    reviewboard/reviews/signals.py
    reviewboard/reviews/models/review_request.py

Ignored Files:
    reviewboard/static/rb/js/resources/models/draftReviewRequestModel.js
    reviewboard/static/rb/js/models/reviewRequestEditorModel.js
    reviewboard/templates/reviews/review_header.html
    reviewboard/static/rb/js/views/reviewRequestEditorView.js

Hey Jessica,

There are a bunch of open issues in old reviews. Can you go through and mark them as fixed/dropped as appropriate? That way new reviewers will know what to look at.

reviewboard/templates/reviews/review_header.html (Diff revision 9)
The issue has been resolved. Show all issues
```
The "for" name no longer matches the ID of the input element.
```

Commit:

cca13ebe591eae71ac65c6384ccbff913902a175

253d8e50fbfed2a113d291bfc0da1f74dc2b38a3

Diff:

Revision 10 (+29 -13)

Show changes

	reviewboard/notifications/email.py
	reviewboard/reviews/signals.py
	reviewboard/reviews/views.py
	reviewboard/reviews/models/review_request.py
	reviewboard/static/rb/js/models/reviewRequestEditorModel.js
	reviewboard/static/rb/js/resources/models/draftReviewRequestModel.js
	reviewboard/static/rb/js/views/reviewRequestEditorView.js
	reviewboard/templates/reviews/review_header.html
	1 more

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/notifications/email.py
    reviewboard/webapi/resources/review_request_draft.py
    reviewboard/reviews/signals.py
    reviewboard/reviews/models/review_request.py

Ignored Files:
    reviewboard/static/rb/js/resources/models/draftReviewRequestModel.js
    reviewboard/static/rb/js/models/reviewRequestEditorModel.js
    reviewboard/templates/reviews/review_header.html
    reviewboard/static/rb/js/views/reviewRequestEditorView.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/notifications/email.py
    reviewboard/webapi/resources/review_request_draft.py
    reviewboard/reviews/signals.py
    reviewboard/reviews/models/review_request.py

Ignored Files:
    reviewboard/static/rb/js/resources/models/draftReviewRequestModel.js
    reviewboard/static/rb/js/models/reviewRequestEditorModel.js
    reviewboard/templates/reviews/review_header.html
    reviewboard/static/rb/js/views/reviewRequestEditorView.js

reviewboard/static/rb/js/models/reviewRequestEditorModel.js (Diff revision 10)
The issue has been resolved. Show all issues
```
Undo this change. A trailing comma in a JS object causes an error in some browsers.
```

Status:: Completed
Change Summary:: Pushed to release-2.5.x (051b134)