Summary

Make a ReviewRequestField for 'status'.

Review Request #7012 — Created March 5, 2015 and submitted March 9, 2015, 2:22 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-2.0.x

Bugs

Depends On

Commit

807ddb2...

Reviewers

Groups

reviewboard

People

Description

The existing 'status' field is done by directly changing the model, and
recording the change directly into the ChangeDescription. This worked okay,
except that trying to serialize change descriptions which included changes to
the 'status' field would explode.

This change adds a new ReviewRequestField (which is not shown in the UI), and
uses that to record the changes to the status, as well as serialize it in the
API. I've added a new unit test that verifies that we can serialize change
descriptions that manipulate the 'status' field.

Testing Done


Ran unit tests.
Loaded review requests and saw that there were no changes to the UI.

Issues

Description	From	Last Updated
I know it doesn't really matter since this field isn't visible, but would this be better suited to the ChangeEntryOnlyFieldSet?	brennie	March 6, 2015, 12:55 p.m.
Blank line here, apparently.	chipx86	March 9, 2015, 1:06 p.m.
I feel this is useful information for the docstring.	chipx86	March 9, 2015, 1:06 p.m.
""" on the next line.	chipx86	March 9, 2015, 1:06 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/builtin_fields.py
    reviewboard/webapi/tests/test_change.py
    reviewboard/reviews/models/review_request.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/builtin_fields.py
    reviewboard/webapi/tests/test_change.py
    reviewboard/reviews/models/review_request.py

reviewboard/reviews/builtin_fields.py (Diff revision 1)

The issue has been resolved. Show all issues

I know it doesn't really matter since this field isn't visible, but would this be better suited to the ChangeEntryOnlyFieldSet?

Change Summary:

Move StatusField to ChangeEntryOnlyFieldSet.

Commit:

5f389f506ccdc6374f152cd5e3aaeb3826651b6a

cf489c25fea8d3473e1aee77f7d0f6cd6115ed0f

Diff:

Revision 2 (+38 -4)

Show changes

	reviewboard/reviews/builtin_fields.py
	reviewboard/reviews/models/review_request.py
	reviewboard/webapi/tests/test_change.py

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/builtin_fields.py
    reviewboard/webapi/tests/test_change.py
    reviewboard/reviews/models/review_request.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/builtin_fields.py
    reviewboard/webapi/tests/test_change.py
    reviewboard/reviews/models/review_request.py

reviewboard/reviews/builtin_fields.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Blank line here, apparently.
```
reviewboard/reviews/builtin_fields.py (Diff revision 2)
The issue has been resolved. Show all issues
```
I feel this is useful information for the docstring.
```
reviewboard/webapi/tests/test_change.py (Diff revision 2)
The issue has been resolved. Show all issues
```
""" on the next line.
```

Commit:

cf489c25fea8d3473e1aee77f7d0f6cd6115ed0f

807ddb23b1854ea49ac7efa6e8360d712e121c1c

Diff:

Revision 3 (+42 -4)

Show changes

	reviewboard/reviews/builtin_fields.py
	reviewboard/reviews/models/review_request.py
	reviewboard/webapi/tests/test_change.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/builtin_fields.py
    reviewboard/webapi/tests/test_change.py
    reviewboard/reviews/models/review_request.py



Tool: Pyflakes
Processed Files:
    reviewboard/reviews/builtin_fields.py
    reviewboard/webapi/tests/test_change.py
    reviewboard/reviews/models/review_request.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.0.x (7738d0a)