Summary

Highlighting Active Discussions: Attract user attention to new comments and reviews

Review Request #7008 — Created March 4, 2015 and discarded Feb. 8, 2017, 4:16 p.m.

Information

Owner

rmeringe

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard, students

People

Description

Highlight Active Discussions,Frontend and Backend Completed

Applied last_visited token as a a parameter to the front end, so that both reviews and reply's can check in the template tag if
they are new since the last time the user has visited the site. The main backend changes occured in the reviews/views.py file in the review_detail function. Before,
the fate of the reply's collapsing depended on if the reply was new or not, and individual comments/replies could not be highlighted. Now, it is possible to determine which comments or reviews are new(not seen before) through the following rules on the front end side.

Views are modelled by the following rules:

If a review is new or has new comments, then there exists a blue circle on the username tab of the whole review reply.
If the user has seen a review before, but there are new comments, then the user will have a blue circle on the review reply and the new comments as well as a highlighted background.
If the review is old and there are no new comments, then the review is collapsed as before.

Testing Done

Manual Testing so far with a few simple review requests. Attempted to populate database, but I think some bugs in the populate database function prevented proper execution. 

Test Case: 1 review, 2 replies

Test Case: 2 reviews, 2 replies

Test Case: 1 review, 1 reply

Test Case: 2 reiews, 2 replies
Next Steps: Create a few more complicated testcases and see if any bugs arise.

Files

Issues

Description	From	Last Updated
This doesn't look used.	david	March 4, 2015, 6:55 p.m.
I think it would be better to put last_visited in here, rather than duplicating it into each entry.	david	March 4, 2015, 6:55 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	March 22, 2015, 7:02 p.m.
Col: 1 W293 blank line contains whitespace	reviewbot	March 22, 2015, 7:02 p.m.
Col: 1 W293 blank line contains whitespace	reviewbot	March 22, 2015, 7:02 p.m.
Col: 1 W293 blank line contains whitespace	reviewbot	March 22, 2015, 7:02 p.m.
Col: 23 E231 missing whitespace after ':'	reviewbot	March 22, 2015, 7:02 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	March 22, 2015, 7:02 p.m.
Col: 1 W293 blank line contains whitespace	reviewbot	March 22, 2015, 7:02 p.m.
Col: 1 W293 blank line contains whitespace	reviewbot	March 22, 2015, 7:02 p.m.
Col: 1 W293 blank line contains whitespace	reviewbot	March 22, 2015, 7:02 p.m.
Col: 1 W293 blank line contains whitespace	reviewbot	March 22, 2015, 7:02 p.m.
Col: 1 W293 blank line contains whitespace	reviewbot	March 22, 2015, 7:02 p.m.
Col: 1 W293 blank line contains whitespace	reviewbot	March 22, 2015, 7:02 p.m.
Col: 21 E225 missing whitespace around operator	reviewbot	March 22, 2015, 7:02 p.m.
Col: 1 W293 blank line contains whitespace	reviewbot	March 22, 2015, 7:02 p.m.
Col: 1 W293 blank line contains whitespace	reviewbot	March 22, 2015, 7:02 p.m.
Col: 1 W293 blank line contains whitespace	reviewbot	March 22, 2015, 7:02 p.m.
Col: 1 W293 blank line contains whitespace	reviewbot	March 22, 2015, 7:02 p.m.
Col: 1 W293 blank line contains whitespace	reviewbot	March 22, 2015, 7:02 p.m.
Col: 23 E231 missing whitespace after ':'	reviewbot	March 22, 2015, 7:02 p.m.
Col: 65 E231 missing whitespace after ','	reviewbot	March 22, 2015, 7:13 p.m.
Col: 1 W293 blank line contains whitespace	reviewbot	March 22, 2015, 7:19 p.m.
Col: 1 W293 blank line contains whitespace	reviewbot	March 22, 2015, 7:19 p.m.
Col: 21 E225 missing whitespace around operator	reviewbot	March 22, 2015, 7:16 p.m.
Col: 1 W293 blank line contains whitespace	reviewbot	March 22, 2015, 7:17 p.m.
Col: 1 W293 blank line contains whitespace	reviewbot	March 22, 2015, 7:17 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	March 22, 2015, 7:24 p.m.
Col: 1 W293 blank line contains whitespace	reviewbot	March 22, 2015, 7:24 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	March 23, 2015, 11:53 a.m.
Undo this change.	brennie	March 23, 2015, 7:53 p.m.
Undo this change.	brennie	March 23, 2015, 7:53 p.m.
Undo this change.	brennie	March 23, 2015, 7:53 p.m.
'render' imported but unused	reviewbot	March 23, 2015, 11:54 a.m.
Undo this change.	brennie	March 23, 2015, 7:53 p.m.
Undo this change.	brennie	March 23, 2015, 7:53 p.m.
Undo this change.	brennie	March 23, 2015, 7:53 p.m.
Undo this change.	brennie	March 23, 2015, 7:53 p.m.
Undo this change.	brennie	March 23, 2015, 7:53 p.m.
Undo this change.	brennie	March 23, 2015, 7:53 p.m.
Undo this change	brennie	March 23, 2015, 7:53 p.m.
Undo this change.	brennie	March 23, 2015, 7:53 p.m.
Col: 1 W293 blank line contains whitespace	reviewbot	March 23, 2015, 11:54 a.m.
Undo this change.	brennie	March 23, 2015, 7:53 p.m.
Undo this change.	brennie	March 23, 2015, 7:53 p.m.
No blank line here.	brennie	March 23, 2015, 7:53 p.m.
No blank line here.	brennie	March 23, 2015, 7:53 p.m.
ndo this change.	brennie	March 23, 2015, 7:53 p.m.
Undo these changes.	brennie	March 23, 2015, 7:53 p.m.
The { should be in the first column. The if should line up with the endif above. e.g., {% endif …	brennie	March 23, 2015, 7:53 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	May 1, 2015, 2:46 p.m.
'render' imported but unused	reviewbot	May 1, 2015, 2:46 p.m.
Space before the {	david	May 1, 2015, 2:46 p.m.
Space before the {	david	May 1, 2015, 2:46 p.m.
Blank line between these two.	david	May 1, 2015, 2:46 p.m.
Add another space before "if" (so it's aligned at the same level as the "endif" above it).	david	May 1, 2015, 2:46 p.m.
Can we break this up into multiple lines? Also, in templates, high-level tags (like if/block/etc) should be left-aligned. {% if …	david	May 1, 2015, 2:46 p.m.
Same here.	david	May 1, 2015, 2:46 p.m.

Description:: ~
WIP Patch: Highlight Active Discussions, Backend Completed
~
WIP: Highlight Active Discussions, Backend Completed

Applied last_visited token as a a parameter to the front end, so that both reviews and reply's can check in the template tag if
they are new since the last time the user has visited the site. The main backend changes occured in the reviews/views.py file in the review_detail function. Before
the fate of the reply's collapsing depended on if the reply was new or not, and individual comments/replies could not be highlighted. This WIP patch addresses this issue.
You can currently see, if a comment or reply is new, as it is written above each item. Front end changes to highlight these changes are the next step.

What in the world happened with deleting the file reviewboard/webapi/resources/review_reply.py ?

rmeringe March 4, 2015, 6:55 p.m.

I'm not sure where it went but I readded it in this commit.

reviewboard/reviews/views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This doesn't look used.
```

reviewboard/reviews/views.py (Diff revision 1)

The issue has been resolved. Show all issues

I think it would be better to put last_visited in here, rather than duplicating it into each entry.

Status:: Discarded

Status:

Re-opened

Commit:

f614de48f5daa4dd4673d205846be015919f94a5

Diff:

Revision 2 (+333 -8)

Show changes

	reviewboard/reviews/views.py
	reviewboard/reviews/templatetags/reviewtags.py
	reviewboard/templates/reviews/review_reply.html
	reviewboard/templates/reviews/review_reply_section.html
	reviewboard/templates/reviews/boxes/review.html
	reviewboard/webapi/resources/review_reply.py

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/reviews/templatetags/reviewtags.py
    reviewboard/webapi/resources/review_reply.py

Ignored Files:
    reviewboard/templates/reviews/review_reply_section.html
    reviewboard/templates/reviews/boxes/review.html
    reviewboard/templates/reviews/review_reply.html



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/reviews/templatetags/reviewtags.py
    reviewboard/webapi/resources/review_reply.py

Ignored Files:
    reviewboard/templates/reviews/review_reply_section.html
    reviewboard/templates/reviews/boxes/review.html
    reviewboard/templates/reviews/review_reply.html

reviewboard/reviews/templatetags/reviewtags.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
reviewboard/reviews/templatetags/reviewtags.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
reviewboard/reviews/templatetags/reviewtags.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
reviewboard/reviews/views.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
reviewboard/reviews/views.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 23
 E231 missing whitespace after ':'
```

So the way you posted this makes it so the diff isn't particularly useful (since we only see the latest commit on the branch). We'd really like to see the diff between master and the tip of your branch (which is what you get when just running rbt post).

Change Summary:

Made Front End Changes according to the following rule:
For new reviews we haven't seen before, there is a blue circle in front of the review
For reviews we have seen before, but has new comments, we put a blue circle on the review's username, and highlight and put a blue circle on the new comments.
Old reviews are still collapsed

Commit:

f614de48f5daa4dd4673d205846be015919f94a5

d7e907e927d430b7b11e3bf14ccab48f710f1c76

Diff:

Revision 3 (+58 -9)

Show changes

	reviewboard/test
	reviewboard/test3
	reviewboard/test4
	reviewboard/reviews/views.py
	reviewboard/reviews/templatetags/reviewtags.py
	reviewboard/static/rb/css/pages/reviews.less
	reviewboard/templates/reviews/review_reply.html
	reviewboard/templates/reviews/review_reply_section.html
	1 more

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/reviews/templatetags/reviewtags.py

Ignored Files:
    reviewboard/templates/reviews/review_reply_section.html
    reviewboard/test3
    reviewboard/test4
    reviewboard/templates/reviews/review_reply.html
    reviewboard/templates/reviews/boxes/review.html
    reviewboard/static/rb/css/pages/reviews.less
    reviewboard/test



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/reviews/templatetags/reviewtags.py

Ignored Files:
    reviewboard/templates/reviews/review_reply_section.html
    reviewboard/test3
    reviewboard/test4
    reviewboard/templates/reviews/review_reply.html
    reviewboard/templates/reviews/boxes/review.html
    reviewboard/static/rb/css/pages/reviews.less
    reviewboard/test

reviewboard/reviews/templatetags/reviewtags.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
reviewboard/reviews/templatetags/reviewtags.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
reviewboard/reviews/templatetags/reviewtags.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
reviewboard/reviews/views.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
reviewboard/reviews/views.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
reviewboard/reviews/views.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
reviewboard/reviews/views.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
reviewboard/reviews/views.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 21
 E225 missing whitespace around operator
```
reviewboard/reviews/views.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
reviewboard/reviews/views.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
reviewboard/reviews/views.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
reviewboard/reviews/views.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
reviewboard/reviews/views.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
reviewboard/reviews/views.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 23
 E231 missing whitespace after ':'
```

Change Summary:: Moved status of Highlighting Active Discussions from WIP to "completed"
Summary:: WIP Patch: Highlight Active Discussions, Backend Completed
Highlight Active Discussions, Frontend and Backend Completed

Change Summary:: Moved status of Highlighting Active Discussions from WIP to "completed"
Description:: ~
WIP: Highlight Active Discussions, Backend Completed
~
Highlight Active Discussions,Frontend and Backend Completed

Applied last_visited token as a a parameter to the front end, so that both reviews and reply's can check in the template tag if
they are new since the last time the user has visited the site. The main backend changes occured in the reviews/views.py file in the review_detail function. Before
the fate of the reply's collapsing depended on if the reply was new or not, and individual comments/replies could not be highlighted. This WIP patch addresses this issue.
~ You can currently see, if a comment or reply is new, as it is written above each item. Front end changes to highlight these changes are the next step.
~ You can currently see, if a comment or reply is new, as it is written above each item.
+
+
Views are modelled by the following rules:
+
+
If a review is new or has new comments, then we put a blue circle on the username tab of the whole review reply.
+ If we have seen a review before, but there are new comments, then we have a blue circle on the review reply and the new comments as well as highlight the background.
+ If the review is old and there are no new comments, then the review is collapsed as before.

Change Summary:

Fixed Reviewbot style issues

Commit:

d7e907e927d430b7b11e3bf14ccab48f710f1c76

b93cf1d4f37349e4d46882af6345e529655dda3e

Diff:

Revision 4 (+50 -12)

Show changes

	reviewboard/test
	reviewboard/test3
	reviewboard/test4
	reviewboard/reviews/views.py
	reviewboard/reviews/templatetags/reviewtags.py
	reviewboard/static/rb/css/pages/reviews.less
	reviewboard/templates/reviews/review_reply.html
	reviewboard/templates/reviews/review_reply_section.html
	1 more

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/reviews/templatetags/reviewtags.py

Ignored Files:
    reviewboard/templates/reviews/review_reply_section.html
    reviewboard/test3
    reviewboard/test4
    reviewboard/templates/reviews/review_reply.html
    reviewboard/templates/reviews/boxes/review.html
    reviewboard/static/rb/css/pages/reviews.less
    reviewboard/test



Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/reviews/templatetags/reviewtags.py

Ignored Files:
    reviewboard/templates/reviews/review_reply_section.html
    reviewboard/test3
    reviewboard/test4
    reviewboard/templates/reviews/review_reply.html
    reviewboard/templates/reviews/boxes/review.html
    reviewboard/static/rb/css/pages/reviews.less
    reviewboard/test

reviewboard/reviews/templatetags/reviewtags.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Col: 65
 E231 missing whitespace after ','
```
reviewboard/reviews/views.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
reviewboard/reviews/views.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
reviewboard/reviews/views.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Col: 21
 E225 missing whitespace around operator
```
reviewboard/reviews/views.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
reviewboard/reviews/views.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```

Commit:

b93cf1d4f37349e4d46882af6345e529655dda3e

a6ecc694f2687e091cd30657d18f0afdd2b2f40b

Diff:

Revision 5 (+47 -12)

Show changes

	reviewboard/test
	reviewboard/test3
	reviewboard/test4
	reviewboard/reviews/views.py
	reviewboard/reviews/templatetags/reviewtags.py
	reviewboard/static/rb/css/pages/reviews.less
	reviewboard/templates/reviews/review_reply.html
	reviewboard/templates/reviews/review_reply_section.html
	1 more

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/reviews/templatetags/reviewtags.py

Ignored Files:
    reviewboard/templates/reviews/review_reply_section.html
    reviewboard/test3
    reviewboard/test4
    reviewboard/templates/reviews/review_reply.html
    reviewboard/templates/reviews/boxes/review.html
    reviewboard/static/rb/css/pages/reviews.less
    reviewboard/test



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/reviews/templatetags/reviewtags.py

Ignored Files:
    reviewboard/templates/reviews/review_reply_section.html
    reviewboard/test3
    reviewboard/test4
    reviewboard/templates/reviews/review_reply.html
    reviewboard/templates/reviews/boxes/review.html
    reviewboard/static/rb/css/pages/reviews.less
    reviewboard/test

reviewboard/reviews/templatetags/reviewtags.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
reviewboard/reviews/views.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```

Are the three test files test, test3 and test4 in the diff supposed to be there?

RM

rmeringe March 23, 2015, 11:54 a.m.
```
Thanks, got rid of them
```

Change Summary:

Removed Unneccary test3,4,5 files

Commit:

a6ecc694f2687e091cd30657d18f0afdd2b2f40b

305daad2f913af4053df0d8bb0b132d07cf420c0

Diff:

Revision 6 (+44 -12)

Show changes

	reviewboard/reviews/views.py
	reviewboard/reviews/templatetags/reviewtags.py
	reviewboard/static/rb/css/pages/reviews.less
	reviewboard/templates/reviews/review_reply.html
	reviewboard/templates/reviews/review_reply_section.html
	reviewboard/templates/reviews/boxes/review.html

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/reviews/templatetags/reviewtags.py

Ignored Files:
    reviewboard/templates/reviews/review_reply_section.html
    reviewboard/templates/reviews/boxes/review.html
    reviewboard/static/rb/css/pages/reviews.less
    reviewboard/templates/reviews/review_reply.html



Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/reviews/templatetags/reviewtags.py

Ignored Files:
    reviewboard/templates/reviews/review_reply_section.html
    reviewboard/templates/reviews/boxes/review.html
    reviewboard/static/rb/css/pages/reviews.less
    reviewboard/templates/reviews/review_reply.html

reviewboard/reviews/templatetags/reviewtags.py (Diff revision 6)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
reviewboard/reviews/views.py (Diff revision 6)
The issue has been dropped. Show all issues
```
 'render' imported but unused
```
reviewboard/reviews/views.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```

A few notes. You made a lot of whitespace changes that break our style conventions. Firstly, there should be a blank line between a statement and a block and a blank line after a block. e.g.,

x = 3

while x == 3:
   x = foo(x)

if x:
   bar()

Also your description needs some work. Descriptions shouldn't mention the files modified (we can see from the diff what files were modified). Also you should avoid persons in descriptions (e.g., I, you, me). Finally, your summary wraps weirdly. If you are going to wrap it at all, wrap it at 72 characters because that is what Git commit messages expect. For more information on writing good summaries and descriptions, have a look through this guide.

If this is a WIP like it says in the description, please put a [WIP] tag in your summary.

reviewboard/reviews/templatetags/reviewtags.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Undo this change.
```
reviewboard/reviews/templatetags/reviewtags.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Undo this change.
```
reviewboard/reviews/templatetags/reviewtags.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Undo this change.
```
reviewboard/reviews/views.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Undo this change.
```
reviewboard/reviews/views.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Undo this change.
```
reviewboard/reviews/views.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Undo this change.
```
reviewboard/reviews/views.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Undo this change.
```
reviewboard/reviews/views.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Undo this change.
```
reviewboard/reviews/views.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Undo this change.
```
reviewboard/reviews/views.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Undo this change
```
reviewboard/reviews/views.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Undo this change.
```
reviewboard/reviews/views.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Undo this change.
```
reviewboard/reviews/views.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Undo this change.
```
reviewboard/static/rb/css/pages/reviews.less (Diff revision 6)
The issue has been resolved. Show all issues
```
No blank line here.
```
reviewboard/static/rb/css/pages/reviews.less (Diff revision 6)
The issue has been resolved. Show all issues
```
No blank line here.
```
reviewboard/static/rb/css/pages/reviews.less (Diff revision 6)
The issue has been resolved. Show all issues
```
ndo this change.
```
reviewboard/static/rb/css/pages/reviews.less (Diff revision 6)
The issue has been resolved. Show all issues
```
Undo these changes.
```

reviewboard/templates/reviews/boxes/review.html (Diff revision 6)

The issue has been resolved. Show all issues

The { should be in the first column. The if should line up with the endif above. e.g.,

{%  endif %}
   <div>...</div>
{%  if last_visited ... %}
   ...
{%  endif %}

Change Summary:

Undid whitepsace changes, and other style issues, as well as made a few changes to description to be more in line with style guidelines

Summary:

Highlight Active Discussions, Frontend and Backend Completed

Highlighting Active Discussions: Attract user attention to new comments and reviews

Description:

		Highlight Active Discussions,Frontend and Backend Completed

		Applied last_visited token as a a parameter to the front end, so that both reviews and reply's can check in the template tag if
~		they are new since the last time the user has visited the site. The main backend changes occured in the reviews/views.py file in the review_detail function. Before
~		the fate of the reply's collapsing depended on if the reply was new or not, and individual comments/replies could not be highlighted. This WIP patch addresses this issue.
	~	they are new since the last time the user has visited the site. The main backend changes occured in the reviews/views.py file in the review_detail function. Before,
	~	the fate of the reply's collapsing depended on if the reply was new or not, and individual comments/replies could not be highlighted. Now, it is possible to determine which comments or reviews are new(not seen before) through the following rules on the front end side.
-		You can currently see, if a comment or reply is new, as it is written above each item.

		Views are modelled by the following rules:

~		If a review is new or has new comments, then we put a blue circle on the username tab of the whole review reply.
~		If we have seen a review before, but there are new comments, then we have a blue circle on the review reply and the new comments as well as highlight the background.
	~	If a review is new or has new comments, then there exists a blue circle on the username tab of the whole review reply.
	~	If the user has seen a review before, but there are new comments, then the user will have a blue circle on the review reply and the new comments as well as a highlighted background.
		If the review is old and there are no new comments, then the review is collapsed as before.

Commit:

305daad2f913af4053df0d8bb0b132d07cf420c0

91620a9218b7e1d1a641d9f5e1851a95bbe6bd58

Diff:

Revision 7 (+35 -4)

Show changes

	reviewboard/reviews/views.py
	reviewboard/reviews/templatetags/reviewtags.py
	reviewboard/static/rb/css/pages/reviews.less
	reviewboard/templates/reviews/review_reply.html
	reviewboard/templates/reviews/review_reply_section.html
	reviewboard/templates/reviews/boxes/review.html

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/reviews/templatetags/reviewtags.py

Ignored Files:
    reviewboard/templates/reviews/review_reply_section.html
    reviewboard/templates/reviews/boxes/review.html
    reviewboard/static/rb/css/pages/reviews.less
    reviewboard/templates/reviews/review_reply.html



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/reviews/templatetags/reviewtags.py

Ignored Files:
    reviewboard/templates/reviews/review_reply_section.html
    reviewboard/templates/reviews/boxes/review.html
    reviewboard/static/rb/css/pages/reviews.less
    reviewboard/templates/reviews/review_reply.html

reviewboard/reviews/templatetags/reviewtags.py (Diff revision 7)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
reviewboard/reviews/views.py (Diff revision 7)
The issue has been resolved. Show all issues
```
 'render' imported but unused
```

Please upload some screenshots of what this looks like.

reviewboard/static/rb/css/pages/reviews.less (Diff revision 7)
The issue has been resolved. Show all issues
```
Space before the {
```
reviewboard/static/rb/css/pages/reviews.less (Diff revision 7)
The issue has been resolved. Show all issues
```
Space before the {
```
reviewboard/static/rb/css/pages/reviews.less (Diff revision 7)
The issue has been resolved. Show all issues
```
Blank line between these two.
```
reviewboard/templates/reviews/boxes/review.html (Diff revision 7)
The issue has been resolved. Show all issues
```
Add another space before "if" (so it's aligned at the same level as the "endif" above it).
```

reviewboard/templates/reviews/review_reply.html (Diff revision 7)

The issue has been resolved. Show all issues

Can we break this up into multiple lines?
Also, in templates, high-level tags (like if/block/etc) should be left-aligned.

{% if last_visited < timestamp and last_visited > entry.review.timestamp %}
    <dt class="new-reply">
{% else %}
    <dt>
{% endif %}

reviewboard/templates/reviews/review_reply.html (Diff revision 7)
The issue has been resolved. Show all issues
```
Same here.
```

Rohan, could you please update this review request?

Change Summary:

Made minor style changes and uploaded screenshots of ui changes

Commit:

91620a9218b7e1d1a641d9f5e1851a95bbe6bd58

8d16ee06d4a906174dbcc972e8265f7d4c0fb9c8

Diff:

Revision 8 (+42 -5)

Show changes

	reviewboard/reviews/views.py
	reviewboard/reviews/templatetags/reviewtags.py
	reviewboard/static/rb/css/pages/reviews.less
	reviewboard/templates/reviews/review_reply.html
	reviewboard/templates/reviews/review_reply_section.html
	reviewboard/templates/reviews/boxes/review.html

Added Files:

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/reviews/templatetags/reviewtags.py

Ignored Files:
    reviewboard/templates/reviews/review_reply_section.html
    reviewboard/templates/reviews/boxes/review.html
    reviewboard/static/rb/css/pages/reviews.less
    reviewboard/templates/reviews/review_reply.html



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/reviews/templatetags/reviewtags.py

Ignored Files:
    reviewboard/templates/reviews/review_reply_section.html
    reviewboard/templates/reviews/boxes/review.html
    reviewboard/static/rb/css/pages/reviews.less
    reviewboard/templates/reviews/review_reply.html

Groups:: students

Status:: Discarded

~		WIP Patch: Highlight Active Discussions, Backend Completed
	~	WIP: Highlight Active Discussions, Backend Completed

		Applied last_visited token as a a parameter to the front end, so that both reviews and reply's can check in the template tag if
		they are new since the last time the user has visited the site. The main backend changes occured in the reviews/views.py file in the review_detail function. Before
		the fate of the reply's collapsing depended on if the reply was new or not, and individual comments/replies could not be highlighted. This WIP patch addresses this issue.
		You can currently see, if a comment or reply is new, as it is written above each item. Front end changes to highlight these changes are the next step.