Summary

Handle mimetype parse failures for file attachments.

Review Request #7004 — Created March 3, 2015 and submitted March 4, 2015, 9:16 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-2.0.x

Bugs

3792

Depends On

Commit

ad201a8...

Reviewers

Groups

reviewboard

People

Description

This change adds some bullet-proofing around mimetype parsing in the base
FileAttachmentReviewUI. We've fixed several problems like this already, but
this one was still there.

Testing Done

Manually changed the mimetype of an attachment to the one in listed in the bug
("CDF V2 document, No summary info") and looked at the review request. Saw that
it was no longer broken.

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/ui/base.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/ui/base.py

reviewboard/reviews/ui/base.py (Diff revision 1)

Is it worth logging the traceback here?

david March 4, 2015, 9:05 p.m.

I don't think so. The traceback is just going to be internal mimeparse code, and typically it's just a "ValueError: need more than 1 value to unpack"

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.0.x (79d6e45)