• 
      

    Fix handling of empty files in SVN in some cases.

    Review Request #7002 — Created March 3, 2015 and submitted

    Information

    RBTools
    release-0.7.x
    3ddc208...

    Reviewers

    We ensure that the base and tip variables are defined before they
    are referenced. Static analysis (via PyCharm) determines that the
    variables are now always assigned before referencing.

    Ran unit tests.

    Before applying this patch, running rbt diff in an SVN repo against
    two changesets that add an empty file and delete an empty file would
    cause rbt to crash with the message:
    CRITICAL: local variable 'base' referenced before assignment.
    After applying this patch, this problem no longer persists. The output
    of rbt diff has the correct revision numbers in this case.

    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          rbtools/clients/svn.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          rbtools/clients/svn.py
      
      
    2. 
        
    david
    1. Ship It!
    2. 
        
    brennie
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-0.7.x (ce69201)
    gmyers
    1. I believe this resolves Issue #3674 (https://code.google.com/p/reviewboard/issues/detail?id=3674)
    2.