• 
      

    Fix problems when showing comment diff fragment errors.

    Review Request #6995 — Created Feb. 28, 2015 and submitted — Latest diff uploaded

    Information

    Review Board
    release-2.0.x
    b3179a0...

    Reviewers

    A recent change regressed showing diff fragment errors. The result from
    the function expected that a variable was set, but in the error case,
    this variable wasn't set. We now default it to an empty list.
    
    Still, we didn't actually show any error information for comments. This
    was due to returning a HTTP 500 for the script, which prevented the
    browser from executing it. We're now using a standard 200, which isn't
    ideal, but works.
    
    The error template has also been updated to factor in the comment ID for
    the links, so that there aren't conflicts when clicking the "Details"
    links.

    Faked an error. Saw the error pages appear. Tested that the Details links
    worked independently.