Summary

Fix Issue 3789: "UnicodeDecodeError: 'ascii' codec can't decode byte 0xe4 in position 92: ordinal not in range(128)" sending an email on Windows

Review Request #6985 — Created Feb. 27, 2015 and submitted March 3, 2015, 4:04 p.m.

Information

Owner

stefan

Repository

Review Board

Branch

master

Bugs

3789

Depends On

Commit

516bce8...

Reviewers

Groups

reviewboard

People

Description

Fix Issue 3789: "UnicodeDecodeError: 'ascii' codec can't decode byte 0xe4 in position 92: ordinal not in range(128)" sending an email on Windows.

Problem is that the windows exception text can contain Umlauts, which brakes the logging.

This way of error logging of exceptions is used in many classes of RB.

Someone should refactor all these occurences, becuase they might not be save!

Testing Done

Testing in Application

Issues

Description	From	Last Updated
local variable 'e' is assigned to but never used	reviewbot	Feb. 27, 2015, 3:04 a.m.
Col: 80 E501 line too long (83 > 79 characters)	reviewbot	Feb. 27, 2015, 3:04 a.m.
Col: 23 E128 continuation line under-indented for visual indent	reviewbot	Feb. 27, 2015, 3:04 a.m.
Col: 23 E128 continuation line under-indented for visual indent	reviewbot	Feb. 27, 2015, 3:04 a.m.
Col: 27 E126 continuation line over-indented for hanging indent	reviewbot	Feb. 27, 2015, 6:56 a.m.
Col: 80 E501 line too long (83 > 79 characters)	reviewbot	Feb. 27, 2015, 6:57 a.m.
Col: 9 E124 closing bracket does not match visual indentation	reviewbot	March 3, 2015, 4 p.m.

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/notifications/email.py



Tool: Pyflakes
Processed Files:
    reviewboard/notifications/email.py

reviewboard/notifications/email.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 local variable 'e' is assigned to but never used
```
reviewboard/notifications/email.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (83 > 79 characters)
```
reviewboard/notifications/email.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 23
 E128 continuation line under-indented for visual indent
```
reviewboard/notifications/email.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 23
 E128 continuation line under-indented for visual indent
```

Commit:

4a9ddf09940a1b5b14398f587405ff7283380b76

55c08f3e9340899deb30c73ec776d94e7c1f290a

Diff:

Revision 2 (+8 -6)

Show changes

reviewboard/notifications/email.py

Tool: Pyflakes
Processed Files:
    reviewboard/notifications/email.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/notifications/email.py

reviewboard/notifications/email.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 27
 E126 continuation line over-indented for hanging indent
```
reviewboard/notifications/email.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (83 > 79 characters)
```

Change Summary:

Hopefully finally fixed this intention thing.

Commit:

55c08f3e9340899deb30c73ec776d94e7c1f290a

fabe0277e6686f3acb81f746ed2c6359c65c8c28

Diff:

Revision 3 (+2 -3)

Show changes

reviewboard/notifications/email.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/notifications/email.py



Tool: Pyflakes
Processed Files:
    reviewboard/notifications/email.py

I don't actually see any substantive changes in your diff.

stefan March 1, 2015, 11:29 p.m.

You have to look at the diff between original and Rev 1.
There you see that an error is logged were the Exception is concatinated to the Message string.

When the exception contains non-encoded chars (e.g. ö,ä,ü) the UnicodeDecodeError is thrown.

To fix this logger.error is replaced by logger.exception. More important the exception is removed from the error message. (Will be logged automatically by logger.exception (https://docs.python.org/2/library/logging.html)

I hope it is now clearer.
-Stefan

david March 2, 2015, 3:52 p.m.

As people noted in one of your other changes, we need the diff between orig and the latest to be your full change (rbt patch can't apply interdiffs). Please post the diff between master and your branch tip.

Change Summary:

Fixed diff problem

Commit:

fabe0277e6686f3acb81f746ed2c6359c65c8c28

b0a43ebe143d91b902272e09e3b0c58992b5e2a6

Diff:

Revision 4 (+7 -8)

Show changes

reviewboard/notifications/email.py

Tool: Pyflakes
Processed Files:
    reviewboard/notifications/email.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/notifications/email.py

reviewboard/notifications/email.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Col: 9
 E124 closing bracket does not match visual indentation
```

Change Summary:

Fix bracket indention

Commit:

b0a43ebe143d91b902272e09e3b0c58992b5e2a6

516bce801b53c443cdcb40797d7fac74d72e9a7a

Diff:

Revision 5 (+6 -8)

Show changes

reviewboard/notifications/email.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/notifications/email.py



Tool: Pyflakes
Processed Files:
    reviewboard/notifications/email.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.0.x (41e81a7)