• 
      

    Fix building packages of rb-reviews-api

    Review Request #6980 — Created Feb. 26, 2015 and submitted

    Information

    student-sonar
    master
    776adda...

    Reviewers

    There are a couple things which broke when trying to build an egg for the
    reviews API extension.

    First, in the resources, there was a circular reference when trying to define
    the resource when the file was loaded as part of the static media builder.
    Importing reviewboard.webapi.resources and accessing one of the resources first
    makes sure that everything is registered properly.

    Second, the package name in setup.py has to be a bytestring.

    Built an egg successfully.

    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          misc/rb-reviews-api/rb_reviews_api/resources.py
          misc/rb-reviews-api/setup.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          misc/rb-reviews-api/rb_reviews_api/resources.py
          misc/rb-reviews-api/setup.py
      
      
    2. 
        
    chipx86
    1. Ship It!
    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (7648851)