• 
      

    Fix potential exception when SCMTool errors include unicode.

    Review Request #6965 — Created Feb. 20, 2015 and submitted

    Information

    Review Board
    release-2.0.x
    8092303...

    Reviewers

    In a user reported error, their Windows system with a German locale was
    returning an error string that included non-ASCII characters, and then we'd
    blow up trying to log the exception. According to the report, switching to
    logging.exception fixes the problem.

    Ran unit tests.

    Description From Last Updated

    list comprehension redefines 'file_attachment' from line 590

    reviewbotreviewbot
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/reviews/views.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/reviews/views.py
      
      
    2. reviewboard/reviews/views.py (Diff revision 1)
       
       
      Show all issues
       list comprehension redefines 'file_attachment' from line 590
      
    3. 
        
    chipx86
    1. Huh. I never saw logging.exception before. I feel like a n00b.

    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.0.x (6524390)