Summary

FileProvider WebApi interaction with file provider account

Review Request #6948 — Created Feb. 14, 2015 and updated May 20, 2015, 6:09 p.m.

Information

Owner

VTL-Developer

Repository

Review Board

Branch

master

Bugs

Depends On

6806, ~~6968~~

Blocks

7124

Commit

2ba622f...

Reviewers

Groups

reviewboard, students

People

Description

This FileProvider module allows users to select files from their online file storage providers to upload directly to ReviewBoard. In order to do so, there has to be way for users to interact with the FileProvider module. This is allowed by implementing webapi calls to interact with the back end. The new webapi integration supports the following:

Listing files at the specified path in your file storage
Searching for files in your file storage
Uploading files from your online file storage to ReviewBoard
Fetching a file's meta-information

As well as the general GET, POST, PUT and DELETE functionality for FileProvider object.

Testing Done

Test cases for GET, POST, PUT and DELETE for reviewboard/webapi/resources/file_provider_account.py are written.

Test cases for search, list content and meta-information for reviewboard/webapi/resources/file_provider_node.py are written.

Test cases and some manual tests with the file upload via file provider framework.

Issues

Description	From	Last Updated
'django_reset' imported but unused	reviewbot	Feb. 18, 2015, 7:33 a.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	Feb. 18, 2015, 7:33 a.m.
'PIPELINE_CSS' imported but unused	reviewbot	Feb. 18, 2015, 7:33 a.m.
'PIPELINE_JS' imported but unused	reviewbot	Feb. 18, 2015, 7:33 a.m.
Col: 40 W292 no newline at end of file	reviewbot	Feb. 18, 2015, 7:33 a.m.
Col: 80 E501 line too long (84 > 79 characters)	reviewbot	Feb. 18, 2015, 7:34 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Feb. 18, 2015, 10:25 a.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Feb. 18, 2015, 10:25 a.m.
Col: 45 E126 continuation line over-indented for hanging indent	reviewbot	Feb. 18, 2015, 10:26 a.m.
Col: 80 E501 line too long (83 > 79 characters)	reviewbot	Feb. 18, 2015, 10:26 a.m.
local variable 'rsp' is assigned to but never used	reviewbot	Feb. 18, 2015, 10:26 a.m.
Col: 79 W292 no newline at end of file	reviewbot	Feb. 18, 2015, 10:26 a.m.
'django_reset' imported but unused	reviewbot	Feb. 18, 2015, 12:57 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	Feb. 18, 2015, 12:57 p.m.
'PIPELINE_JS' imported but unused	reviewbot	Feb. 18, 2015, 12:57 p.m.
'PIPELINE_CSS' imported but unused	reviewbot	Feb. 18, 2015, 12:57 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Feb. 18, 2015, 12:57 p.m.
'django_reset' imported but unused	reviewbot	Feb. 21, 2015, 5:38 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	Feb. 21, 2015, 5:38 p.m.
'PIPELINE_CSS' imported but unused	reviewbot	Feb. 21, 2015, 5:38 p.m.
'PIPELINE_JS' imported but unused	reviewbot	Feb. 21, 2015, 5:38 p.m.
Col: 69 E502 the backslash is redundant between brackets	reviewbot	Feb. 21, 2015, 5:24 p.m.
Col: 69 E251 unexpected spaces around keyword / parameter equals	reviewbot	Feb. 21, 2015, 5:26 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Feb. 21, 2015, 5:21 p.m.
Col: 32 E127 continuation line over-indented for visual indent	reviewbot	Feb. 21, 2015, 5:21 p.m.
Col: 80 E501 line too long (83 > 79 characters)	reviewbot	Feb. 21, 2015, 5:22 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Feb. 21, 2015, 5:23 p.m.
'augment_method_from' imported but unused	reviewbot	Feb. 21, 2015, 5:23 p.m.
Col: 13 E128 continuation line under-indented for visual indent	reviewbot	Feb. 21, 2015, 5:24 p.m.
Col: 13 E128 continuation line under-indented for visual indent	reviewbot	Feb. 21, 2015, 5:24 p.m.
Col: 13 E128 continuation line under-indented for visual indent	reviewbot	Feb. 21, 2015, 5:24 p.m.
Col: 13 E128 continuation line under-indented for visual indent	reviewbot	Feb. 21, 2015, 5:24 p.m.
'django_reset' imported but unused	reviewbot	Feb. 21, 2015, 5:43 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	Feb. 21, 2015, 5:42 p.m.
'PIPELINE_JS' imported but unused	reviewbot	Feb. 21, 2015, 5:42 p.m.
'PIPELINE_CSS' imported but unused	reviewbot	Feb. 21, 2015, 5:43 p.m.
'django_reset' imported but unused	reviewbot	Feb. 23, 2015, 5:49 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	Feb. 23, 2015, 5:49 p.m.
'PIPELINE_JS' imported but unused	reviewbot	Feb. 23, 2015, 5:49 p.m.
'PIPELINE_CSS' imported but unused	reviewbot	Feb. 23, 2015, 5:49 p.m.
'ObjectDoesNotExist' imported but unused	reviewbot	Feb. 23, 2015, 5:48 p.m.
'Dir' imported but unused	reviewbot	Feb. 23, 2015, 5:48 p.m.
Col: 18 E203 whitespace before ','	reviewbot	Feb. 23, 2015, 5:48 p.m.
'django_reset' imported but unused	reviewbot	Feb. 27, 2015, 7:14 a.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	Feb. 27, 2015, 7:14 a.m.
'PIPELINE_CSS' imported but unused	reviewbot	Feb. 27, 2015, 7:14 a.m.
'PIPELINE_JS' imported but unused	reviewbot	Feb. 27, 2015, 7:14 a.m.
'django_reset' imported but unused	reviewbot	March 5, 2015, 1:46 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	March 5, 2015, 1:46 p.m.
'PIPELINE_JS' imported but unused	reviewbot	March 5, 2015, 1:46 p.m.
'PIPELINE_CSS' imported but unused	reviewbot	March 5, 2015, 1:46 p.m.
'FPA' imported but unused	reviewbot	March 5, 2015, 1:46 p.m.
Col: 25 E225 missing whitespace around operator	reviewbot	March 5, 2015, 1:46 p.m.
'django_reset' imported but unused	reviewbot	March 5, 2015, 1:46 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	March 5, 2015, 1:46 p.m.
'PIPELINE_JS' imported but unused	reviewbot	March 5, 2015, 1:46 p.m.
'PIPELINE_CSS' imported but unused	reviewbot	March 5, 2015, 1:46 p.m.
'django_reset' imported but unused	reviewbot	March 5, 2015, 3:39 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	March 5, 2015, 3:39 p.m.
'PIPELINE_JS' imported but unused	reviewbot	March 5, 2015, 3:39 p.m.
'PIPELINE_CSS' imported but unused	reviewbot	March 5, 2015, 3:39 p.m.
'django_reset' imported but unused	reviewbot	March 13, 2015, 6:13 a.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	March 13, 2015, 6:13 a.m.
'PIPELINE_JS' imported but unused	reviewbot	March 13, 2015, 6:13 a.m.
'PIPELINE_CSS' imported but unused	reviewbot	March 13, 2015, 6:13 a.m.
Docstrings should be formatted thusly: """A simple one-line summary. Detailed explanation. """	brennie	March 17, 2015, 4:40 p.m.
Blank line between these.	brennie	March 17, 2015, 4:40 p.m.
"we turn them all into the correct object" ? "deep copy"	brennie	March 17, 2015, 4:41 p.m.
Blank line between these.	brennie	March 17, 2015, 4:41 p.m.
Blank line between these.	brennie	March 17, 2015, 4:41 p.m.
Blank line between tehse.	brennie	March 17, 2015, 4:41 p.m.
No blank line here.	brennie	March 17, 2015, 4:41 p.m.
You can use for i, subitem in enumerate(item) here. Then you have access to both the index and the value.	brennie	March 17, 2015, 4:44 p.m.
Blank line between these.	brennie	March 17, 2015, 4:44 p.m.
Since you're using an elif, you may want an else: assert False case just to catch any mistakes. (This assumes …	brennie	March 17, 2015, 4:45 p.m.
Blank line between these.	brennie	March 17, 2015, 4:46 p.m.
The ObjectDoesNotExist error is a Django queryset-specific error. It is raised when a query cannot find a model instance matching …	brennie	March 17, 2015, 6:52 p.m.
Blank line between these.	brennie	March 17, 2015, 4:47 p.m.
Blank line between these.	brennie	March 17, 2015, 4:47 p.m.
Blank line between these.	brennie	March 17, 2015, 4:48 p.m.
This documentation needs to be updated to reflect that the file may be provided via a FileProvider and not a …	brennie	March 17, 2015, 4:52 p.m.
The two request.POST.get calls should be aligned.	brennie	March 17, 2015, 4:53 p.m.
You can just add file_provider_id and file_provider_path as keyword arguments defaulting to None in the function definition and then you …	brennie	March 17, 2015, 4:53 p.m.
You don't actually do anything with fields. Did you mean to return it with your INVALID_FORM_DATA response?	brennie	March 17, 2015, 4:54 p.m.
No blank line here	brennie	March 17, 2015, 4:55 p.m.
Wrap the conditional in parenthesis and you won't need the backslash.	brennie	March 17, 2015, 4:56 p.m.
This is a super general exception. In this case, we really want to catch it and log it with its …	brennie	March 17, 2015, 4:58 p.m.
No blank line here.	brennie	March 17, 2015, 4:58 p.m.
No blank line here.	brennie	March 17, 2015, 4:58 p.m.
Since this is for file provider accounts, shouldn't this be called FileProviderAccountResource ?	brennie	March 19, 2015, 1:50 p.m.
Blank line between these.	brennie	March 17, 2015, 5:03 p.m.
Trailing comma.	brennie	March 17, 2015, 5:03 p.m.
Trailing comma	brennie	March 17, 2015, 5:03 p.m.
Trailing comma	brennie	March 17, 2015, 5:03 p.m.
Trailing comma.	brennie	March 17, 2015, 5:03 p.m.
Trailing comma	brennie	March 17, 2015, 5:03 p.m.
"A JSON blob..."	brennie	March 17, 2015, 5:04 p.m.
Trailing comma.	brennie	March 17, 2015, 5:04 p.m.
Trailing comma.	brennie	March 17, 2015, 5:04 p.m.
"site" -> "provider"	brennie	March 17, 2015, 5:05 p.m.
"for" -> "from"	brennie	March 17, 2015, 5:05 p.m.
If you're allowing extra_data on this, you should mention it like the other resources that allow it do.	brennie	March 17, 2015, 5:12 p.m.
Put the ) on the previous line.	brennie	March 17, 2015, 5:13 p.m.
Trailing comma.	brennie	March 17, 2015, 5:13 p.m.
Trailing comma.	brennie	March 17, 2015, 5:13 p.m.
Trailing comma.	brennie	March 17, 2015, 5:13 p.m.
Blank line between these.	brennie	March 17, 2015, 5:13 p.m.
We format generators like so: remove_credential_keys = [ s.strip() for s in remove_credential_keys.split(',') ]	brennie	March 17, 2015, 5:13 p.m.
Instead of 'Conflicts' perhaps use 'Is mutually exlcusive with' ?	brennie	March 17, 2015, 5:15 p.m.
This should be FileProviderAccount.DoesNotExist, not the generic Django exception. Each model automatically has a subclass of the generic exception defined. …	brennie	March 17, 2015, 6:52 p.m.
No blank line here.	brennie	March 17, 2015, 5:16 p.m.
Alphabetize these.	brennie	March 17, 2015, 5:16 p.m.
Blank line between these.	brennie	March 17, 2015, 5:16 p.m.
Trailing comma here and elsewhere.	brennie	March 17, 2015, 5:16 p.m.
Trailing comma.	brennie	March 17, 2015, 5:16 p.m.
You can add the search and path as keyword arguments defaulting to None for this function. Then you don't have …	brennie	March 17, 2015, 6:29 p.m.
"that each specify"	brennie	March 17, 2015, 5:17 p.m.
'the name of the item and its type (either "file" or "folder")'	brennie	March 17, 2015, 5:18 p.m.
"will list"	brennie	March 17, 2015, 5:18 p.m.
Arguments to % formatting should go on the next line.	brennie	March 17, 2015, 5:19 p.m.
If you are explicitly checking both options, you may want to add an else: assert False case here.	brennie	March 17, 2015, 5:37 p.m.
Blank line between these.	brennie	March 17, 2015, 5:19 p.m.
Blank line between these.	brennie	March 17, 2015, 5:19 p.m.
'django_reset' imported but unused	reviewbot	March 17, 2015, 5:35 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	March 17, 2015, 5:35 p.m.
'PIPELINE_JS' imported but unused	reviewbot	March 17, 2015, 5:35 p.m.
'PIPELINE_CSS' imported but unused	reviewbot	March 17, 2015, 5:35 p.m.
Col: 80 W291 trailing whitespace	reviewbot	March 17, 2015, 5:35 p.m.
'django_reset' imported but unused	reviewbot	March 19, 2015, 1:57 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	March 19, 2015, 1:57 p.m.
'PIPELINE_JS' imported but unused	reviewbot	March 19, 2015, 1:57 p.m.
'PIPELINE_CSS' imported but unused	reviewbot	March 19, 2015, 1:57 p.m.
'django_reset' imported but unused	reviewbot	March 19, 2015, 1:57 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	March 19, 2015, 1:57 p.m.
'PIPELINE_CSS' imported but unused	reviewbot	March 19, 2015, 1:57 p.m.
'PIPELINE_JS' imported but unused	reviewbot	March 19, 2015, 1:57 p.m.
Col: 80 E501 line too long (84 > 79 characters)	reviewbot	March 19, 2015, 1:57 p.m.
Col: 29 E126 continuation line over-indented for hanging indent	reviewbot	March 19, 2015, 1:57 p.m.
'django_reset' imported but unused	reviewbot	March 19, 2015, 3:08 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	March 19, 2015, 3:08 p.m.
'PIPELINE_CSS' imported but unused	reviewbot	March 19, 2015, 3:08 p.m.
'PIPELINE_JS' imported but unused	reviewbot	March 19, 2015, 3:08 p.m.
'django_reset' imported but unused	reviewbot	March 26, 2015, 2:37 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	March 26, 2015, 2:37 p.m.
'PIPELINE_JS' imported but unused	reviewbot	March 26, 2015, 2:37 p.m.
'PIPELINE_CSS' imported but unused	reviewbot	March 26, 2015, 2:37 p.m.
Col: 80 E501 line too long (84 > 79 characters)	reviewbot	March 26, 2015, 2:37 p.m.
'django_reset' imported but unused	reviewbot	March 26, 2015, 2:36 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	March 26, 2015, 2:36 p.m.
'PIPELINE_JS' imported but unused	reviewbot	March 26, 2015, 2:36 p.m.
'PIPELINE_CSS' imported but unused	reviewbot	March 26, 2015, 2:36 p.m.
'django_reset' imported but unused	reviewbot	March 27, 2015, 7:27 a.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	March 27, 2015, 7:27 a.m.
'PIPELINE_CSS' imported but unused	reviewbot	March 27, 2015, 7:27 a.m.
'PIPELINE_JS' imported but unused	reviewbot	March 27, 2015, 7:27 a.m.
'django_reset' imported but unused	reviewbot	April 1, 2015, 2:10 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	April 1, 2015, 2:10 p.m.
'PIPELINE_JS' imported but unused	reviewbot	April 1, 2015, 2:10 p.m.
'PIPELINE_CSS' imported but unused	reviewbot	April 1, 2015, 2:10 p.m.
This is operating on self.content, modifying it in the process. That's not safe enough to do. What I'd suggest is …	chipx86	April 2, 2015, 8:22 a.m.
If the above is done as described, can this all be rolled up into that previous loop, based on the …	chipx86	April 2, 2015, 9:02 a.m.
"Return"	chipx86	April 2, 2015, 9:20 a.m.
The purpose of this isn't initially very clear. Might be worth a comment. Same in cases below.	chipx86	April 2, 2015, 8:23 a.m.
"Return" Same below.	chipx86	April 2, 2015, 9:20 a.m.
It's best not to reuse the same variable when it's representing different things (in this case, a file path and …	chipx86	April 2, 2015, 7:05 a.m.
The summary must be a single line.	chipx86	April 2, 2015, 7:03 a.m.
No need for parens.	chipx86	April 2, 2015, 7:03 a.m.
This can be one return FileProviderAccount.objects.create statement.	chipx86	April 2, 2015, 7:02 a.m.
APIs don't return exceptions> They return errors. Same below.	chipx86	April 2, 2015, 7 a.m.
Missing a space before the end of the string.	chipx86	April 2, 2015, 7 a.m.
"or with the file provider framework" could maybe be worded better. How about "..., or will send fields locating the …	chipx86	April 2, 2015, 7 a.m.
"ID" instead of "id".	chipx86	April 2, 2015, 6:58 a.m.
"Should not" isn't strong enough. How about "A file cannot be provided if file_provider_account_id or file_provider_path are also provided."	chipx86	April 2, 2015, 6:58 a.m.
Same sort of wording here. Also, this would be better as: fields['...'] = \ ['...']	chipx86	April 2, 2015, 6:58 a.m.
Same comment about the wording.	chipx86	April 2, 2015, 6:58 a.m.
Should have a trailing comma.	chipx86	April 2, 2015, 6:54 a.m.
"frame' should be "framework". Also, this should pass request=request to the function.	chipx86	April 2, 2015, 6:54 a.m.
The wrapping might be better as: { 'file_provider_account_id': [ 'No file ...', ], }	chipx86	April 2, 2015, 6:54 a.m.
Similarly, we should have some differences here. Maybe predefine a string saying "Either path or both file_provider_account_id and file_provider_path are …	chipx86	April 2, 2015, 8:11 a.m.
"... requirements that need to be filled out and configured ..."	chipx86	April 2, 2015, 6:39 a.m.
We don't want to mention internal classes here. I'd base the wording off of other resources.	chipx86	April 2, 2015, 6:41 a.m.
"... specific to ..."	chipx86	April 2, 2015, 6:40 a.m.
"The information is used to authenticate with the file provider."	chipx86	April 2, 2015, 6:41 a.m.
extra_data isn't actually a field that gets set in requests. We don't want to include this.	chipx86	April 2, 2015, 6:41 a.m.
Should have similar wording to the ones I recommended above.	chipx86	April 2, 2015, 6:42 a.m.
Maybe "Clients can choose ..."	chipx86	April 2, 2015, 6:43 a.m.
You should raise a ValueError here, in order to reuse the error result below.	chipx86	April 2, 2015, 6:43 a.m.
Swap these. It's nice not to have a not unnecessarily.	chipx86	April 2, 2015, 6:43 a.m.
Maybe "Valid credentials were not provided."	chipx86	April 2, 2015, 6:46 a.m.
In REST APIs, we're dealing with setting fields. The "remove" type of object should not be here. Instead, just have …	chipx86	April 2, 2015, 6:52 a.m.
This shouldn't be here. Same reason as above.	chipx86	April 2, 2015, 6:48 a.m.
Make sure to change this when the above is changed.	chipx86	April 2, 2015, 6:51 a.m.
We use "Deletes" twice: In the summary, and in the first sentence. Maybe we can change that. The second sentence …	chipx86	April 2, 2015, 6:37 a.m.
Swap these. They should be in alphabetical order.	chipx86	April 2, 2015, 6:35 a.m.
I don't think we need to say "... that is found." Same below.	chipx86	April 2, 2015, 6:35 a.m.
Maybe file_node? We usually use rsp as "response", as in a JSON blob.	chipx86	April 2, 2015, 6:35 a.m.
Do we want path to be optional? Or required?	chipx86	April 2, 2015, 6:37 p.m.
The wording here needs some work: "The path in the provider representing a directory or file to return information on, …	chipx86	April 2, 2015, 6:52 a.m.
The description and type are inconsistent. The type should be a bool.	chipx86	April 2, 2015, 6:29 a.m.
Which filename?	chipx86	April 2, 2015, 6:29 a.m.
Tuples aren't a good way to structure this. They're too limiting long-term, and harder to consume. Entries should be dictionaries …	chipx86	April 2, 2015, 6:27 a.m.
".. or are related ..."	chipx86	April 2, 2015, 6:25 a.m.
I don't know that we want a new error code for this. It means clients have to special-case the error. …	chipx86	April 2, 2015, 8:07 a.m.
"at the path."	chipx86	April 2, 2015, 6:24 a.m.
No blank line here.	chipx86	April 2, 2015, 6:23 a.m.
This is a pretty generic excepetion for throwing and catching here. If anything else were to throw this (list_folder, for …	chipx86	April 2, 2015, 6:23 a.m.
No blank line here.	chipx86	April 2, 2015, 6:23 a.m.
No blank line here.	chipx86	April 2, 2015, 6:23 a.m.
'django_reset' imported but unused	reviewbot	April 2, 2015, 9:46 a.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	April 2, 2015, 9:46 a.m.
'PIPELINE_CSS' imported but unused	reviewbot	April 2, 2015, 9:46 a.m.
'PIPELINE_JS' imported but unused	reviewbot	April 2, 2015, 9:46 a.m.
Should start with a capital letter and end in a period.	david	May 20, 2015, 6:09 p.m.
Should start with a capital letter and end in a period.	david	May 20, 2015, 6:09 p.m.
Can we call this variable field_errors?	david	May 20, 2015, 6:09 p.m.
Wrap the entire string in parens and then you don't need the + \\ (two strings next to each other …	david	May 20, 2015, 6:09 p.m.
Should be in the imperative mood ("Create")	david	May 20, 2015, 6:09 p.m.
This should have a docstring.	david	May 20, 2015, 6:09 p.m.
Should be in the imperative mood ("Update")	david	May 20, 2015, 6:09 p.m.
Should be in the imperative mood ("Delete")	david	May 20, 2015, 6:09 p.m.
Should be in the imperative mood.	david	May 20, 2015, 6:09 p.m.
Should be in the imperative mood.	david	May 20, 2015, 6:09 p.m.
Should be in the imperative mood.	david	May 20, 2015, 6:09 p.m.
INVALID_FORM_DATA doesn't seem like the right thing here.	david	May 20, 2015, 6:09 p.m.
This should have a docstring.	david	May 20, 2015, 6:09 p.m.
Docstring.	david	May 20, 2015, 6:09 p.m.
Two blank lines here.	david	May 20, 2015, 6:09 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/settings.py
    reviewboard/webapi/resources/file_provider.py
    reviewboard/webapi/resources/root.py
    reviewboard/webapi/errors.py
    reviewboard/webapi/tests/test_file_provider_file.py
    reviewboard/testing/fileprovider.py
    reviewboard/webapi/resources/file_provider_file.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/tests/test_file_provider.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/settings.py
    reviewboard/webapi/resources/file_provider.py
    reviewboard/webapi/resources/root.py
    reviewboard/webapi/errors.py
    reviewboard/webapi/tests/test_file_provider_file.py
    reviewboard/testing/fileprovider.py
    reviewboard/webapi/resources/file_provider_file.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/tests/test_file_provider.py

reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```
reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'PIPELINE_CSS' imported but unused
```
reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'PIPELINE_JS' imported but unused
```
reviewboard/webapi/errors.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 40
 W292 no newline at end of file
```
reviewboard/webapi/resources/file_provider.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (84 > 79 characters)
```
reviewboard/webapi/resources/file_provider_file.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
reviewboard/webapi/resources/file_provider_file.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
reviewboard/webapi/tests/test_file_provider_file.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 45
 E126 continuation line over-indented for hanging indent
```
reviewboard/webapi/tests/test_file_provider_file.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (83 > 79 characters)
```
reviewboard/webapi/tests/test_file_provider_file.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 local variable 'rsp' is assigned to but never used
```
reviewboard/webapi/tests/test_file_provider_file.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 79
 W292 no newline at end of file
```

Change Summary:

Refactored to use get_queryset, and updated any other functions as appropriate.

Change the test cases to match the refactoring.

Updated reviewboard/testing/fileprovider.py to use the new FileProviderFile for its return.

Commit:

d5814dbb99eed422d182e54a591fdbb190e4deaa

Diff:

Revision 2 (+1369 -1)

Show changes

	reviewboard/settings.py
	reviewboard/testing/fileprovider.py
	reviewboard/testing/testcase.py
	reviewboard/webapi/errors.py
	reviewboard/webapi/resources/__init__.py
	reviewboard/webapi/resources/file_provider.py
	reviewboard/webapi/resources/file_provider_file.py
	reviewboard/webapi/resources/root.py
	4 more

Tool: Pyflakes
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/settings.py
    reviewboard/webapi/resources/file_provider.py
    reviewboard/webapi/resources/root.py
    reviewboard/webapi/errors.py
    reviewboard/webapi/tests/test_file_provider_file.py
    reviewboard/testing/fileprovider.py
    reviewboard/webapi/resources/file_provider_file.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/tests/test_file_provider.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/settings.py
    reviewboard/webapi/resources/file_provider.py
    reviewboard/webapi/resources/root.py
    reviewboard/webapi/errors.py
    reviewboard/webapi/tests/test_file_provider_file.py
    reviewboard/testing/fileprovider.py
    reviewboard/webapi/resources/file_provider_file.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/tests/test_file_provider.py

reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```
reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'PIPELINE_JS' imported but unused
```
reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'PIPELINE_CSS' imported but unused
```
reviewboard/testing/fileprovider.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```

Change Summary:

Added the upload to a review request via file attachments. Also added test cases for this new implementation. Cleaned up the file_provider.py and file_provider_file.py, with updated decorators, styling and documentation. Also did clean up for their test cases. For testing/fileprovider.py, added an implementation for get_file for testing.

Commit:

d5814dbb99eed422d182e54a591fdbb190e4deaa

092c7c38ab7679d093a2867058525797ed4bce64

Diff:

Revision 3 (+1588 -8)

Show changes

	reviewboard/settings.py
	reviewboard/testing/fileprovider.py
	reviewboard/testing/testcase.py
	reviewboard/webapi/errors.py
	reviewboard/webapi/resources/__init__.py
	reviewboard/webapi/resources/base_file_attachment.py
	reviewboard/webapi/resources/file_provider.py
	reviewboard/webapi/resources/file_provider_file.py
	6 more

Tool: Pyflakes
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/resources/base_file_attachment.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/settings.py
    reviewboard/webapi/resources/file_provider.py
    reviewboard/webapi/resources/root.py
    reviewboard/webapi/errors.py
    reviewboard/webapi/tests/test_file_provider_file.py
    reviewboard/testing/fileprovider.py
    reviewboard/webapi/resources/file_provider_file.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/test_file_attachment.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/tests/test_file_provider.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/resources/base_file_attachment.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/settings.py
    reviewboard/webapi/resources/file_provider.py
    reviewboard/webapi/resources/root.py
    reviewboard/webapi/errors.py
    reviewboard/webapi/tests/test_file_provider_file.py
    reviewboard/testing/fileprovider.py
    reviewboard/webapi/resources/file_provider_file.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/test_file_attachment.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/tests/test_file_provider.py

reviewboard/settings.py (Diff revision 3)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 3)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```
reviewboard/settings.py (Diff revision 3)
The issue has been dropped. Show all issues
```
 'PIPELINE_CSS' imported but unused
```
reviewboard/settings.py (Diff revision 3)
The issue has been dropped. Show all issues
```
 'PIPELINE_JS' imported but unused
```
reviewboard/testing/fileprovider.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 69
 E502 the backslash is redundant between brackets
```
reviewboard/testing/fileprovider.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 69
 E251 unexpected spaces around keyword / parameter equals
```
reviewboard/testing/fileprovider.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
reviewboard/webapi/resources/base_file_attachment.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 32
 E127 continuation line over-indented for visual indent
```
reviewboard/webapi/resources/base_file_attachment.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (83 > 79 characters)
```
reviewboard/webapi/resources/base_file_attachment.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
reviewboard/webapi/resources/file_provider_file.py (Diff revision 3)
The issue has been resolved. Show all issues
```
 'augment_method_from' imported but unused
```
reviewboard/webapi/tests/test_file_provider_file.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 13
 E128 continuation line under-indented for visual indent
```
reviewboard/webapi/tests/test_file_provider_file.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 13
 E128 continuation line under-indented for visual indent
```
reviewboard/webapi/tests/test_file_provider_file.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 13
 E128 continuation line under-indented for visual indent
```
reviewboard/webapi/tests/test_file_provider_file.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 13
 E128 continuation line under-indented for visual indent
```

Change Summary:

Removed WIP. Also, unique checks are made to avoid duplicates, as well as style cleaning for PEP8. Change of the name of the djblets.error to match the new one.

Summary:

[WIP] FileProvider WebApi integraton

FileProvider WebApi integraton

Depends On:

~~6968 - New Error for Djblets WebApi - DUPLICATE_ITEM~~

Commit:

092c7c38ab7679d093a2867058525797ed4bce64

8c6f7eab628378997c94deff6eb5b1ff57e4bfbe

Diff:

Revision 4 (+1590 -8)

Show changes

	reviewboard/settings.py
	reviewboard/testing/fileprovider.py
	reviewboard/testing/testcase.py
	reviewboard/webapi/errors.py
	reviewboard/webapi/resources/__init__.py
	reviewboard/webapi/resources/base_file_attachment.py
	reviewboard/webapi/resources/file_provider.py
	reviewboard/webapi/resources/file_provider_file.py
	6 more

Tool: Pyflakes
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/resources/base_file_attachment.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/settings.py
    reviewboard/webapi/resources/file_provider.py
    reviewboard/webapi/resources/root.py
    reviewboard/webapi/errors.py
    reviewboard/webapi/tests/test_file_provider_file.py
    reviewboard/testing/fileprovider.py
    reviewboard/webapi/resources/file_provider_file.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/test_file_attachment.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/tests/test_file_provider.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/resources/base_file_attachment.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/settings.py
    reviewboard/webapi/resources/file_provider.py
    reviewboard/webapi/resources/root.py
    reviewboard/webapi/errors.py
    reviewboard/webapi/tests/test_file_provider_file.py
    reviewboard/testing/fileprovider.py
    reviewboard/webapi/resources/file_provider_file.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/test_file_attachment.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/tests/test_file_provider.py

reviewboard/settings.py (Diff revision 4)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 4)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```
reviewboard/settings.py (Diff revision 4)
The issue has been dropped. Show all issues
```
 'PIPELINE_JS' imported but unused
```
reviewboard/settings.py (Diff revision 4)
The issue has been dropped. Show all issues
```
 'PIPELINE_CSS' imported but unused
```

Testing Done:: ~
Test cases for GET, POST, PUT and DELETE for reviewboard/webapi/resources/file_provider.py are written.
~ Test cases for search, list content and meta-information for reviewboard/webapi/resources/file_provider_file.py are written.
~
Test cases for GET, POST, PUT and DELETE for reviewboard/webapi/resources/file_provider.py are written.
~
+
Test cases for search, list content and meta-information for reviewboard/webapi/resources/file_provider_file.py are written.
+
+
Test cases and some manual tests with the file upload via file provider framework.

Change Summary:

Changed test cases to use proper asserts, and removed all assert error messages. Added ObjectNotFound exceptions for files not found in search and others with webapi calls. Added item types 'File' or 'Directory' to the models when returned from webapi get calls. Refactored code to match update in reviewboard/fileproviders/tree.py.

Commit:

8c6f7eab628378997c94deff6eb5b1ff57e4bfbe

48a50b86b5543f661955878863c8df9f22c60c59

Diff:

Revision 5 (+1701 -9)

Show changes

	reviewboard/settings.py
	reviewboard/testing/fileprovider.py
	reviewboard/testing/testcase.py
	reviewboard/webapi/errors.py
	reviewboard/webapi/resources/__init__.py
	reviewboard/webapi/resources/base_file_attachment.py
	reviewboard/webapi/resources/file_provider.py
	reviewboard/webapi/resources/file_provider_file.py
	6 more

Tool: Pyflakes
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/resources/base_file_attachment.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/settings.py
    reviewboard/webapi/resources/file_provider.py
    reviewboard/webapi/resources/root.py
    reviewboard/webapi/errors.py
    reviewboard/webapi/tests/test_file_provider_file.py
    reviewboard/testing/fileprovider.py
    reviewboard/webapi/resources/file_provider_file.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/test_file_attachment.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/tests/test_file_provider.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/resources/base_file_attachment.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/settings.py
    reviewboard/webapi/resources/file_provider.py
    reviewboard/webapi/resources/root.py
    reviewboard/webapi/errors.py
    reviewboard/webapi/tests/test_file_provider_file.py
    reviewboard/testing/fileprovider.py
    reviewboard/webapi/resources/file_provider_file.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/test_file_attachment.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/tests/test_file_provider.py

reviewboard/settings.py (Diff revision 5)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 5)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```
reviewboard/settings.py (Diff revision 5)
The issue has been dropped. Show all issues
```
 'PIPELINE_JS' imported but unused
```
reviewboard/settings.py (Diff revision 5)
The issue has been dropped. Show all issues
```
 'PIPELINE_CSS' imported but unused
```
reviewboard/webapi/resources/file_provider_file.py (Diff revision 5)
The issue has been resolved. Show all issues
```
 'ObjectDoesNotExist' imported but unused
```
reviewboard/webapi/resources/file_provider_file.py (Diff revision 5)
The issue has been resolved. Show all issues
```
 'Dir' imported but unused
```
reviewboard/webapi/tests/test_file_attachment.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Col: 18
 E203 whitespace before ','
```

Change Summary:

Updated to adhere to PEP8 and Pyflakes.

Commit:

48a50b86b5543f661955878863c8df9f22c60c59

6812f81dbe9b83b2d978b7c4389d1cf3a5cee028

Diff:

Revision 6 (+1701 -9)

Show changes

	reviewboard/settings.py
	reviewboard/testing/fileprovider.py
	reviewboard/testing/testcase.py
	reviewboard/webapi/errors.py
	reviewboard/webapi/resources/__init__.py
	reviewboard/webapi/resources/base_file_attachment.py
	reviewboard/webapi/resources/file_provider.py
	reviewboard/webapi/resources/file_provider_file.py
	6 more

Tool: Pyflakes
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/resources/base_file_attachment.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/settings.py
    reviewboard/webapi/resources/file_provider.py
    reviewboard/webapi/resources/root.py
    reviewboard/webapi/errors.py
    reviewboard/webapi/tests/test_file_provider_file.py
    reviewboard/testing/fileprovider.py
    reviewboard/webapi/resources/file_provider_file.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/test_file_attachment.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/tests/test_file_provider.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/resources/base_file_attachment.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/settings.py
    reviewboard/webapi/resources/file_provider.py
    reviewboard/webapi/resources/root.py
    reviewboard/webapi/errors.py
    reviewboard/webapi/tests/test_file_provider_file.py
    reviewboard/testing/fileprovider.py
    reviewboard/webapi/resources/file_provider_file.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/test_file_attachment.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/tests/test_file_provider.py

reviewboard/settings.py (Diff revision 6)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 6)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```
reviewboard/settings.py (Diff revision 6)
The issue has been dropped. Show all issues
```
 'PIPELINE_CSS' imported but unused
```
reviewboard/settings.py (Diff revision 6)
The issue has been dropped. Show all issues
```
 'PIPELINE_JS' imported but unused
```

Change Summary:

Refactored the variable and class names:

FileProviderFile -> FileProviderNode
file_path -> node_path
path -> dir


This is to match new naming with changes in reviewboard/fileproviders.
New test cases were added for FileProviderNode, getting a folder from a file
Updated the testing FileProvider objects.
Removed unused test check

Commit:

6812f81dbe9b83b2d978b7c4389d1cf3a5cee028

d2349e9d4938273eadcca157adc4d6fcfed14826

Diff:

Revision 7 (+1730 -9)

Show changes

	reviewboard/settings.py
	reviewboard/testing/fileprovider.py
	reviewboard/testing/testcase.py
	reviewboard/webapi/errors.py
	reviewboard/webapi/resources/__init__.py
	reviewboard/webapi/resources/base_file_attachment.py
	reviewboard/webapi/resources/file_provider.py
	reviewboard/webapi/resources/file_provider_node.py
	6 more

Tool: Pyflakes
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/resources/base_file_attachment.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/settings.py
    reviewboard/webapi/resources/file_provider.py
    reviewboard/webapi/resources/file_provider_node.py
    reviewboard/webapi/errors.py
    reviewboard/testing/fileprovider.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/test_file_attachment.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/root.py
    reviewboard/webapi/tests/test_file_provider.py
    reviewboard/webapi/tests/test_file_provider_node.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/resources/base_file_attachment.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/settings.py
    reviewboard/webapi/resources/file_provider.py
    reviewboard/webapi/resources/file_provider_node.py
    reviewboard/webapi/errors.py
    reviewboard/testing/fileprovider.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/test_file_attachment.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/root.py
    reviewboard/webapi/tests/test_file_provider.py
    reviewboard/webapi/tests/test_file_provider_node.py

reviewboard/settings.py (Diff revision 7)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 7)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```
reviewboard/settings.py (Diff revision 7)
The issue has been dropped. Show all issues
```
 'PIPELINE_JS' imported but unused
```
reviewboard/settings.py (Diff revision 7)
The issue has been dropped. Show all issues
```
 'PIPELINE_CSS' imported but unused
```
reviewboard/webapi/tests/test_file_provider_node.py (Diff revision 7)
The issue has been resolved. Show all issues
```
 'FPA' imported but unused
```
reviewboard/webapi/tests/test_file_provider_node.py (Diff revision 7)
The issue has been resolved. Show all issues
```
Col: 25
 E225 missing whitespace around operator
```

Change Summary:

Chaged the file-providers/<id>/files/ url to file-providers/<id>/tree url.

Updated documentation for test case to reflect these changes.

Fixed issue in the testing unit for reviewboard/testing/fileprovider.py

Updated pep8 styling.

Commit:

d2349e9d4938273eadcca157adc4d6fcfed14826

723b363fd9ef263c059df5c06cf6f3322e3fb530

Diff:

Revision 8 (+1729 -9)

Show changes

	reviewboard/settings.py
	reviewboard/testing/fileprovider.py
	reviewboard/testing/testcase.py
	reviewboard/webapi/errors.py
	reviewboard/webapi/resources/__init__.py
	reviewboard/webapi/resources/base_file_attachment.py
	reviewboard/webapi/resources/file_provider.py
	reviewboard/webapi/resources/file_provider_node.py
	6 more

Tool: Pyflakes
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/resources/base_file_attachment.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/settings.py
    reviewboard/webapi/resources/file_provider.py
    reviewboard/webapi/resources/file_provider_node.py
    reviewboard/webapi/errors.py
    reviewboard/testing/fileprovider.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/test_file_attachment.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/root.py
    reviewboard/webapi/tests/test_file_provider.py
    reviewboard/webapi/tests/test_file_provider_node.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/resources/base_file_attachment.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/settings.py
    reviewboard/webapi/resources/file_provider.py
    reviewboard/webapi/resources/file_provider_node.py
    reviewboard/webapi/errors.py
    reviewboard/testing/fileprovider.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/test_file_attachment.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/root.py
    reviewboard/webapi/tests/test_file_provider.py
    reviewboard/webapi/tests/test_file_provider_node.py

reviewboard/settings.py (Diff revision 8)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 8)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```
reviewboard/settings.py (Diff revision 8)
The issue has been resolved. Show all issues
```
 'PIPELINE_JS' imported but unused
```
reviewboard/settings.py (Diff revision 8)
The issue has been dropped. Show all issues
```
 'PIPELINE_CSS' imported but unused
```

Change Summary:

Updated to reflect changes in reviewboard/fileproviders/tree.py

Commit:

723b363fd9ef263c059df5c06cf6f3322e3fb530

ac0aa7026c58a33df3c62c30fcf24b3d9ee93b41

Diff:

Revision 9 (+1721 -9)

Show changes

	reviewboard/settings.py
	reviewboard/testing/fileprovider.py
	reviewboard/testing/testcase.py
	reviewboard/webapi/errors.py
	reviewboard/webapi/resources/__init__.py
	reviewboard/webapi/resources/base_file_attachment.py
	reviewboard/webapi/resources/file_provider.py
	reviewboard/webapi/resources/file_provider_node.py
	6 more

Tool: Pyflakes
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/resources/base_file_attachment.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/settings.py
    reviewboard/webapi/resources/file_provider.py
    reviewboard/webapi/resources/file_provider_node.py
    reviewboard/webapi/errors.py
    reviewboard/testing/fileprovider.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/test_file_attachment.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/root.py
    reviewboard/webapi/tests/test_file_provider.py
    reviewboard/webapi/tests/test_file_provider_node.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/resources/base_file_attachment.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/settings.py
    reviewboard/webapi/resources/file_provider.py
    reviewboard/webapi/resources/file_provider_node.py
    reviewboard/webapi/errors.py
    reviewboard/testing/fileprovider.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/test_file_attachment.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/root.py
    reviewboard/webapi/tests/test_file_provider.py
    reviewboard/webapi/tests/test_file_provider_node.py

reviewboard/settings.py (Diff revision 9)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 9)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```
reviewboard/settings.py (Diff revision 9)
The issue has been dropped. Show all issues
```
 'PIPELINE_JS' imported but unused
```
reviewboard/settings.py (Diff revision 9)
The issue has been dropped. Show all issues
```
 'PIPELINE_CSS' imported but unused
```

Change Summary:

Changed expected status code for reviewboard.webapi.tests.test_file_provider:ResourceListTests.test_post_with_duplicate_accounts to reflect changes in djblet

Commit:

ac0aa7026c58a33df3c62c30fcf24b3d9ee93b41

c8956e221e2070bbb4ea5991c877ef1675b3b9a8

Diff:

Revision 10 (+1721 -9)

Show changes

	reviewboard/settings.py
	reviewboard/testing/fileprovider.py
	reviewboard/testing/testcase.py
	reviewboard/webapi/errors.py
	reviewboard/webapi/resources/__init__.py
	reviewboard/webapi/resources/base_file_attachment.py
	reviewboard/webapi/resources/file_provider.py
	reviewboard/webapi/resources/file_provider_node.py
	6 more

Tool: Pyflakes
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/resources/base_file_attachment.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/settings.py
    reviewboard/webapi/resources/file_provider.py
    reviewboard/webapi/resources/file_provider_node.py
    reviewboard/webapi/errors.py
    reviewboard/testing/fileprovider.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/test_file_attachment.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/root.py
    reviewboard/webapi/tests/test_file_provider.py
    reviewboard/webapi/tests/test_file_provider_node.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/resources/base_file_attachment.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/settings.py
    reviewboard/webapi/resources/file_provider.py
    reviewboard/webapi/resources/file_provider_node.py
    reviewboard/webapi/errors.py
    reviewboard/testing/fileprovider.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/test_file_attachment.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/root.py
    reviewboard/webapi/tests/test_file_provider.py
    reviewboard/webapi/tests/test_file_provider_node.py

reviewboard/settings.py (Diff revision 10)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 10)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```
reviewboard/settings.py (Diff revision 10)
The issue has been dropped. Show all issues
```
 'PIPELINE_JS' imported but unused
```
reviewboard/settings.py (Diff revision 10)
The issue has been dropped. Show all issues
```
 'PIPELINE_CSS' imported but unused
```

reviewboard/testing/fileprovider.py (Diff revision 10)

The issue has been resolved. Show all issues

Docstrings should be formatted thusly:

"""A simple one-line summary.

Detailed explanation.
"""

reviewboard/testing/fileprovider.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Blank line between these.
```
reviewboard/testing/fileprovider.py (Diff revision 10)
The issue has been resolved. Show all issues
```
"we turn them all into the correct object" ?
"deep copy"
```
reviewboard/testing/fileprovider.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Blank line between these.
```
reviewboard/testing/fileprovider.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Blank line between these.
```
reviewboard/testing/fileprovider.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Blank line between tehse.
```
reviewboard/testing/fileprovider.py (Diff revision 10)
The issue has been resolved. Show all issues
```
No blank line here.
```

reviewboard/testing/fileprovider.py (Diff revision 10)

The issue has been resolved. Show all issues

You can use for i, subitem in enumerate(item) here. Then you have access to both the index and the value.

reviewboard/testing/fileprovider.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Blank line between these.
```

reviewboard/testing/fileprovider.py (Diff revision 10)

The issue has been resolved. Show all issues

Since you're using an elif, you may want an else: assert False case just to catch any mistakes. (This assumes that dict and list are the only such options.)

reviewboard/testing/fileprovider.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Blank line between these.
```

reviewboard/testing/fileprovider.py (Diff revision 10)

The issue has been resolved. Show all issues

The ObjectDoesNotExist error is a Django queryset-specific error. It is raised when a query cannot find a model instance matching the give queryset.

It is probably worth it to subclass exception as FileProviderError and, if needed, you can subclass that for a FileNotFoundError (or similar) that is specific to file providers.

reviewboard/testing/fileprovider.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Blank line between these.
```
reviewboard/testing/fileprovider.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Blank line between these.
```
reviewboard/testing/fileprovider.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Blank line between these.
```

reviewboard/webapi/resources/base_file_attachment.py (Diff revision 10)

The issue has been resolved. Show all issues

This documentation needs to be updated to reflect that the file may be provided via a FileProvider and not a file upload.

reviewboard/webapi/resources/base_file_attachment.py (Diff revision 10)
The issue has been resolved. Show all issues
```
The two request.POST.get calls should be aligned.
```

reviewboard/webapi/resources/base_file_attachment.py (Diff revision 10)

The issue has been resolved. Show all issues

You can just add file_provider_id and file_provider_path as keyword arguments defaulting to None in the function definition and then you don't have to use request.POST every time.
It will also making your formatting easier because the arguments won't be as long.

reviewboard/webapi/resources/base_file_attachment.py (Diff revision 10)

The issue has been resolved. Show all issues

You don't actually do anything with fields. Did you mean to return it with your INVALID_FORM_DATA response?

VTL-Developer March 19, 2015, 1:54 p.m.

Yes, used the variable fields with INVALID_FORM_DATA

reviewboard/webapi/resources/base_file_attachment.py (Diff revision 10)
The issue has been resolved. Show all issues
```
No blank line here
```
reviewboard/webapi/resources/base_file_attachment.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Wrap the conditional in parenthesis and you won't need the backslash.
```

reviewboard/webapi/resources/base_file_attachment.py (Diff revision 10)

The issue has been resolved. Show all issues

This is a super general exception. In this case, we really want to catch it and log it with its traceback.

reviewboard/webapi/resources/base_file_attachment.py (Diff revision 10)
The issue has been resolved. Show all issues
```
No blank line here.
```
reviewboard/webapi/resources/base_file_attachment.py (Diff revision 10)
The issue has been resolved. Show all issues
```
No blank line here.
```

reviewboard/webapi/resources/file_provider.py (Diff revision 10)

The issue has been resolved. Show all issues

Since this is for file provider accounts, shouldn't this be called FileProviderAccountResource ?

VTL-Developer March 19, 2015, 1:54 p.m.

Made the change, and propagated changes to file names, variables, docstrings, etc.

reviewboard/webapi/resources/file_provider.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Blank line between these.
```
reviewboard/webapi/resources/file_provider.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Trailing comma.
```
reviewboard/webapi/resources/file_provider.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Trailing comma
```
reviewboard/webapi/resources/file_provider.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Trailing comma
```
reviewboard/webapi/resources/file_provider.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Trailing comma.
```
reviewboard/webapi/resources/file_provider.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Trailing comma
```
reviewboard/webapi/resources/file_provider.py (Diff revision 10)
The issue has been resolved. Show all issues
```
"A JSON blob..."
```
reviewboard/webapi/resources/file_provider.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Trailing comma.
```
reviewboard/webapi/resources/file_provider.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Trailing comma.
```
reviewboard/webapi/resources/file_provider.py (Diff revision 10)
The issue has been resolved. Show all issues
```
"site" -> "provider"
```
reviewboard/webapi/resources/file_provider.py (Diff revision 10)
The issue has been resolved. Show all issues
```
"for" -> "from"
```

reviewboard/webapi/resources/file_provider.py (Diff revision 10)

The issue has been resolved. Show all issues

If you're allowing extra_data on this, you should mention it like the other resources that allow it do.

reviewboard/webapi/resources/file_provider.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Put the ) on the previous line.
```
reviewboard/webapi/resources/file_provider.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Trailing comma.
```
reviewboard/webapi/resources/file_provider.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Trailing comma.
```
reviewboard/webapi/resources/file_provider.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Trailing comma.
```
reviewboard/webapi/resources/file_provider.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Blank line between these.
```

reviewboard/webapi/resources/file_provider.py (Diff revision 10)

The issue has been resolved. Show all issues

We format generators like so:
remove_credential_keys = [
    s.strip()
    for s in remove_credential_keys.split(',')
]

reviewboard/webapi/resources/file_provider.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Instead of 'Conflicts' perhaps use 'Is mutually exlcusive with' ?
```

reviewboard/webapi/resources/file_provider.py (Diff revision 10)

The issue has been resolved. Show all issues

This should be FileProviderAccount.DoesNotExist, not the generic Django exception. Each model automatically has a subclass of the generic exception defined.

This is another reason why I want to discourage you from using the generic ObjectDoesNotExist error elsewhere. You don't want to accidentally catch the wrong exception and have the wrong error-handling code.

reviewboard/webapi/resources/file_provider_node.py (Diff revision 10)
The issue has been resolved. Show all issues
```
No blank line here.
```
reviewboard/webapi/resources/file_provider_node.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Alphabetize these.
```
reviewboard/webapi/resources/file_provider_node.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Blank line between these.
```
reviewboard/webapi/resources/file_provider_node.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Trailing comma here and elsewhere.
```
reviewboard/webapi/resources/file_provider_node.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Trailing comma.
```

reviewboard/webapi/resources/file_provider_node.py (Diff revision 10)

The issue has been resolved. Show all issues

You can add the search and path as keyword arguments defaulting to None for this function. Then you don't have to hassle with request.GET.

reviewboard/webapi/resources/file_provider_node.py (Diff revision 10)
The issue has been resolved. Show all issues
```
"that each specify"
```
reviewboard/webapi/resources/file_provider_node.py (Diff revision 10)
The issue has been resolved. Show all issues
```
'the name of the item and its type (either "file" or "folder")'
```
reviewboard/webapi/resources/file_provider_node.py (Diff revision 10)
The issue has been resolved. Show all issues
```
"will list"
```
reviewboard/webapi/resources/file_provider_node.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Arguments to % formatting should go on the next line.
```

reviewboard/webapi/resources/file_provider_node.py (Diff revision 10)

The issue has been resolved. Show all issues

If you are explicitly checking both options, you may want to add an else: assert False case here.

reviewboard/webapi/resources/file_provider_node.py (Diff revision 10)

Why is this method required? Does the default behaviour cause issues?

VTL-Developer March 19, 2015, 1:54 p.m.

It had to be overwritten as the model used for this API endpoint is an object, not a django model. When we call register_resource_for_model, it seems to be meant to map WebApi resources to the respectful model. This alternative method is found being done by other webapi resources such as hosting_service.py and remote_repository.py.

reviewboard/webapi/tests/test_file_provider.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Blank line between these.
```
reviewboard/webapi/tests/test_file_provider_node.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Blank line between these.
```

Change Summary:

Add changes to reflect the changes for /r/6806.

- reviewboard.fileproviders.tree.Node new variable names and initialization param order propagated to testing and webapi.
- Removal of parenthesis for imports.
- Additional comments and code clean-up was done.

Commit:

c8956e221e2070bbb4ea5991c877ef1675b3b9a8

c9b816057d30e7fffaf66c08b48b2d6c9cc9bfac

Diff:

Revision 11 (+1723 -9)

Show changes

	reviewboard/settings.py
	reviewboard/testing/fileprovider.py
	reviewboard/testing/testcase.py
	reviewboard/webapi/errors.py
	reviewboard/webapi/resources/__init__.py
	reviewboard/webapi/resources/base_file_attachment.py
	reviewboard/webapi/resources/file_provider.py
	reviewboard/webapi/resources/file_provider_node.py
	6 more

Tool: Pyflakes
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/resources/base_file_attachment.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/settings.py
    reviewboard/webapi/resources/file_provider.py
    reviewboard/webapi/resources/file_provider_node.py
    reviewboard/webapi/errors.py
    reviewboard/testing/fileprovider.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/test_file_attachment.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/root.py
    reviewboard/webapi/tests/test_file_provider.py
    reviewboard/webapi/tests/test_file_provider_node.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/resources/base_file_attachment.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/settings.py
    reviewboard/webapi/resources/file_provider.py
    reviewboard/webapi/resources/file_provider_node.py
    reviewboard/webapi/errors.py
    reviewboard/testing/fileprovider.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/test_file_attachment.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/root.py
    reviewboard/webapi/tests/test_file_provider.py
    reviewboard/webapi/tests/test_file_provider_node.py

reviewboard/settings.py (Diff revision 11)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 11)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```
reviewboard/settings.py (Diff revision 11)
The issue has been dropped. Show all issues
```
 'PIPELINE_JS' imported but unused
```
reviewboard/settings.py (Diff revision 11)
The issue has been dropped. Show all issues
```
 'PIPELINE_CSS' imported but unused
```
reviewboard/webapi/resources/file_provider_node.py (Diff revision 11)
The issue has been resolved. Show all issues
```
Col: 80
 W291 trailing whitespace
```

Change Summary:

Made changes as suggested by reviews
  - code styling (blank spaces, indentation, etc.)
  - adding and updating documentation
  - Added new usage of new error (NodeNotFoundError) for interaction with FileProvider framework
  - function definitions updated to include required params, instead of retreiving from request object

Commit:

c9b816057d30e7fffaf66c08b48b2d6c9cc9bfac

06028be05eb7ad8ccf91d8a587e34fa7dc6e5784

Diff:

Revision 12 (+1784 -11)

Show changes

	reviewboard/settings.py
	reviewboard/testing/fileprovider.py
	reviewboard/testing/testcase.py
	reviewboard/webapi/errors.py
	reviewboard/webapi/resources/__init__.py
	reviewboard/webapi/resources/base_file_attachment.py
	reviewboard/webapi/resources/file_provider.py
	reviewboard/webapi/resources/file_provider_node.py
	6 more

Tool: Pyflakes
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/resources/base_file_attachment.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/settings.py
    reviewboard/webapi/resources/file_provider.py
    reviewboard/webapi/resources/file_provider_node.py
    reviewboard/webapi/errors.py
    reviewboard/testing/fileprovider.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/test_file_attachment.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/root.py
    reviewboard/webapi/tests/test_file_provider.py
    reviewboard/webapi/tests/test_file_provider_node.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/resources/base_file_attachment.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/settings.py
    reviewboard/webapi/resources/file_provider.py
    reviewboard/webapi/resources/file_provider_node.py
    reviewboard/webapi/errors.py
    reviewboard/testing/fileprovider.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/test_file_attachment.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/root.py
    reviewboard/webapi/tests/test_file_provider.py
    reviewboard/webapi/tests/test_file_provider_node.py

reviewboard/settings.py (Diff revision 12)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 12)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```
reviewboard/settings.py (Diff revision 12)
The issue has been dropped. Show all issues
```
 'PIPELINE_JS' imported but unused
```
reviewboard/settings.py (Diff revision 12)
The issue has been dropped. Show all issues
```
 'PIPELINE_CSS' imported but unused
```

Change Summary:

Renaming of the FileProviderResource to FileProviderAccount resource. Propagate the change of the name as necessary (for variables, docstring, file names, etc.)

Added metadata to initalization of Files in reviewboard.testing.fileproviders

Commit:

06028be05eb7ad8ccf91d8a587e34fa7dc6e5784

8102391aaca2332ed5489e250c6490563b55db86

Diff:

Revision 13 (+1787 -11)

Show changes

	reviewboard/settings.py
	reviewboard/testing/fileprovider.py
	reviewboard/testing/testcase.py
	reviewboard/webapi/errors.py
	reviewboard/webapi/resources/__init__.py
	reviewboard/webapi/resources/base_file_attachment.py
	reviewboard/webapi/resources/file_provider_account.py
	reviewboard/webapi/resources/file_provider_node.py
	6 more

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/resources/base_file_attachment.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/settings.py
    reviewboard/webapi/resources/file_provider_node.py
    reviewboard/webapi/errors.py
    reviewboard/testing/fileprovider.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/test_file_attachment.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/root.py
    reviewboard/webapi/resources/file_provider_account.py
    reviewboard/webapi/tests/test_file_provider_account.py
    reviewboard/webapi/tests/test_file_provider_node.py



Tool: Pyflakes
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/resources/base_file_attachment.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/settings.py
    reviewboard/webapi/resources/file_provider_node.py
    reviewboard/webapi/errors.py
    reviewboard/testing/fileprovider.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/test_file_attachment.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/root.py
    reviewboard/webapi/resources/file_provider_account.py
    reviewboard/webapi/tests/test_file_provider_account.py
    reviewboard/webapi/tests/test_file_provider_node.py

reviewboard/settings.py (Diff revision 13)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 13)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```
reviewboard/settings.py (Diff revision 13)
The issue has been dropped. Show all issues
```
 'PIPELINE_CSS' imported but unused
```
reviewboard/settings.py (Diff revision 13)
The issue has been dropped. Show all issues
```
 'PIPELINE_JS' imported but unused
```
reviewboard/webapi/resources/__init__.py (Diff revision 13)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (84 > 79 characters)
```
reviewboard/webapi/tests/test_file_provider_account.py (Diff revision 13)
The issue has been resolved. Show all issues
```
Col: 29
 E126 continuation line over-indented for hanging indent
```

Change Summary:

Fixed for pyflakes and pep-8 styling.

Commit:

8102391aaca2332ed5489e250c6490563b55db86

67b7196f1e063ec273b7c1baa838b5ce05df715e

Diff:

Revision 14 (+1788 -11)

Show changes

	reviewboard/settings.py
	reviewboard/testing/fileprovider.py
	reviewboard/testing/testcase.py
	reviewboard/webapi/errors.py
	reviewboard/webapi/resources/__init__.py
	reviewboard/webapi/resources/base_file_attachment.py
	reviewboard/webapi/resources/file_provider_account.py
	reviewboard/webapi/resources/file_provider_node.py
	6 more

Tool: Pyflakes
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/resources/base_file_attachment.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/settings.py
    reviewboard/webapi/resources/file_provider_node.py
    reviewboard/webapi/errors.py
    reviewboard/testing/fileprovider.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/test_file_attachment.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/root.py
    reviewboard/webapi/resources/file_provider_account.py
    reviewboard/webapi/tests/test_file_provider_account.py
    reviewboard/webapi/tests/test_file_provider_node.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/resources/base_file_attachment.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/settings.py
    reviewboard/webapi/resources/file_provider_node.py
    reviewboard/webapi/errors.py
    reviewboard/testing/fileprovider.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/test_file_attachment.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/root.py
    reviewboard/webapi/resources/file_provider_account.py
    reviewboard/webapi/tests/test_file_provider_account.py
    reviewboard/webapi/tests/test_file_provider_node.py

reviewboard/settings.py (Diff revision 14)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 14)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```
reviewboard/settings.py (Diff revision 14)
The issue has been dropped. Show all issues
```
 'PIPELINE_CSS' imported but unused
```
reviewboard/settings.py (Diff revision 14)
The issue has been dropped. Show all issues
```
 'PIPELINE_JS' imported but unused
```

Change Summary:

Added more name changes to variables to represent change of resource FileProviderResource (the old way to represent File Provider Accounts) to FileProviderAccountResource.

Summary:

FileProvider WebApi integraton

FileProvider WebApi interaction with file provider account

Testing Done:

~		Test cases for GET, POST, PUT and DELETE for `reviewboard/webapi/resources/file_provider.py` are written.
	~	Test cases for GET, POST, PUT and DELETE for `reviewboard/webapi/resources/file_provider_account.py` are written.

~		Test cases for search, list content and meta-information for `reviewboard/webapi/resources/file_provider_file.py` are written.
	~	Test cases for search, list content and meta-information for `reviewboard/webapi/resources/file_provider_node.py` are written.

		Test cases and some manual tests with the file upload via file provider framework.

Commit:

67b7196f1e063ec273b7c1baa838b5ce05df715e

897bf339119d311786cb26f82772e0939212f901

Diff:

Revision 15 (+1791 -11)

Show changes

	reviewboard/settings.py
	reviewboard/testing/fileprovider.py
	reviewboard/testing/testcase.py
	reviewboard/webapi/errors.py
	reviewboard/webapi/resources/__init__.py
	reviewboard/webapi/resources/base_file_attachment.py
	reviewboard/webapi/resources/file_provider_account.py
	reviewboard/webapi/resources/file_provider_node.py
	6 more

Tool: Pyflakes
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/resources/base_file_attachment.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/settings.py
    reviewboard/webapi/resources/file_provider_node.py
    reviewboard/webapi/errors.py
    reviewboard/testing/fileprovider.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/test_file_attachment.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/root.py
    reviewboard/webapi/resources/file_provider_account.py
    reviewboard/webapi/tests/test_file_provider_account.py
    reviewboard/webapi/tests/test_file_provider_node.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/resources/base_file_attachment.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/settings.py
    reviewboard/webapi/resources/file_provider_node.py
    reviewboard/webapi/errors.py
    reviewboard/testing/fileprovider.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/test_file_attachment.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/root.py
    reviewboard/webapi/resources/file_provider_account.py
    reviewboard/webapi/tests/test_file_provider_account.py
    reviewboard/webapi/tests/test_file_provider_node.py

reviewboard/settings.py (Diff revision 15)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 15)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```
reviewboard/settings.py (Diff revision 15)
The issue has been dropped. Show all issues
```
 'PIPELINE_JS' imported but unused
```
reviewboard/settings.py (Diff revision 15)
The issue has been dropped. Show all issues
```
 'PIPELINE_CSS' imported but unused
```
reviewboard/webapi/tests/urls.py (Diff revision 15)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (84 > 79 characters)
```

Change Summary:

Fixed character length limit.

Commit:

897bf339119d311786cb26f82772e0939212f901

fee773bbdc96cab414f4afca7580dc2a29dcaa73

Diff:

Revision 16 (+1792 -11)

Show changes

	reviewboard/settings.py
	reviewboard/testing/fileprovider.py
	reviewboard/testing/testcase.py
	reviewboard/webapi/errors.py
	reviewboard/webapi/resources/__init__.py
	reviewboard/webapi/resources/base_file_attachment.py
	reviewboard/webapi/resources/file_provider_account.py
	reviewboard/webapi/resources/file_provider_node.py
	6 more

Tool: Pyflakes
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/resources/base_file_attachment.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/settings.py
    reviewboard/webapi/resources/file_provider_node.py
    reviewboard/webapi/errors.py
    reviewboard/testing/fileprovider.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/test_file_attachment.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/root.py
    reviewboard/webapi/resources/file_provider_account.py
    reviewboard/webapi/tests/test_file_provider_account.py
    reviewboard/webapi/tests/test_file_provider_node.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/resources/base_file_attachment.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/settings.py
    reviewboard/webapi/resources/file_provider_node.py
    reviewboard/webapi/errors.py
    reviewboard/testing/fileprovider.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/test_file_attachment.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/root.py
    reviewboard/webapi/resources/file_provider_account.py
    reviewboard/webapi/tests/test_file_provider_account.py
    reviewboard/webapi/tests/test_file_provider_node.py

reviewboard/settings.py (Diff revision 16)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 16)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```
reviewboard/settings.py (Diff revision 16)
The issue has been dropped. Show all issues
```
 'PIPELINE_JS' imported but unused
```
reviewboard/settings.py (Diff revision 16)
The issue has been dropped. Show all issues
```
 'PIPELINE_CSS' imported but unused
```

Change Summary:

Renamed the file_provider_id to file_provider_account_id, matching to the new FileProviderAccountResource renaming.

Commit:

fee773bbdc96cab414f4afca7580dc2a29dcaa73

120fe23af4315b862738ececeb5940c6b0eeaa86

Diff:

Revision 17 (+1794 -11)

Show changes

	reviewboard/settings.py
	reviewboard/testing/fileprovider.py
	reviewboard/testing/testcase.py
	reviewboard/webapi/errors.py
	reviewboard/webapi/resources/__init__.py
	reviewboard/webapi/resources/base_file_attachment.py
	reviewboard/webapi/resources/file_provider_account.py
	reviewboard/webapi/resources/file_provider_node.py
	6 more

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/resources/base_file_attachment.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/settings.py
    reviewboard/webapi/resources/file_provider_node.py
    reviewboard/webapi/errors.py
    reviewboard/testing/fileprovider.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/test_file_attachment.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/root.py
    reviewboard/webapi/resources/file_provider_account.py
    reviewboard/webapi/tests/test_file_provider_account.py
    reviewboard/webapi/tests/test_file_provider_node.py



Tool: Pyflakes
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/resources/base_file_attachment.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/settings.py
    reviewboard/webapi/resources/file_provider_node.py
    reviewboard/webapi/errors.py
    reviewboard/testing/fileprovider.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/test_file_attachment.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/root.py
    reviewboard/webapi/resources/file_provider_account.py
    reviewboard/webapi/tests/test_file_provider_account.py
    reviewboard/webapi/tests/test_file_provider_node.py

reviewboard/settings.py (Diff revision 17)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 17)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```
reviewboard/settings.py (Diff revision 17)
The issue has been dropped. Show all issues
```
 'PIPELINE_CSS' imported but unused
```
reviewboard/settings.py (Diff revision 17)
The issue has been dropped. Show all issues
```
 'PIPELINE_JS' imported but unused
```

Change Summary:

In order to line-up with credentials default value of {} in the models, had to remove the length check for credentials for api/file-provider-accounts/ POST requests to allow creation

Commit:

120fe23af4315b862738ececeb5940c6b0eeaa86

0121c613fbf432c071f46e7ae51c4c0faa341e95

Diff:

Revision 18 (+1788 -11)

Show changes

	reviewboard/settings.py
	reviewboard/testing/fileprovider.py
	reviewboard/testing/testcase.py
	reviewboard/webapi/errors.py
	reviewboard/webapi/resources/__init__.py
	reviewboard/webapi/resources/base_file_attachment.py
	reviewboard/webapi/resources/file_provider_account.py
	reviewboard/webapi/resources/file_provider_node.py
	6 more

Tool: Pyflakes
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/resources/base_file_attachment.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/settings.py
    reviewboard/webapi/resources/file_provider_node.py
    reviewboard/webapi/errors.py
    reviewboard/testing/fileprovider.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/test_file_attachment.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/root.py
    reviewboard/webapi/resources/file_provider_account.py
    reviewboard/webapi/tests/test_file_provider_account.py
    reviewboard/webapi/tests/test_file_provider_node.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/resources/base_file_attachment.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/settings.py
    reviewboard/webapi/resources/file_provider_node.py
    reviewboard/webapi/errors.py
    reviewboard/testing/fileprovider.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/test_file_attachment.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/root.py
    reviewboard/webapi/resources/file_provider_account.py
    reviewboard/webapi/tests/test_file_provider_account.py
    reviewboard/webapi/tests/test_file_provider_node.py

reviewboard/settings.py (Diff revision 18)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 18)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```
reviewboard/settings.py (Diff revision 18)
The issue has been dropped. Show all issues
```
 'PIPELINE_JS' imported but unused
```
reviewboard/settings.py (Diff revision 18)
The issue has been dropped. Show all issues
```
 'PIPELINE_CSS' imported but unused
```

I know this is a long review, but it's a long change.
I didn't look at the unit tests too closely. The vast majority of the comments are documentation changes for the public API. There are a few small design notes I have though.

reviewboard/testing/fileprovider.py (Diff revision 18)

The issue has been resolved. Show all issues

This is operating on self.content, modifying it in the process. That's not safe enough to do. What I'd suggest is building self.content off of the version in the class, and not copying it first.

Maybe that can be called DEFAULT_CONTENT at that point.

reviewboard/testing/fileprovider.py (Diff revision 18)

The issue has been resolved. Show all issues

If the above is done as described, can this all be rolled up into that previous loop, based on the path content in the version in the class?

reviewboard/testing/fileprovider.py (Diff revision 18)
The issue has been resolved. Show all issues
```
"Return"
```

reviewboard/testing/fileprovider.py (Diff revision 18)

The issue has been resolved. Show all issues

The purpose of this isn't initially very clear. Might be worth a comment.

Same in cases below.

reviewboard/testing/fileprovider.py (Diff revision 18)
The issue has been resolved. Show all issues
```
"Return"
Same below.
```

reviewboard/testing/fileprovider.py (Diff revision 18)

The issue has been resolved. Show all issues

It's best not to reuse the same variable when it's representing different things (in this case, a file path and then a file handle).

Also, single quotes are preferable over double quotes when possible.

reviewboard/testing/fileprovider.py (Diff revision 18)
The issue has been resolved. Show all issues
```
The summary must be a single line.
```
reviewboard/testing/fileprovider.py (Diff revision 18)
The issue has been resolved. Show all issues
```
No need for parens.
```

reviewboard/testing/testcase.py (Diff revision 18)

The issue has been resolved. Show all issues

This can be one return FileProviderAccount.objects.create statement.

reviewboard/webapi/resources/base_file_attachment.py (Diff revision 18)
The issue has been resolved. Show all issues
```
APIs don't return exceptions> They return errors.
Same below.
```
reviewboard/webapi/resources/base_file_attachment.py (Diff revision 18)
The issue has been resolved. Show all issues
```
Missing a space before the end of the string.
```

reviewboard/webapi/resources/base_file_attachment.py (Diff revision 18)

The issue has been resolved. Show all issues

"or with the file provider framework" could maybe be worded better. How about "..., or will send fields locating the file on a registered file provider."

reviewboard/webapi/resources/base_file_attachment.py (Diff revision 18)
The issue has been resolved. Show all issues
```
"ID" instead of "id".
```

reviewboard/webapi/resources/base_file_attachment.py (Diff revision 18)

The issue has been resolved. Show all issues

"Should not" isn't strong enough. How about "A file cannot be provided if file_provider_account_id or file_provider_path are also provided."

reviewboard/webapi/resources/base_file_attachment.py (Diff revision 18)

The issue has been resolved. Show all issues

Same sort of wording here.
Also, this would be better as:

fields['...'] = \
    ['...']

reviewboard/webapi/resources/base_file_attachment.py (Diff revision 18)
The issue has been resolved. Show all issues
```
Same comment about the wording.
```
reviewboard/webapi/resources/base_file_attachment.py (Diff revision 18)
The issue has been resolved. Show all issues
```
Should have a trailing comma.
```
reviewboard/webapi/resources/base_file_attachment.py (Diff revision 18)
The issue has been resolved. Show all issues
```
"frame' should be "framework".
Also, this should pass request=request to the function.
```

reviewboard/webapi/resources/base_file_attachment.py (Diff revision 18)

The issue has been resolved. Show all issues

The wrapping might be better as:

{
    'file_provider_account_id': [
        'No file ...',
     ],
}

reviewboard/webapi/resources/base_file_attachment.py (Diff revision 18)

The issue has been resolved. Show all issues

Similarly, we should have some differences here.

Maybe predefine a string saying "Either path or both file_provider_account_id and file_provider_path are required."

reviewboard/webapi/resources/file_provider_account.py (Diff revision 18)
The issue has been resolved. Show all issues
```
"... requirements that need to be filled out and configured ..."
```
reviewboard/webapi/resources/file_provider_account.py (Diff revision 18)
The issue has been resolved. Show all issues
```
We don't want to mention internal classes here. I'd base the wording off of other resources.
```
reviewboard/webapi/resources/file_provider_account.py (Diff revision 18)
The issue has been resolved. Show all issues
```
"... specific to ..."
```
reviewboard/webapi/resources/file_provider_account.py (Diff revision 18)
The issue has been resolved. Show all issues
```
"The information is used to authenticate with the file provider."
```

reviewboard/webapi/resources/file_provider_account.py (Diff revision 18)

The issue has been resolved. Show all issues

extra_data isn't actually a field that gets set in requests. We don't want to include this.

reviewboard/webapi/resources/file_provider_account.py (Diff revision 18)
The issue has been resolved. Show all issues
```
Should have similar wording to the ones I recommended above.
```
reviewboard/webapi/resources/file_provider_account.py (Diff revision 18)
The issue has been resolved. Show all issues
```
Maybe "Clients can choose ..."
```

reviewboard/webapi/resources/file_provider_account.py (Diff revision 18)

The issue has been resolved. Show all issues

You should raise a ValueError here, in order to reuse the error result below.

reviewboard/webapi/resources/file_provider_account.py (Diff revision 18)

The issue has been resolved. Show all issues

Swap these. It's nice not to have a not unnecessarily.

reviewboard/webapi/resources/file_provider_account.py (Diff revision 18)
The issue has been resolved. Show all issues
```
Maybe "Valid credentials were not provided."
```

reviewboard/webapi/resources/file_provider_account.py (Diff revision 18)

The issue has been resolved. Show all issues

In REST APIs, we're dealing with setting fields. The "remove" type of object should not be here. Instead, just have "credentials" overwrite.

Also, as above, we shouldn't reference "FileProviderAccount" in API docs, since it's an internal detail.

reviewboard/webapi/resources/file_provider_account.py (Diff revision 18)

The issue has been resolved. Show all issues

This shouldn't be here. Same reason as above.

reviewboard/webapi/resources/file_provider_account.py (Diff revision 18)
The issue has been resolved. Show all issues
```
Make sure to change this when the above is changed.
```

reviewboard/webapi/resources/file_provider_account.py (Diff revision 18)

The issue has been resolved. Show all issues

We use "Deletes" twice: In the summary, and in the first sentence. Maybe we can change that.

The second sentence should probably say "For some file providers, Review Board's authentication token will be removed from the service, preventing the token from being re-used. This is not supported for all services."

reviewboard/webapi/resources/file_provider_node.py (Diff revision 18)
The issue has been resolved. Show all issues
```
Swap these. They should be in alphabetical order.
```
reviewboard/webapi/resources/file_provider_node.py (Diff revision 18)
The issue has been resolved. Show all issues
```
I don't think we need to say "... that is found."
Same below.
```
reviewboard/webapi/resources/file_provider_node.py (Diff revision 18)
The issue has been resolved. Show all issues
```
Maybe file_node? We usually use rsp as "response", as in a JSON blob.
```

reviewboard/webapi/resources/file_provider_node.py (Diff revision 18)

The issue has been resolved. Show all issues

Do we want path to be optional? Or required?

VTL-Developer April 2, 2015, 9:49 a.m.

I feel path should be optional, as the default would point to the root. Its like when you open DropBox or C: or other file systems, you'll normally start at the root, and navigate around from there.

VTL-Developer April 2, 2015, 6:39 p.m.

To avoid any confusion later on. The API assumes a path of / if none is provided for the input. This path would be used with the fileproviders module, which requires a path for its functions. This would be / (provided by the API by default) or the path submitted by the user or caller gives.

reviewboard/webapi/resources/file_provider_node.py (Diff revision 18)

The issue has been resolved. Show all issues

The wording here needs some work:
"The path in the provider representing a directory or file to return information on, or a search string (if ``search`` is true)."

reviewboard/webapi/resources/file_provider_node.py (Diff revision 18)
The issue has been resolved. Show all issues
```
The description and type are inconsistent. The type should be a bool.
```
reviewboard/webapi/resources/file_provider_node.py (Diff revision 18)
The issue has been resolved. Show all issues
```
Which filename?
```

reviewboard/webapi/resources/file_provider_node.py (Diff revision 18)

The issue has been resolved. Show all issues

Tuples aren't a good way to structure this. They're too limiting long-term, and harder to consume. Entries should be dictionaries instead, and should be structured like item resources.

reviewboard/webapi/resources/file_provider_node.py (Diff revision 18)
The issue has been resolved. Show all issues
```
".. or are related ..."
```

reviewboard/webapi/resources/file_provider_node.py (Diff revision 18)

The issue has been resolved. Show all issues

I don't know that we want a new error code for this. It means clients have to special-case the error. I think this should be an INVALID_FORM_DATA error that includes reasonable error message for the search field instead.

reviewboard/webapi/resources/file_provider_node.py (Diff revision 18)
The issue has been resolved. Show all issues
```
"at the path."
```
reviewboard/webapi/resources/file_provider_node.py (Diff revision 18)
The issue has been resolved. Show all issues
```
No blank line here.
```

reviewboard/webapi/resources/file_provider_node.py (Diff revision 18)

The issue has been resolved. Show all issues

This is a pretty generic excepetion for throwing and catching here. If anything else were to throw this (list_folder, for instance), then the caller will get an unexpected error (one referencing "search" for instance).

reviewboard/webapi/resources/file_provider_node.py (Diff revision 18)
The issue has been resolved. Show all issues
```
No blank line here.
```
reviewboard/webapi/resources/file_provider_node.py (Diff revision 18)
The issue has been resolved. Show all issues
```
No blank line here.
```

Change Summary:

Updated all files which made use of path_sep for FileProvider objects to not use them, but / instead.

Cleaned up a lot of the documentation to be more up to date, correct and accurate.

The test classes for FileProvider objects now have an improved initialization that uses cached data, speeding up test cases.

Removed removed_credentials from api/file-provider-accounts/ PUT request, as that is no longer supported.

Removed FILE_PROVIDER_DOES_NOT_SUPPORT_SEARCH from reviewboard/webapi/errors.py file.

Updated the test cases appropriately to match the changes here and in r/6806

Lots of other code clean-up with ordering and styling.

Commit:

0121c613fbf432c071f46e7ae51c4c0faa341e95

c9329bcb849844cde0aac86ef57c2ddc988c69bf

Diff:

Revision 19 (+1741 -11)

Show changes

	reviewboard/settings.py
	reviewboard/testing/fileprovider.py
	reviewboard/testing/testcase.py
	reviewboard/webapi/errors.py
	reviewboard/webapi/resources/__init__.py
	reviewboard/webapi/resources/base_file_attachment.py
	reviewboard/webapi/resources/file_provider_account.py
	reviewboard/webapi/resources/file_provider_node.py
	6 more

Tool: Pyflakes
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/resources/base_file_attachment.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/settings.py
    reviewboard/webapi/resources/file_provider_node.py
    reviewboard/webapi/errors.py
    reviewboard/testing/fileprovider.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/test_file_attachment.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/root.py
    reviewboard/webapi/resources/file_provider_account.py
    reviewboard/webapi/tests/test_file_provider_account.py
    reviewboard/webapi/tests/test_file_provider_node.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/testing/testcase.py
    reviewboard/webapi/resources/base_file_attachment.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/settings.py
    reviewboard/webapi/resources/file_provider_node.py
    reviewboard/webapi/errors.py
    reviewboard/testing/fileprovider.py
    reviewboard/webapi/tests/urls.py
    reviewboard/webapi/tests/test_file_attachment.py
    reviewboard/webapi/tests/mimetypes.py
    reviewboard/webapi/resources/root.py
    reviewboard/webapi/resources/file_provider_account.py
    reviewboard/webapi/tests/test_file_provider_account.py
    reviewboard/webapi/tests/test_file_provider_node.py

reviewboard/settings.py (Diff revision 19)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 19)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```
reviewboard/settings.py (Diff revision 19)
The issue has been dropped. Show all issues
```
 'PIPELINE_CSS' imported but unused
```
reviewboard/settings.py (Diff revision 19)
The issue has been dropped. Show all issues
```
 'PIPELINE_JS' imported but unused
```

Change Summary:

Changed the search fuction for the testing fileproviders to require path as input.

Also, changed the default for get_list path parameter to be /

Commit:

c9329bcb849844cde0aac86ef57c2ddc988c69bf

2ba622f0c12cded48d2d34595773ce07c954ee39

Diff:

Revision 20 (+1741 -11)

Show changes

	reviewboard/settings.py
	reviewboard/testing/fileprovider.py
	reviewboard/testing/testcase.py
	reviewboard/webapi/errors.py
	reviewboard/webapi/resources/__init__.py
	reviewboard/webapi/resources/base_file_attachment.py
	reviewboard/webapi/resources/file_provider_account.py
	reviewboard/webapi/resources/file_provider_node.py
	6 more

Fix it!

reviewboard/testing/fileprovider.py (Diff revision 20)
An issue was opened. Show all issues
```
Should start with a capital letter and end in a period.
```
reviewboard/testing/fileprovider.py (Diff revision 20)
An issue was opened. Show all issues
```
Should start with a capital letter and end in a period.
```

reviewboard/webapi/resources/base_file_attachment.py (Diff revision 20)

Note to self: depending on where this lands, these may need to change.

reviewboard/webapi/resources/base_file_attachment.py (Diff revision 20)
An issue was opened. Show all issues
```
Can we call this variable field_errors?
```

reviewboard/webapi/resources/base_file_attachment.py (Diff revision 20)

An issue was opened. Show all issues

Wrap the entire string in parens and then you don't need the + \\ (two strings next to each other get automatically concatenated).

reviewboard/webapi/resources/file_provider_account.py (Diff revision 20)
An issue was opened. Show all issues
```
Should be in the imperative mood ("Create")
```
reviewboard/webapi/resources/file_provider_account.py (Diff revision 20)
An issue was opened. Show all issues
```
This should have a docstring.
```
reviewboard/webapi/resources/file_provider_account.py (Diff revision 20)
An issue was opened. Show all issues
```
Should be in the imperative mood ("Update")
```
reviewboard/webapi/resources/file_provider_account.py (Diff revision 20)
An issue was opened. Show all issues
```
Should be in the imperative mood ("Delete")
```
reviewboard/webapi/resources/file_provider_account.py (Diff revision 20)
An issue was opened. Show all issues
```
Should be in the imperative mood.
```
reviewboard/webapi/resources/file_provider_account.py (Diff revision 20)
An issue was opened. Show all issues
```
Should be in the imperative mood.
```
reviewboard/webapi/resources/file_provider_node.py (Diff revision 20)
An issue was opened. Show all issues
```
Should be in the imperative mood.
```
reviewboard/webapi/resources/file_provider_node.py (Diff revision 20)
An issue was opened. Show all issues
```
INVALID_FORM_DATA doesn't seem like the right thing here.
```
reviewboard/webapi/resources/file_provider_node.py (Diff revision 20)
An issue was opened. Show all issues
```
This should have a docstring.
```
reviewboard/webapi/resources/file_provider_node.py (Diff revision 20)
An issue was opened. Show all issues
```
Docstring.
```
reviewboard/webapi/tests/mimetypes.py (Diff revision 20)
An issue was opened. Show all issues
```
Two blank lines here.
```