• 
      

    Add a new 'summary entry' element, make things pretty.

    Review Request #6940 — Created Feb. 12, 2015 and submitted

    Information

    student-sonar
    master
    292e774...

    Reviewers

    This change cleans up the sections on the student view with a new element that
    wraps a section. In addition to this, I've redone a lot of the styles to make
    things pretty.

    Loaded all the different students and saw that things worked as expected.


    Description From Last Updated

    If you really want to use the new hotness, you can use the spread operator here. let attributes = [...this.attributes];

    mike_conleymike_conley
    reviewbot
    1. Tool: PEP8 Style Checker
      Ignored Files:
          lib/frontend/components.js
          lib/frontend/x-student-view-summary-entry.js
          index.html
          lib/frontend/x-student-view.js
      
      
      
      Tool: Pyflakes
      Ignored Files:
          lib/frontend/components.js
          lib/frontend/x-student-view-summary-entry.js
          index.html
          lib/frontend/x-student-view.js
      
      
    2. 
        
    mike_conley
    1. 
        
    2. Show all issues

      If you really want to use the new hotness, you can use the spread operator here.

      let attributes = [...this.attributes];

      1. Unfortunately, spread won't work here because attributes isn't a real iterable.

    3. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (9ad24c3)