Fix more Unicode issues on Windows.

Review Request #6898 — Created Feb. 3, 2015 and submitted

Information

RBTools
release-0.7.x
ec8f24f...

Reviewers

There were a couple remaining calls to getpass() still using Unicode
strings, and plenty of Unicode entries in environment variables. These
broke on Windows, since the implementation there expects byte strings.

This changes the last getpass() calls and normalizes all environment
variables on Windows prior to calling subprocess.Popen().

Installed a build on Windows. I triggered the authentication paths to
ensure getpass() was called in each case. I also triggered several
execute() paths, all of which worked without blowing up.

reviewbot
  1. Tool: Pyflakes
    Processed Files:
        rbtools/utils/process.py
        rbtools/commands/__init__.py
        rbtools/utils/users.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        rbtools/utils/process.py
        rbtools/commands/__init__.py
        rbtools/utils/users.py
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-0.7.x (414a694)