Summary

[WIP] Responsive UI for My Account Page

Review Request #6893 — Created Feb. 2, 2015 and discarded May 20, 2015, 7:11 p.m.

Information

Owner

jtsengyc

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Currently RB was designed and made for desktop screen resolutions, thus when users access the website on mobile phones with limited screen estates, elements on the sites are often crunched or overlapped on each other, making quick mobile review/checking new contents impossible. With mostly changes to css files only, this change allows elements to resize properly and re-adjust its position to allow easy viewing of the contents, without significant modifications on the actual elements itself.

This change focuses on screen resolution between 360px up to 720px. (720px+ renders fine without additional changes).

Testing Done

Pages are checked on firefox and chrome with windows resized to between 360px and 720px, and boundary cases 720/721px to check the readability of elements/pages.

Files

Tool: Pyflakes
Ignored Files:
    reviewboard/templates/reviews/review_detail.html
    reviewboard/static/rb/js/common.js
    reviewboard/static/rb/js/newReviewRequest/views/newReviewRequestView.js
    reviewboard/templates/base/navbar.html
    reviewboard/templates/base.html
    reviewboard/static/rb/css/pages/diffviewer.less
    reviewboard/templates/base/_nav_support_menu.html
    reviewboard/static/rb/js/views/uploadAttachmentView.js
    reviewboard/static/rb/css/pages/newReviewRequest.less
    reviewboard/templates/datagrids/datagrid.html
    reviewboard/templates/base/branding.html
    reviewboard/templates/diffviewer/view_diff.html
    reviewboard/static/rb/css/pages/base.less
    reviewboard/static/rb/css/common.less
    reviewboard/static/rb/css/pages/my-account.less
    reviewboard/templates/base/headerbar.html
    reviewboard/static/rb/css/pages/reviews.less
    reviewboard/static/rb/css/defs.less
    reviewboard/static/rb/js/views/commentDialogView.js
    reviewboard/static/rb/css/pages/dashboard.less



Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/templates/reviews/review_detail.html
    reviewboard/static/rb/js/common.js
    reviewboard/static/rb/js/newReviewRequest/views/newReviewRequestView.js
    reviewboard/templates/base/navbar.html
    reviewboard/templates/base.html
    reviewboard/static/rb/css/pages/diffviewer.less
    reviewboard/templates/base/_nav_support_menu.html
    reviewboard/static/rb/js/views/uploadAttachmentView.js
    reviewboard/static/rb/css/pages/newReviewRequest.less
    reviewboard/templates/datagrids/datagrid.html
    reviewboard/templates/base/branding.html
    reviewboard/templates/diffviewer/view_diff.html
    reviewboard/static/rb/css/pages/base.less
    reviewboard/static/rb/css/common.less
    reviewboard/static/rb/css/pages/my-account.less
    reviewboard/templates/base/headerbar.html
    reviewboard/static/rb/css/pages/reviews.less
    reviewboard/static/rb/css/defs.less
    reviewboard/static/rb/js/views/commentDialogView.js
    reviewboard/static/rb/css/pages/dashboard.less

Added Files:

Added Files:

Added Files:

This is going to very quickly become impossible to review. Can you split things up into smaller, does-one-thing changes?

jtsengyc Feb. 2, 2015, 7:02 p.m.

should I remove this review and then repost one review for each rb page?

david Feb. 4, 2015, 2:48 p.m.

Yeah, that's probably the best way. You already have one open for the navigation bar.

jtsengyc Feb. 4, 2015, 3:07 p.m.

Got it. also wondering if there's a good way to link up individual review requests since they are in a sense relating to one another. I've notice there's a "depend on" option, but not quite sure if thats the best way

david Feb. 5, 2015, 11:56 a.m.

"Depends on" is good for indicating in what order things have to go in (when there are such dependencies). Other than that, there's not a lot of additional linking necessary. You could maybe make sure that every summary starts with "Responsive UI: " or somesuch.

Summary:

[WIP] Responsive UI for all rb pages

[WIP] Responsive UI for My Account Page

Diff:

Revision 2 (+54 -1)

Show changes

	reviewboard/static/rb/css/pages/dashboard.less
	reviewboard/static/rb/css/pages/my-account.less

Removed Files:

Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/css/pages/my-account.less
    reviewboard/static/rb/css/pages/dashboard.less



Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/css/pages/my-account.less
    reviewboard/static/rb/css/pages/dashboard.less

Status:: Discarded