Clicking username in nav bar now links to user profile instead of user preferences.

 






 

 


  Review Request #6865
  —
  Created Jan. 31, 2015 and submitted 

 


















 

  

   Information

  





 
 

  jessq
 









 
 

  Review Board
 









 
 

  master
 









 
 

  
 









 
 

  
 









 
 

  f9134ce...
 






 




 

  

   Reviewers

  





 
 

  reviewboard, students
 









 
 

  
 






 








 





  


 
 

  
When you click on your avatar and/or username in the navigation bar, it takes you to the user preferences page. There is already a link to the Preferences page in the user drop down menu, but there isn't a link to your own user page anywhere. Your avatar and username in the navigation bar is now changed to link to your own profile page.

 








  


 
 

  
Clicked my avatar/username from a variety of different places on the site. They all successfully linked to my own profile page.

 







 









 





  








 






 
 
 

  

   

    

     
    

    
    
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
     
  • 
      
     
    • 
    

   

   

    
     

      Description
      From
      Last Updated
     

    
    



     

      
       
       
I think {% url 'user' %} will work. The URL name for that page is, kinda unintuitively, under datagrids/urls.py: url(r"^users/(?P<username>[A-Za-z0-9@_\-\.'\+]+)/$", …

      		
      
       mike_conleymike_conley
      
      
       
      
     


    
   

  

 







 






  

 








 














 





 

  

   




reviewbot




   

   





  

 



 

  


   

   

    
 
reviewbot



    
   


  

  

  



    




  1. 
 
    
  
    
   
    Tool: Pyflakes
Ignored Files:
    reviewboard/templates/base/headerbar.html



Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/templates/base/headerbar.html


    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




mike_conley




   

   







  

 



 

  


   

   

    
 
mike_conley



    
   


  

  

  



    




  1. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 

















  2. 
 
    
  
  
    
  
 
    
  
    
   
    
    
     
    
      
       reviewboard/templates/base/headerbar.html
       


        (Diff revision 1)


       
      
     
    
        
    
     
     
    

     
     
    

        
   
    
  
    
 
    

   
    
    
    




    
 
    
  
  
  

  
  
   Show all issues
  
 
    

    



    
    I think {% url 'user' %} will work.
    

    The URL name for that page is, kinda unintuitively, under datagrids/urls.py:
    

    

        url(r"^users/(?P<username>[A-Za-z0-9@_\-\.'\+]+)/$",
        'submitter', name='user'),

    

    

    That name parameter is what we can pass to the url templatetag, so I'm pretty sure just replacing user-preferences with user will work.
    
  
    
 
    

 
    
  


    
 
    
 
      

  


    1. 
 
 
      
 
      
  
 
      
 
      
  
      I had already tried that, but it did not work. It says "Reverse for 'user' with arguments '()' and keyword arguments '{}' not found."
      
 
      

      2. 



    2. 
 
 
      
 
      
  
 
      
 
      
  
      Ah, you might need to pass in the username as well, since the regex is expecting to inject that:
      

      Try:
      

      {% url 'user' request.user.username %}
      

      Does that work?
      
 
      

      3. 


 
    


    

 
    

    3. 




  3. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    4. 




  

 
















 



 

  

   





 JE





   

   

  

 



 















 





 

  

   




reviewbot




   

   





  

 



 

  


   

   

    
 
reviewbot



    
   


  

  

  



    




  1. 
 
    
  
    
   
    Tool: Pyflakes
Ignored Files:
    reviewboard/templates/base/headerbar.html



Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/templates/base/headerbar.html


    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




mike_conley




   

   







  

 



 

  


   

   

    
 
mike_conley



    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 





 

  

   




brennie




   

   







  

 



 

  


   

   

    
 
brennie



    
   


  

  

  



    




  1. 
 
    
  
    
   
    Ship It!
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    2. 















  2. 
 
    
  
    
   
    
  
    
 
    

 
    
  


    
 
    
 
      

  

 
    


    

 
    

    3. 




  

 
















 



 

  

   





 JE





   

   

  

 



 

  


   

   

    
 Review request changed

    
   


  

  

  







  

   

    Status:
   

   


    Completed

   

  




  

   

    Change Summary:
   

   

    
Pushed to maste (365cff0)