3505: Empty drafts can be submitted

anh****@cisc***** (Google Code) (Is this you? Claim this profile.)
Feb. 27, 2015
What version are you running?
e625b89

What's the URL of the page containing the problem?
/r/N/ for any review request N with an unpublished draft

What steps will reproduce the problem?
1. Create a new review request and don't fill out any fields
2. Choose Close->Submitted from the menu on the top right

What is the expected output? What do you see instead?
When attempting to publish a draft with missing fields, error dialogs prevent it. However, this can be circumvented by submitting the review request (and reopening it, if desired).

What operating system are you using? What browser?
N/A

Please provide any additional information below.
I came across this while trying to figure out how to validate extra fields for an extension, but I can't see how any fields are validated aside from a few JavaScript barriers.
chipx86
#1 chipx86
This happens because the submitted state is just a flag, and doesn't deal with drafts (and therefore field validation). We don't require anything for a submitted review request.

That doesn't mean it's ideal, but fortunately, it's not a regression, from what I can tell.
  • +Confirmed
  • -Priority-Medium
    +Priority-Low
    +Component-Reviews
#2 anh****@cisc***** (Google Code) (Is this you? Claim this profile.)
I agree that it's not a regression. Could we make it a feature request? I'd like to be able to specify validation steps to move between states.
david
#3 david
  • -Type-Defect
    +Type-Enhancement
david
#4 david
  • +EasyFix
#5 Akiy*****@gmai***** (Google Code) (Is this you? Claim this profile.)
Can I work on this one?
I think I can try on it .

Chenxi
david
#6 david
Fixed in release-2.0.x (e192efe). Thanks!
  • -Confirmed
    +Fixed