Fix un-escaped form fields for file and diff upload
Review Request #6853 — Created Jan. 31, 2015 and submitted
Adding files to review requests didn't work for Italian (on Review Board version 2.0.8) because of an unescaped apostrophe. This fix makes sure form fields for file and diff upload are escaped.
Manual testing: set browser (Firefox 33) language to Italian, attached a file to a review request.
-
Your code looks good, but I'd like you to rewrite your summary and description. We use these for the commit message, which is a crucial way for people who are looking through the project history to figure out how things changed.
The summary should be a concise explanation of the bug rather than just a reference to the bug number (for example, "Fix un-escaped form fields for file and diff upload").
The description should be a paragraph or more that explains what the bug was and how this change fixes it.
Neither of these needs to mention the bug number, since that's present in the "Bugs" field.
Ideally, someone reading through the commit messages should be able to understand what this change does without having to open up the bug tracker or any other reference.
TE
- Summary:
-
fix for bug 3678Fix un-escaped form fields for file and diff upload
- Description:
-
~ fix for bug 3678 (unable to attach files in Italian on 2.0.8)
~ Adding files to review requests didn't work for Italian (on Review Board version 2.0.8) because of an unescaped apostrophe. This fix makes sure form fields for file and diff upload are escaped.
Tool: Pyflakes Processed Files: djblets/util/templatetags/djblets_js.py Tool: PEP8 Style Checker Processed Files: djblets/util/templatetags/djblets_js.py