• 
      

    Fix the image review UI comment serialization.

    Review Request #6852 — Created Jan. 31, 2015 and submitted

    Information

    Review Board
    master
    cba733b...

    Reviewers

    The generator comment serialization didn't work for the dummy review UI, so I
    changed it to try to convert to a list. Unfortunately this broke the image
    review UI, which serializes comments to a dictionary form.

    I've changed it so that the basic review UI returns a list rather than an
    iterator, and removed the explicit cast.

    • Successfully opened up the image review UI with a comment present.
    • Ran unit tests.
    reviewbot
    1. Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/reviews/ui/base.py
          reviewboard/reviews/ui/tests.py
      
      
      
      Tool: Pyflakes
      Processed Files:
          reviewboard/reviews/ui/base.py
          reviewboard/reviews/ui/tests.py
      
      
    2. 
        
    chipx86
    1. Ship It!
    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (51c20e1)