3737: Code refactoring for def.less on review-request-action color

jtse****@gmai***** (Google Code) (Is this you? Claim this profile.)
Jan. 23, 2015
What version are you running?
2.0.13 alpha

What's the URL of the page this enhancement relates to, if any?
all

Describe the enhancement and the motivation for it.
Several duplicated references of same css definition that makes the code confusing and without obvious code clarifying benefit

What operating system are you using? What browser?
Mac OSX - Chrome, Firefox

Please provide any additional information below.

Code in reference - def.less

@review-request-actions-bg: @review-request-action-primary-bg;
@review-request-actions-border-color: darken(@review-request-action-primary-bg, 40%);

@review-request-action-bg: #E5D7A8;
@review-request-action-border-color: @review-request-actions-border-color;
@review-request-action-active-bg: darken(@review-request-action-bg, 20%);
@review-request-action-hover-bg: darken(@review-request-action-bg, 12%);

@review-request-action-primary-bg: @review-request-action-bg;
@review-request-action-primary-active-bg: @review-request-action-active-bg;
@review-request-action-primary-hover-bg: @review-request-action-hover-bg;

@review-request-action-menu-border-color: @review-request-actions-border-color;
@review-request-action-menu-bg: @review-request-action-active-bg;
@review-request-action-menu-item-hover-bg: @review-request-action-hover-bg;
david
#1 david
  • -Type-Enhancement
    +Type-Task
    +EasyFix
    +Component-WebUI
#2 just****@gmai***** (Google Code) (Is this you? Claim this profile.)
I'll look at this.
david
#3 david
Fixed in master (d098dca). Thanks!
  • +Fixed