Fix the misleading string in pop up "RBTool Setup" message in repository admin
Review Request #6788 — Created Jan. 16, 2015 and submitted
In the repository list in the Review Board admin site, we have an "RBTools Setup" link that pops up instructions for what to put in a .reviewboardrc file. One instruction was misleading (telling the user to work on root directory) in cases like SVN where the user won't be checking out the "repository root", but rather a subdirectory
The misleading string is produced by reviewboard/templates/admin/scmtools/repository/rbtools_setup.html I just changed some static string in the html file.
This change fixes the text to suggest users commit this file to the root of their working copy.
Show better string on Chrome after modification
| Description | From | Last Updated |
|---|---|---|
|
Please wrap this to 80 columns. |
 david
|
- Branch:
-
chester_branchmaster
- Commit:
-
56b41988ad1fd3769dfb7a303911a3d0d5753d5db508f6ff1cca7137826d64fd9bca335788c4833f
-
Tool: PEP8 Style Checker Ignored Files: reviewboard/templates/admin/scmtools/repository/rbtools_setup.html Tool: Pyflakes Ignored Files: reviewboard/templates/admin/scmtools/repository/rbtools_setup.html
-
Your review request description needs work. It should explain what the bug is and how your change fixes it.
- People:
-
Tool: Pyflakes Ignored Files: reviewboard/templates/admin/scmtools/repository/rbtools_setup.html Tool: PEP8 Style Checker Ignored Files: reviewboard/templates/admin/scmtools/repository/rbtools_setup.html
-
Your summary/description is improved, but still not very useful. For example, looking through git history, I would wonder "what string?" and "what pop up message"? You should also endeavor to use correct capitalization and punctuation.
Here's an example of what we might expect for this bug fix:
Fix misleading "RBTools Setup" instructions in the repository admin. In the repository list in the Review Board admin site, we have an "RBTools Setup" link that pops up instructions for what to put in a .reviewboardrc file. These instructions were misleading in cases like SVN where the user won't be checking out the "repository root", but rather a subdirectory. This change fixes the text to suggest users commit this file to the root of their working copy.
- Summary:
-
modify misleading string in the pop up messageFix the misleading string in pop up "RBTool Setup" message in repository admin
- Description:
-
~ modify misleading string in the pop up message. This string is produced by reviewboard/templates/admin/scmtools/repository/rbtools_setup.html I just changed some static string the html file.
~ modify misleading string in the pop up message. This string is produced by reviewboard/templates/admin/scmtools/repository/rbtools_setup.html I just changed some static string the html file.
+ In the repository list in the Review Board admin site, we have an "RBTools + Setup" link that pops up instructions for what to put in a .reviewboardrc file. + One instruction was misleading (telling the user to work on root directory) in cases like SVN where the user won't be + checking out the "repository root", but rather a subdirectory
- Description:
-
~ modify misleading string in the pop up message. This string is produced by reviewboard/templates/admin/scmtools/repository/rbtools_setup.html I just changed some static string the html file.
~ In the repository list in the Review Board admin site, we have an "RBTools ~ Setup" link that pops up instructions for what to put in a .reviewboardrc file. ~ One instruction was misleading (telling the user to work on root directory) in cases like SVN where the user won't be ~ checking out the "repository root", but rather a subdirectory ~ In the repository list in the Review Board admin site, we have an "RBTools Setup" link that pops up instructions for what to put in a .reviewboardrc file. One instruction was misleading (telling the user to work on root directory) in cases like SVN where the user won't be checking out the "repository root", but rather a subdirectory
~ ~ The misleading string is produced by reviewboard/templates/admin/scmtools/repository/rbtools_setup.html I just changed some static string in the html file.
~ ~ This change fixes the text to suggest users commit this file to the root of their working copy.
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py Ignored Files: reviewboard/templates/admin/scmtools/repository/rbtools_setup.html Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py Ignored Files: reviewboard/templates/admin/scmtools/repository/rbtools_setup.html