3363: file diffstat box: link to href anchor to file in diff not fully shown in browser (FF) address bar

matthias********@fams***** (Google Code) (Is this you? Claim this profile.)
Jan. 17, 2015 
What version are you running?
RB 2.0

What's the URL of the page containing the problem?
https://reviews.reviewboard.org/r/5846/diff/#

What steps will reproduce the problem?
When I hover on a link to a specific file in the diffstat box, for example "reviewboard/diffviewer/tests.py", the url preview properly shows "https://reviews.reviewboard.org/r/5846/diff/#2", however when I click, the firefox (29.0.1, linux) URL bar said "https://reviews.reviewboard.org/r/5846/diff/#".
When I want to paste someone a link leading to a specific section inside the diff, it wouldn't work without me manually fixing the link address.

Additionally, the linked file is not shown on top of the page, but a bit below. IMO the file should be scrolled to the very top (see screenshot, (its not the same RR as linked in the ticket here)).
david
#1 david
  • +Component-DiffViewer
    +EasyFix
#2 jtse****@gmai***** (Google Code) (Is this you? Claim this profile.) 
working on this
david
#3 david 
Fixed in release-2.0.x (71731cb). Thanks!
  • +Fixed
chipx86
#4 chipx86 
Turns out that the gap was necessary for the case where there's a review banner. Now, the code gets covered up.
chipx86
#5 chipx86 
Fixed this up to take into consideration the banner height.