Summary

Initial backend support for review requests with commit history.

Review Request #6779 — Created Jan. 15, 2015 and discarded Jan. 20, 2015, 1:27 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

master

Bugs

Depends On

~~6766~~

Reviewers

Groups

reviewboard

People

chipx86, smacleod

Description

Add the DiffCommitResource and DraftDiffCommitResource resources.
The DiffCommitResource is a resource for retrieving the information
about the Commits under a particular DiffSet. The
DraftDiffCommitResource inherits from the DiffCommitResource and
modifies it to allow for the creation of Commits and associated
FileDiffs. The DraftDiffCommitResource handles the uploading of
FileDiffs for Commits instead of the DiffSetResource.

Register the Commit model for both DiffCommitResource and
DraftDiffCommitResource in the API. They are item child resources of
the DiffSetResource and DraftDiffSetResource resources,
respectively.

The DiffSetResource.create method now takes an extra optional field,
create_empty, that determines if the DiffSet that is created is
created without uploading a .diff file. This is used in the creation
of review requests with commit histories.

The FileDiffResource and DraftFileDiffResource classes now filter
their results based on the commit query parameter. If no commit
query parameter is given, only those FileDiffs unattached to a
Commit will be return. This filtering is only applied to the list
API, not the item API.

Add a new form, the UploadCommitForm, for handling the processing of
data for creating new Commit instances. It is very similar to
diffviewer.forms.UploadDiffForm and may need to be refactored.

Refactor behaviour for uploading FileDiffs from the DiffSetManager
to a new class, the DiffProcessorMixin. This mix-in handles the
initial processing of .diff files, their comparison (for header vs
source files), generating file lists, and creating actual FileDiffs
from upload (it calls the child class's implementation of
create_from_data).

The DiffSetManager now has a create_empty method for creating
DiffSets without FileDiffs for usage with Commits.

Add the CommitManager model. It inherits from the
DiffProcessorMixin.

Update the validate_diff endpoint to use named parameters for
DiffSetManager.create_from_upload because of the refactoring.

Add a WebAPI capability to show that the server supports review
requests with commit histories.

TODO:
- Unit tests forthcoming.
- Manual testing information forthcoming.

Testing Done

Ran unit tests.
Able to create a review request with a single commit of history via
RBTools (see: https://reviews.reviewboard.org/r/6787/).

Issues

Description	From	Last Updated
Col: 1 W293 blank line contains whitespace	reviewbot	Jan. 15, 2015, 9:55 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Jan. 15, 2015, 9:55 p.m.
Col: 1 W293 blank line contains whitespace	reviewbot	Jan. 15, 2015, 9:55 p.m.
Col: 1 W293 blank line contains whitespace	reviewbot	Jan. 15, 2015, 9:55 p.m.
Col: 80 E501 line too long (82 > 79 characters)	reviewbot	Jan. 15, 2015, 9:56 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Jan. 15, 2015, 9:57 p.m.
Col: 25 E131 continuation line unaligned for hanging indent	reviewbot	Jan. 15, 2015, 9:57 p.m.
Col: 29 E131 continuation line unaligned for hanging indent	reviewbot	Jan. 15, 2015, 9:58 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Jan. 15, 2015, 9:58 p.m.
Col: 1 E303 too many blank lines (3)	reviewbot	Jan. 15, 2015, 10:08 p.m.
Col: 1 W293 blank line contains whitespace	reviewbot	Jan. 16, 2015, 12:13 p.m.
'datetime' imported but unused	reviewbot	Jan. 16, 2015, 12:13 p.m.
'urlencode' imported but unused	reviewbot	Jan. 16, 2015, 12:13 p.m.
'get_resource_for_object' imported but unused	reviewbot	Jan. 16, 2015, 12:13 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/draft_diff.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/webapi/resources/draft_diff_commit.py
    reviewboard/webapi/resources/filediff.py
    reviewboard/webapi/resources/validate_diff.py
    reviewboard/webapi/resources/diff.py
    reviewboard/webapi/resources/diff_commit.py
    reviewboard/diffviewer/forms.py
    reviewboard/diffviewer/managers.py
    reviewboard/webapi/resources/draft_filediff.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/draft_diff.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/webapi/resources/draft_diff_commit.py
    reviewboard/webapi/resources/filediff.py
    reviewboard/webapi/resources/validate_diff.py
    reviewboard/webapi/resources/diff.py
    reviewboard/webapi/resources/diff_commit.py
    reviewboard/diffviewer/forms.py
    reviewboard/diffviewer/managers.py
    reviewboard/webapi/resources/draft_filediff.py

reviewboard/diffviewer/forms.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
reviewboard/diffviewer/forms.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
reviewboard/diffviewer/managers.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
reviewboard/diffviewer/managers.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
reviewboard/diffviewer/managers.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (82 > 79 characters)
```
reviewboard/diffviewer/managers.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
reviewboard/webapi/resources/__init__.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 25
 E131 continuation line unaligned for hanging indent
```
reviewboard/webapi/resources/diff_commit.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 29
 E131 continuation line unaligned for hanging indent
```
reviewboard/webapi/resources/diff_commit.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
reviewboard/webapi/resources/draft_diff_commit.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 E303 too many blank lines (3)
```

Change Summary:

Fix ReviewBot's issues. Add in the manager for the DiffCommit model.

Diff:

Revision 2 (+830 -151)

Show changes

	reviewboard/diffviewer/forms.py
	reviewboard/diffviewer/managers.py
	reviewboard/diffviewer/models.py
	reviewboard/webapi/resources/__init__.py
	reviewboard/webapi/resources/diff.py
	reviewboard/webapi/resources/diff_commit.py
	reviewboard/webapi/resources/draft_diff.py
	reviewboard/webapi/resources/draft_diff_commit.py
	3 more

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/draft_diff.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/webapi/resources/draft_diff_commit.py
    reviewboard/diffviewer/models.py
    reviewboard/webapi/resources/filediff.py
    reviewboard/webapi/resources/diff.py
    reviewboard/webapi/resources/diff_commit.py
    reviewboard/diffviewer/forms.py
    reviewboard/diffviewer/managers.py
    reviewboard/webapi/resources/validate_diff.py
    reviewboard/webapi/resources/draft_filediff.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/draft_diff.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/webapi/resources/draft_diff_commit.py
    reviewboard/diffviewer/models.py
    reviewboard/webapi/resources/filediff.py
    reviewboard/webapi/resources/diff.py
    reviewboard/webapi/resources/diff_commit.py
    reviewboard/diffviewer/forms.py
    reviewboard/diffviewer/managers.py
    reviewboard/webapi/resources/validate_diff.py
    reviewboard/webapi/resources/draft_filediff.py

Change Summary:

Update it so its not so broken.

Testing Done:

~		Ran unit tests.
	~	Ran unit tests.
	+	Able to create a review request with a single commit of history via `RBTools` (patch forthcoming).

Depends On:

~~6766 - Add the DiffCommit model.~~

Diff:

Revision 3 (+853 -151)

Show changes

	reviewboard/diffviewer/forms.py
	reviewboard/diffviewer/managers.py
	reviewboard/diffviewer/models.py
	reviewboard/webapi/resources/__init__.py
	reviewboard/webapi/resources/diff.py
	reviewboard/webapi/resources/diff_commit.py
	reviewboard/webapi/resources/draft_diff.py
	reviewboard/webapi/resources/draft_diff_commit.py
	3 more

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/draft_diff.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/webapi/resources/draft_diff_commit.py
    reviewboard/diffviewer/models.py
    reviewboard/webapi/resources/filediff.py
    reviewboard/webapi/resources/diff.py
    reviewboard/webapi/resources/diff_commit.py
    reviewboard/diffviewer/forms.py
    reviewboard/diffviewer/managers.py
    reviewboard/webapi/resources/validate_diff.py
    reviewboard/webapi/resources/draft_filediff.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/draft_diff.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/webapi/resources/draft_diff_commit.py
    reviewboard/diffviewer/models.py
    reviewboard/webapi/resources/filediff.py
    reviewboard/webapi/resources/diff.py
    reviewboard/webapi/resources/diff_commit.py
    reviewboard/diffviewer/forms.py
    reviewboard/diffviewer/managers.py
    reviewboard/webapi/resources/validate_diff.py
    reviewboard/webapi/resources/draft_filediff.py

reviewboard/diffviewer/forms.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
reviewboard/webapi/resources/diff_commit.py (Diff revision 3)
The issue has been resolved. Show all issues
```
 'datetime' imported but unused
```
reviewboard/webapi/resources/diff_commit.py (Diff revision 3)
The issue has been resolved. Show all issues
```
 'urlencode' imported but unused
```
reviewboard/webapi/resources/diff_commit.py (Diff revision 3)
The issue has been resolved. Show all issues
```
 'get_resource_for_object' imported but unused
```

Change Summary:

Fix ReviewBot's issues.

Commit:

4b46239a9e25c4704dac22c1ce97bc9517d94724

Diff:

Revision 4 (+996 -154)

Show changes

	reviewboard/diffviewer/admin.py
	reviewboard/diffviewer/forms.py
	reviewboard/diffviewer/managers.py
	reviewboard/diffviewer/models.py
	reviewboard/diffviewer/evolutions/__init__.py
	reviewboard/diffviewer/evolutions/add_commit_history_fields.py
	reviewboard/webapi/resources/__init__.py
	reviewboard/webapi/resources/diff.py
	6 more

Tool: Pyflakes
Processed Files:
    reviewboard/diffviewer/admin.py
    reviewboard/webapi/resources/draft_diff.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/webapi/resources/draft_diff_commit.py
    reviewboard/diffviewer/models.py
    reviewboard/webapi/resources/filediff.py
    reviewboard/diffviewer/evolutions/__init__.py
    reviewboard/webapi/resources/diff.py
    reviewboard/webapi/resources/diff_commit.py
    reviewboard/diffviewer/forms.py
    reviewboard/diffviewer/evolutions/add_commit_history_fields.py
    reviewboard/diffviewer/managers.py
    reviewboard/webapi/resources/validate_diff.py
    reviewboard/webapi/resources/draft_filediff.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/diffviewer/admin.py
    reviewboard/webapi/resources/draft_diff.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/webapi/resources/draft_diff_commit.py
    reviewboard/diffviewer/models.py
    reviewboard/webapi/resources/filediff.py
    reviewboard/diffviewer/evolutions/__init__.py
    reviewboard/webapi/resources/diff.py
    reviewboard/webapi/resources/diff_commit.py
    reviewboard/diffviewer/forms.py
    reviewboard/diffviewer/evolutions/add_commit_history_fields.py
    reviewboard/diffviewer/managers.py
    reviewboard/webapi/resources/validate_diff.py
    reviewboard/webapi/resources/draft_filediff.py

Change Summary:: Update testing information to reference RBTools RR.
Testing Done:: Ran unit tests.
~ Able to create a review request with a single commit of history via RBTools (patch forthcoming).
~ Able to create a review request with a single commit of history via
+ RBTools (see: https://reviews.reviewboard.org/r/6787/).

Change Summary:

change mimetype to be diff-commit instead of commit.

Diff:

Revision 5 (+849 -151)

Show changes

	reviewboard/diffviewer/forms.py
	reviewboard/diffviewer/managers.py
	reviewboard/diffviewer/models.py
	reviewboard/webapi/resources/__init__.py
	reviewboard/webapi/resources/diff.py
	reviewboard/webapi/resources/diff_commit.py
	reviewboard/webapi/resources/draft_diff.py
	reviewboard/webapi/resources/draft_diff_commit.py
	3 more

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/draft_diff.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/webapi/resources/draft_diff_commit.py
    reviewboard/diffviewer/models.py
    reviewboard/webapi/resources/filediff.py
    reviewboard/webapi/resources/diff.py
    reviewboard/webapi/resources/diff_commit.py
    reviewboard/diffviewer/forms.py
    reviewboard/diffviewer/managers.py
    reviewboard/webapi/resources/validate_diff.py
    reviewboard/webapi/resources/draft_filediff.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/draft_diff.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/webapi/resources/draft_diff_commit.py
    reviewboard/diffviewer/models.py
    reviewboard/webapi/resources/filediff.py
    reviewboard/webapi/resources/diff.py
    reviewboard/webapi/resources/diff_commit.py
    reviewboard/diffviewer/forms.py
    reviewboard/diffviewer/managers.py
    reviewboard/webapi/resources/validate_diff.py
    reviewboard/webapi/resources/draft_filediff.py

Change Summary:

Add Web API capabilities for RRs with commit history

Description:

		Add the `DiffCommitResource` and `DraftDiffCommitResource` resources.
		The `DiffCommitResource` is a resource for retrieving the information
		about the `Commits` under a particular DiffSet. The
		`DraftDiffCommitResource` inherits from the `DiffCommitResource` and
		modifies it to allow for the creation of `Commit`s and associated
		`FileDiff`s. The `DraftDiffCommitResource` handles the uploading of
		`FileDiff`s for `Commit`s instead of the `DiffSetResource`.

		Register the `Commit` model for both `DiffCommitResource` and
		`DraftDiffCommitResource` in the API. They are item child resources of
		the `DiffSetResource` and `DraftDiffSetResource` resources,
		respectively.

		The `DiffSetResource.create` method now takes an extra optional field,
		`create_empty`, that determines if the `DiffSet` that is created is
		created without uploading a `.diff` file. This is used in the creation
		of review requests with commit histories.

		The `FileDiffResource` and `DraftFileDiffResource` classes now filter
		their results based on the `commit` query parameter. If no `commit`
		query parameter is given, only those `FileDiff`s unattached to a
		`Commit` will be return. This filtering is only applied to the list
		API, not the item API.

		Add a new form, the `UploadCommitForm`, for handling the processing of
		data for creating new `Commit` instances. It is very similar to
		`diffviewer.forms.UploadDiffForm` and may need to be refactored.

		Refactor behaviour for uploading `FileDiff`s from the `DiffSetManager`
		to a new class, the `DiffProcessorMixin`. This mix-in handles the
		initial processing of `.diff` files, their comparison (for header vs
		source files), generating file lists, and creating actual `FileDiff`s
		from upload (it calls the child class's implementation of
		`create_from_data`).

		The `DiffSetManager` now has a `create_empty` method for creating
		`DiffSet`s without `FileDiff`s for usage with `Commit`s.

		Add the `CommitManager` model. It inherits from the
		`DiffProcessorMixin.`

		Update the `validate_diff` endpoint to use named parameters for
		`DiffSetManager.create_from_upload` because of the refactoring.

	+	Add a WebAPI capability to show that the server supports review
	+	requests with commit histories.
	+
		TODO:
		- Unit tests forthcoming.
		- Manual testing information forthcoming.

Diff:

Revision 6 (+850 -173)

Show changes

	reviewboard/diffviewer/forms.py
	reviewboard/diffviewer/managers.py
	reviewboard/diffviewer/models.py
	reviewboard/webapi/server_info.py
	reviewboard/webapi/resources/__init__.py
	reviewboard/webapi/resources/diff.py
	reviewboard/webapi/resources/diff_commit.py
	reviewboard/webapi/resources/draft_diff.py
	4 more

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/draft_diff.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/webapi/resources/draft_diff_commit.py
    reviewboard/webapi/server_info.py
    reviewboard/diffviewer/models.py
    reviewboard/webapi/resources/filediff.py
    reviewboard/webapi/resources/diff.py
    reviewboard/webapi/resources/diff_commit.py
    reviewboard/diffviewer/forms.py
    reviewboard/diffviewer/managers.py
    reviewboard/webapi/resources/validate_diff.py
    reviewboard/webapi/resources/draft_filediff.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/draft_diff.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/webapi/resources/draft_diff_commit.py
    reviewboard/webapi/server_info.py
    reviewboard/diffviewer/models.py
    reviewboard/webapi/resources/filediff.py
    reviewboard/webapi/resources/diff.py
    reviewboard/webapi/resources/diff_commit.py
    reviewboard/diffviewer/forms.py
    reviewboard/diffviewer/managers.py
    reviewboard/webapi/resources/validate_diff.py
    reviewboard/webapi/resources/draft_filediff.py

Change Summary:

Add validation for the merge parents

Diff:

Revision 7 (+873 -151)

Show changes

	reviewboard/diffviewer/forms.py
	reviewboard/diffviewer/managers.py
	reviewboard/diffviewer/models.py
	reviewboard/webapi/server_info.py
	reviewboard/webapi/resources/__init__.py
	reviewboard/webapi/resources/diff.py
	reviewboard/webapi/resources/diff_commit.py
	reviewboard/webapi/resources/draft_diff.py
	4 more

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/draft_diff.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/webapi/resources/draft_diff_commit.py
    reviewboard/webapi/server_info.py
    reviewboard/diffviewer/models.py
    reviewboard/webapi/resources/filediff.py
    reviewboard/webapi/resources/diff.py
    reviewboard/webapi/resources/diff_commit.py
    reviewboard/diffviewer/forms.py
    reviewboard/diffviewer/managers.py
    reviewboard/webapi/resources/validate_diff.py
    reviewboard/webapi/resources/draft_filediff.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/draft_diff.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/webapi/resources/draft_diff_commit.py
    reviewboard/webapi/server_info.py
    reviewboard/diffviewer/models.py
    reviewboard/webapi/resources/filediff.py
    reviewboard/webapi/resources/diff.py
    reviewboard/webapi/resources/diff_commit.py
    reviewboard/diffviewer/forms.py
    reviewboard/diffviewer/managers.py
    reviewboard/webapi/resources/validate_diff.py
    reviewboard/webapi/resources/draft_filediff.py

Change Summary:

Save the models. Save them!

Diff:

Revision 8 (+876 -151)

Show changes

	reviewboard/diffviewer/forms.py
	reviewboard/diffviewer/managers.py
	reviewboard/diffviewer/models.py
	reviewboard/webapi/server_info.py
	reviewboard/webapi/resources/__init__.py
	reviewboard/webapi/resources/diff.py
	reviewboard/webapi/resources/diff_commit.py
	reviewboard/webapi/resources/draft_diff.py
	4 more

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/draft_diff.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/webapi/resources/draft_diff_commit.py
    reviewboard/webapi/server_info.py
    reviewboard/diffviewer/models.py
    reviewboard/webapi/resources/filediff.py
    reviewboard/webapi/resources/diff.py
    reviewboard/webapi/resources/diff_commit.py
    reviewboard/diffviewer/forms.py
    reviewboard/diffviewer/managers.py
    reviewboard/webapi/resources/validate_diff.py
    reviewboard/webapi/resources/draft_filediff.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/draft_diff.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/webapi/resources/draft_diff_commit.py
    reviewboard/webapi/server_info.py
    reviewboard/diffviewer/models.py
    reviewboard/webapi/resources/filediff.py
    reviewboard/webapi/resources/diff.py
    reviewboard/webapi/resources/diff_commit.py
    reviewboard/diffviewer/forms.py
    reviewboard/diffviewer/managers.py
    reviewboard/webapi/resources/validate_diff.py
    reviewboard/webapi/resources/draft_filediff.py

Diff:

Revision 9 (+876 -151)

Show changes

	reviewboard/diffviewer/forms.py
	reviewboard/diffviewer/managers.py
	reviewboard/diffviewer/models.py
	reviewboard/webapi/server_info.py
	reviewboard/webapi/resources/__init__.py
	reviewboard/webapi/resources/diff.py
	reviewboard/webapi/resources/diff_commit.py
	reviewboard/webapi/resources/draft_diff.py
	4 more

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/draft_diff.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/webapi/resources/draft_diff_commit.py
    reviewboard/webapi/server_info.py
    reviewboard/diffviewer/models.py
    reviewboard/webapi/resources/filediff.py
    reviewboard/webapi/resources/diff.py
    reviewboard/webapi/resources/diff_commit.py
    reviewboard/diffviewer/forms.py
    reviewboard/diffviewer/managers.py
    reviewboard/webapi/resources/validate_diff.py
    reviewboard/webapi/resources/draft_filediff.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/draft_diff.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/webapi/resources/draft_diff_commit.py
    reviewboard/webapi/server_info.py
    reviewboard/diffviewer/models.py
    reviewboard/webapi/resources/filediff.py
    reviewboard/webapi/resources/diff.py
    reviewboard/webapi/resources/diff_commit.py
    reviewboard/diffviewer/forms.py
    reviewboard/diffviewer/managers.py
    reviewboard/webapi/resources/validate_diff.py
    reviewboard/webapi/resources/draft_filediff.py

Change Summary:

merge_parent_id -> merge_parent_ids everywhere

Diff:

Revision 10 (+876 -151)

Show changes

	reviewboard/diffviewer/forms.py
	reviewboard/diffviewer/managers.py
	reviewboard/diffviewer/models.py
	reviewboard/webapi/server_info.py
	reviewboard/webapi/resources/__init__.py
	reviewboard/webapi/resources/diff.py
	reviewboard/webapi/resources/diff_commit.py
	reviewboard/webapi/resources/draft_diff.py
	4 more

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/draft_diff.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/webapi/resources/draft_diff_commit.py
    reviewboard/webapi/server_info.py
    reviewboard/diffviewer/models.py
    reviewboard/webapi/resources/filediff.py
    reviewboard/webapi/resources/diff.py
    reviewboard/webapi/resources/diff_commit.py
    reviewboard/diffviewer/forms.py
    reviewboard/diffviewer/managers.py
    reviewboard/webapi/resources/validate_diff.py
    reviewboard/webapi/resources/draft_filediff.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/draft_diff.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/webapi/resources/draft_diff_commit.py
    reviewboard/webapi/server_info.py
    reviewboard/diffviewer/models.py
    reviewboard/webapi/resources/filediff.py
    reviewboard/webapi/resources/diff.py
    reviewboard/webapi/resources/diff_commit.py
    reviewboard/diffviewer/forms.py
    reviewboard/diffviewer/managers.py
    reviewboard/webapi/resources/validate_diff.py
    reviewboard/webapi/resources/draft_filediff.py

Change Summary:

Check the merge_commit_ids to make sure they are truthy before enumerating them.

Diff:

Revision 11 (+877 -151)

Show changes

	reviewboard/diffviewer/forms.py
	reviewboard/diffviewer/managers.py
	reviewboard/diffviewer/models.py
	reviewboard/webapi/server_info.py
	reviewboard/webapi/resources/__init__.py
	reviewboard/webapi/resources/diff.py
	reviewboard/webapi/resources/diff_commit.py
	reviewboard/webapi/resources/draft_diff.py
	4 more

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/draft_diff.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/webapi/resources/draft_diff_commit.py
    reviewboard/webapi/server_info.py
    reviewboard/diffviewer/models.py
    reviewboard/webapi/resources/filediff.py
    reviewboard/webapi/resources/diff.py
    reviewboard/webapi/resources/diff_commit.py
    reviewboard/diffviewer/forms.py
    reviewboard/diffviewer/managers.py
    reviewboard/webapi/resources/validate_diff.py
    reviewboard/webapi/resources/draft_filediff.py



Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/draft_diff.py
    reviewboard/webapi/resources/__init__.py
    reviewboard/webapi/resources/draft_diff_commit.py
    reviewboard/webapi/server_info.py
    reviewboard/diffviewer/models.py
    reviewboard/webapi/resources/filediff.py
    reviewboard/webapi/resources/diff.py
    reviewboard/webapi/resources/diff_commit.py
    reviewboard/diffviewer/forms.py
    reviewboard/diffviewer/managers.py
    reviewboard/webapi/resources/validate_diff.py
    reviewboard/webapi/resources/draft_filediff.py

Status:: Discarded
Change Summary:: Splitting this up more.