• 
      

    Get rid of user names and timestamps in the review dialog.

    Review Request #6769 — Created Jan. 13, 2015 and submitted

    Information

    Review Board
    master
    d696017...

    Reviewers

    With the new review dialog, I had initially put in labels mimicing the
    appearance of the review, including the user's full name and a timestamp. This
    wasn't particularly useful, because the user was always the person looking at
    it, and the timestamp just showed the current time.

    I've replaced these with simple text that just say "Edit {header, comment,
    footer}".

    • Opened the review dialog and saw the new text.
    • Ran jshint.
    • Ran js-tests.

    reviewbot
    1. Tool: Pyflakes
      Ignored Files:
          reviewboard/static/rb/js/views/reviewDialogView.js
          reviewboard/static/rb/css/pages/reviews.less
      
      
      
      Tool: PEP8 Style Checker
      Ignored Files:
          reviewboard/static/rb/js/views/reviewDialogView.js
          reviewboard/static/rb/css/pages/reviews.less
      
      
    2. 
        
    chipx86
    1. Ship It!
    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (daa5f13)