• 
      

    Fix absolute paths with prepare-dev.py

    Review Request #6756 — Created Jan. 11, 2015 and submitted

    Information

    Review Board
    release-2.0.x
    2295e99...

    Reviewers

    Stephen Gallagher's recent change to install sites into a default directory had
    the unintentional side effect of breaking prepare-dev.py. The issue was that
    using the Site object with a relative path now tries to use that path relative
    to the default directory rather than the current working directory.

    This change makes the relative 'reviewboard' path absolute before constructing
    the Site object.

    Ran prepare-dev.py. Before this change it would error out with permissions.
    After, it runs successfully.

    Description From Last Updated

    Yes, you don't need to import it, I just checked in a shell. import os os.path.isdir('/')

    TB tbelaire

    I don't think this is needed since we've already imported os?

    anselinaanselina
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          contrib/internal/prepare-dev.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          contrib/internal/prepare-dev.py
      
      
    2. 
        
    anselina
    1. 
        
    2. contrib/internal/prepare-dev.py (Diff revision 1)
       
       
      Show all issues

      I don't think this is needed since we've already imported os?

    3. 
        
    TB
    1. 
        
    2. contrib/internal/prepare-dev.py (Diff revision 1)
       
       
      Show all issues

      Yes, you don't need to import it, I just checked in a shell.

      import os
      os.path.isdir('/')
      
    3. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.0.x (4c6ada5)