• 
      

    Pre-fill the file caption when updating.

    Review Request #6755 — Created Jan. 9, 2015 and submitted

    Information

    Review Board
    master
    fc9a57a...

    Reviewers

    When updating a file attachment, it's likely that the user won't want to change
    the caption. In this case, presenting a blank caption field will encourage them
    to fill something in, resulting in different revisions having different
    captions. This change makes it so that the field in the upload dialog is
    pre-filled with the existing caption when updating.

    • Clicked "Add File" and saw the caption field was empty.
    • Clicked "Update" and saw the caption field was pre-filled with the old
      caption.
    reviewbot
    1. Tool: Pyflakes
      Ignored Files:
          reviewboard/static/rb/js/views/fileAttachmentThumbnailView.js
          reviewboard/static/rb/js/views/uploadAttachmentView.js
      
      
      
      Tool: PEP8 Style Checker
      Ignored Files:
          reviewboard/static/rb/js/views/fileAttachmentThumbnailView.js
          reviewboard/static/rb/js/views/uploadAttachmentView.js
      
      
    2. 
        
    brennie
    1. Ship It!
    2. 
        
    chipx86
    1. Ship It!
    2. 
        
    david
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to ucosp/rmdone/file-attachment-revisions (b80ab6c)