• 
      

    Use a timestamp server for the RBTools Windows installer.

    Review Request #6749 — Created Jan. 8, 2015 and submitted

    Information

    RBTools
    master
    950b8c9...

    Reviewers

    This uses the Comodo timestamp server when signing the Windows installer
    using our authenticode certificate. This ensures that when the
    certificate expires, the installers will still be functional, since
    there will be a way to ensure that the certificate was valid when the
    installer was made.

    Built the installer. I didn't have any errors.

    Set the timestamp server to google.com, just to verify that it was being
    used for timestamping. Saw an error.

    reviewbot
    1. Tool: Pyflakes
      Ignored Files:
          contrib/installers/windows/build-installer.bat
          contrib/installers/windows/wix/rbtools.wixproj
      
      
      
      Tool: PEP8 Style Checker
      Ignored Files:
          contrib/installers/windows/build-installer.bat
          contrib/installers/windows/wix/rbtools.wixproj
      
      
    2. 
        
    david
    1. Ship It!
    2. 
        
    BC
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (cdd2c06)