Summary

"Edit" button appears next to image titles that the user doesn't have permission to edit

Review Request #6747 — Created Jan. 8, 2015 and submitted Jan. 8, 2015, 1:26 p.m.

Information

Owner

VTL-Developer

Repository

Review Board

Branch

master

Bugs

3606

Depends On

Commit

0ee0cd6...

Reviewers

Groups

reviewboard, students

People

Description

Edit button and functionality was given to everyone as the check was not done on the front end. Checking with the model for ReviewRequestEditor was done to ensure edit permissions were allowed.

Testing Done

Testing was done manually with admin, users (people who created the issue, part of the group/issued to, or not part of the group) and visitors.

Issues

Description	From	Last Updated
This should use this.model.get('editable') rather than accessing the attributes object directly.	david	Jan. 8, 2015, 1:18 p.m.
Actually, one last change. It's probably more correct to use === true rather than !== false (since if editable were …	david	Jan. 8, 2015, 1:25 p.m.

Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/js/views/reviewRequestEditorView.js



Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/js/views/reviewRequestEditorView.js

Change Summary:: Added bug issue id
Bugs:: 3606

You can remove "Bug Issue 3306" from the title. The generated commit description will contain the bug number.

You should add the students group to future reviews.

Summary:: Bug Issue 3606: "Edit" button appears next to image titles that the user doesn't have permission to edit
"Edit" button appears next to image titles that the user doesn't have permission to edit
Groups:: students

Ship it!

```
Ship It!
```

reviewboard/static/rb/js/views/reviewRequestEditorView.js (Diff revision 1)
The issue has been resolved. Show all issues
```
This should use this.model.get('editable') rather than accessing the attributes object directly.
```

Change Summary:

Adjusted to use Backbone.js implementation

Commit:

243c9393a96e6b4f6115c9b7a86b8e34e3aeb749

8241c125e0491c94de523969cd300d7c0bb272a5

Diff:

Revision 2 (+1 -1)

Show changes

reviewboard/static/rb/js/views/reviewRequestEditorView.js

Tool: Pyflakes
Ignored Files:
    reviewboard/static/rb/js/views/reviewRequestEditorView.js



Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/static/rb/js/views/reviewRequestEditorView.js

reviewboard/static/rb/js/views/reviewRequestEditorView.js (Diff revision 2)

The issue has been resolved. Show all issues

Actually, one last change. It's probably more correct to use === true rather than !== false (since if editable were null or undefined, we wouldn't want to assume that it was OK to edit).

chipx86 Jan. 8, 2015, 1:27 p.m.

editable will always be true or false in this case. It was only ever possible for it to be undefined in the options case.