Fix uploading diffs in the New Review Request page.

Review Request #6732 — Created Jan. 5, 2015 and submitted

Information

Review Board
release-2.0.x
64b81e0...

Reviewers

The recent work to improve serialization for resource models left out
the Diff model, while also removing the ValidateDiff model's toJSON
function. This resulted in Diff's toJSON being used without factoring in
the repository attribute in ValidateDiff.

This code is now all converted to use the new serialization code, fixing
diff uploads.

Tested uploading a diff with and without errors (short SHA1s). Saw the errors
in the error case, and got a review request with the right diff in the success
case.

reviewbot
  1. Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/static/rb/js/resources/models/diffModel.js
        reviewboard/static/rb/js/resources/models/validateDiffModel.js
    
    
    
    Tool: Pyflakes
    Ignored Files:
        reviewboard/static/rb/js/resources/models/diffModel.js
        reviewboard/static/rb/js/resources/models/validateDiffModel.js
    
    
  2. 
      
brennie
  1. Ship It!
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-2.0.x (31b1966)