• 
      

    Add a --dry-run argument to rbt land, and operations output.

    Review Request #6719 — Created Jan. 1, 2015 and submitted

    Information

    RBTools
    master
    cae27aa...

    Reviewers

    rbt land is a command that can have some real impact on a source tree,
    so it's important to let people feel comfortable knowing what it's going
    to do.

    This change adds a --dry-run argument that simulates the entire process
    of landing a change, merging the branch, and pushing. It won't actually
    perform those operations, but will act as if it did. This means that
    some validation steps performed by the SCM tool may not occur, but will
    still give a good sense of what's going to happen.

    It also adds some output indicating what's going to happen at each
    important stage, so that if something goes wrong, the user has a good
    idea as to where and with what branches.

    Tested with remote changes and local branches, with both squashing and merging.

    Verified that the tree was untouched, but that all the expected operations were
    being "performed" (as per the output).

    Description From Last Updated

    Can you swap the quote styles here? (Use '' for strings and "" in the printed output)

    daviddavid

    Same here re: quotes.

    daviddavid
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          rbtools/commands/land.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          rbtools/commands/land.py
      
      
    2. 
        
    david
    1. 
        
    2. rbtools/commands/land.py (Diff revision 1)
       
       
       
       
       
      Show all issues

      Can you swap the quote styles here? (Use '' for strings and "" in the printed output)

    3. rbtools/commands/land.py (Diff revision 1)
       
       
      Show all issues

      Same here re: quotes.

    4. 
        
    chipx86
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          rbtools/commands/land.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          rbtools/commands/land.py
      
      
    2. 
        
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (a6e79cc)