Summary

Add a Windows installer for RBTools.

Review Request #6690 — Created Dec. 11, 2014 and submitted Dec. 17, 2014, 12:30 a.m.

Information

Owner

chipx86

Repository

RBTools

Branch

master

Bugs

Depends On

Commit

ff84907...

Reviewers

Groups

rbtools

People

bcran

Description

This introduces the Windows installer that we'll be shipping with
official RBTools releases, starting in 0.7. It's based upon Bruce Cran's
installer work, which makes use of WiX and Portable Python to produce a
standalone RBTools install independent of any system installs of Python.

This change extends Bruce's work to automate the building of the installer
and to isolate the build environment from the system. There's a
build-installer.bat file that handles the installation of Portable Python
(guiding the user through a Minimal installation on the first build),
stripping it, installing RBTools and its dependencies, and building the
WiX installer.

This must run on a Windows install, and does not run automatically when
we perform builds. It must instead be run manually within a suitable
Windows build environment. That environment does not need Python installed
up-front, but does need WiX and MSBuild.exe (part of Visual Studio or
MS Build Tools, though currently only tested with the former).

Testing Done

Built a package with a 0.6.9 version number (for testing). Saw it installed.

Re-ran the installer and saw that it said it was already installed, giving me

the option to repair or uninstall.
Saw the version in Add/Remove Programs. Uninstalled it without problems.
Re-installed 0.6.9, then built an installer for 0.7. Installed that, and saw

that it upgraded.
Tried to install 0.6.9 with 0.7 installed, and saw it say that a newer version

was already installed.
Uninstalled 0.7 without problems.
Re-installed 0.7. Used that to post this change.

Issues

Description	From	Last Updated
This should use from __future__ import print_function	david	Dec. 15, 2014, 8:20 p.m.
You might want to define a default value for $(Version) up in the top PropertyGroup, otherwise I think builds through …	BC bcran	Dec. 14, 2014, 10:29 p.m.
Ditto with the $(Version).	BC bcran	Dec. 14, 2014, 10:29 p.m.

Tool: Pyflakes
Processed Files:
    contrib/installers/windows/scripts/get-version.py

Ignored Files:
    contrib/installers/windows/wix/files/rbt.cmd
    contrib/installers/windows/wix/rbtools.sln
    contrib/installers/windows/wix/files/favicon.ico
    .gitignore
    contrib/installers/windows/wix/files/logo.png
    contrib/installers/windows/build-installer.bat
    contrib/installers/windows/wix/rbtools.wixproj
    contrib/installers/windows/wix/bundle.wxs
    contrib/installers/windows/wix/bootstrapper.wixproj
    contrib/installers/windows/wix/product.wxs



Tool: PEP8 Style Checker
Processed Files:
    contrib/installers/windows/scripts/get-version.py

Ignored Files:
    contrib/installers/windows/wix/files/rbt.cmd
    contrib/installers/windows/wix/rbtools.sln
    contrib/installers/windows/wix/files/favicon.ico
    .gitignore
    contrib/installers/windows/wix/files/logo.png
    contrib/installers/windows/build-installer.bat
    contrib/installers/windows/wix/rbtools.wixproj
    contrib/installers/windows/wix/bundle.wxs
    contrib/installers/windows/wix/bootstrapper.wixproj
    contrib/installers/windows/wix/product.wxs

People:: bcran

Ship it!

contrib/installers/windows/wix/bootstrapper.wixproj (Diff revision 1)

The issue has been dropped. Show all issues

You might want to define a default value for $(Version) up in the top PropertyGroup, otherwise I think builds through Visual Studio will fail.

chipx86 Dec. 11, 2014, 5:43 p.m.

There's no default version that would really make sense though. We certainly don't want to worry about having to edit this file every release.

We won't be doing builds through Visual Studio. This will in time all be automated and driven by the batch file. Given that, is there really any need to worry about Visual Studio builds?

bcran Dec. 11, 2014, 5:48 p.m.

I normally set the default to something like 1.0 or 0.1; it never gets used except in development.
Personally, I like to keep builds through Visual Studio minimally functional because it makes testing during development a bit easier.
It's not a big deal though, so let's drop the issue for now.

contrib/installers/windows/wix/rbtools.wixproj (Diff revision 1)
The issue has been dropped. Show all issues
```
Ditto with the $(Version).
```

contrib/installers/windows/scripts/get-version.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This should use from __future__ import print_function
```

Change Summary:

Use unicode_literals and print_function in the get-version.py script.

Commit:

83cbed641d8c7b0e8c747e9e6be4d37f8a7b9145

ff8490782c14ece48c5aa77221904c7f7a884728

Diff:

Revision 2 (+552)

Show changes

	.gitignore
	contrib/installers/windows/build-installer.bat
	contrib/installers/windows/scripts/get-version.py
	contrib/installers/windows/wix/bootstrapper.wixproj
	contrib/installers/windows/wix/bundle.wxs
	contrib/installers/windows/wix/product.wxs
	contrib/installers/windows/wix/rbtools.sln
	contrib/installers/windows/wix/rbtools.wixproj
	3 more

Tool: Pyflakes
Processed Files:
    contrib/installers/windows/scripts/get-version.py

Ignored Files:
    contrib/installers/windows/wix/files/rbt.cmd
    contrib/installers/windows/wix/rbtools.sln
    contrib/installers/windows/wix/files/favicon.ico
    .gitignore
    contrib/installers/windows/wix/files/logo.png
    contrib/installers/windows/build-installer.bat
    contrib/installers/windows/wix/rbtools.wixproj
    contrib/installers/windows/wix/bundle.wxs
    contrib/installers/windows/wix/bootstrapper.wixproj
    contrib/installers/windows/wix/product.wxs



Tool: PEP8 Style Checker
Processed Files:
    contrib/installers/windows/scripts/get-version.py

Ignored Files:
    contrib/installers/windows/wix/files/rbt.cmd
    contrib/installers/windows/wix/rbtools.sln
    contrib/installers/windows/wix/files/favicon.ico
    .gitignore
    contrib/installers/windows/wix/files/logo.png
    contrib/installers/windows/build-installer.bat
    contrib/installers/windows/wix/rbtools.wixproj
    contrib/installers/windows/wix/bundle.wxs
    contrib/installers/windows/wix/bootstrapper.wixproj
    contrib/installers/windows/wix/product.wxs

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (e8485ba)