Updated Web API Docs "versionadded" entries and Web API Field definitions to include an "added_in" Entry.
Review Request #6680 — Created Dec. 5, 2014 and submitted
We started adding an "added_in" entry, which tells us in which version a particular field was added, everytime we introduce a new field in a web API resource. It was pretty inconsistant, and some fields never had those entires added in the first place.
Now, all relevant fields in the web API resources have an "added_in" entry, and all releveant resources in the web API docs have a "versionadded" entry with the correct version.
Used git blame, git log, and git tag to find the commit that added each field.
Built the docs.
| Description | From | Last Updated |
|---|---|---|
|
Col: 21 E261 at least two spaces before inline comment |
 reviewbot
|
|
|
Col: 35 E261 at least two spaces before inline comment |
reviewbot
|
|
|
Col: 35 E261 at least two spaces before inline comment |
reviewbot
|
|
|
Col: 21 E261 at least two spaces before inline comment |
reviewbot
|
|
|
Please add a blank line between these. Here and in all the other files too. |
 david
|
|
|
Please revert this line. |
david
|
|
|
Revert this line. |
david
|
|
|
Col: 21 E261 at least two spaces before inline comment |
reviewbot
|
|
|
Col: 35 E261 at least two spaces before inline comment |
reviewbot
|
|
|
Col: 35 E261 at least two spaces before inline comment |
reviewbot
|
|
|
Col: 21 E261 at least two spaces before inline comment |
reviewbot
|
- Commit:
-
4dd2a06b361547238089e8f3a8f5372380c98164ce5c7f93ea4b2970844d080393598c5380d78fb2
- Diff:
-
Revision 2 (+466 -6)
-
Tool: Pyflakes Processed Files: reviewboard/webapi/resources/draft_diff.py reviewboard/webapi/resources/repository.py reviewboard/webapi/resources/draft_original_file.py reviewboard/webapi/resources/repository_commits.py reviewboard/webapi/resources/repository_info.py reviewboard/webapi/resources/review_group.py reviewboard/webapi/resources/review_request_draft.py reviewboard/webapi/resources/draft_file_attachment.py reviewboard/webapi/resources/file_attachment.py reviewboard/webapi/resources/validate_diff.py reviewboard/webapi/resources/patched_file.py reviewboard/webapi/resources/base_watched_object.py reviewboard/webapi/resources/draft_screenshot.py reviewboard/webapi/resources/diff.py reviewboard/webapi/resources/hosting_service_account.py reviewboard/webapi/resources/review_diff_comment.py reviewboard/webapi/resources/review_reply.py reviewboard/webapi/resources/base_diff_comment.py reviewboard/webapi/resources/base_file_attachment.py reviewboard/webapi/resources/review_reply_file_attachment_comment.py reviewboard/webapi/resources/base_original_file.py reviewboard/webapi/resources/review_file_attachment_comment.py reviewboard/webapi/resources/change.py reviewboard/webapi/resources/session.py reviewboard/webapi/resources/review_request_last_update.py reviewboard/webapi/resources/draft_filediff.py reviewboard/webapi/resources/root.py reviewboard/webapi/resources/review_reply_screenshot_comment.py reviewboard/webapi/resources/api_token.py reviewboard/webapi/resources/base_comment.py reviewboard/webapi/resources/diff_file_attachment.py reviewboard/webapi/resources/base_screenshot_comment.py reviewboard/webapi/resources/screenshot.py reviewboard/webapi/resources/review_screenshot_comment.py reviewboard/webapi/resources/base_file_attachment_comment.py reviewboard/webapi/resources/review_request.py reviewboard/webapi/resources/default_reviewer.py reviewboard/webapi/resources/validation.py reviewboard/webapi/resources/original_file.py reviewboard/webapi/resources/base_review.py reviewboard/webapi/resources/server_info.py reviewboard/webapi/resources/repository_branches.py reviewboard/webapi/resources/review_reply_draft.py reviewboard/webapi/resources/hosting_service.py reviewboard/webapi/resources/filediff_comment.py reviewboard/webapi/resources/watched_review_group.py reviewboard/webapi/base.py reviewboard/webapi/resources/diff_context.py reviewboard/webapi/resources/base_patched_file.py reviewboard/webapi/resources/draft_patched_file.py reviewboard/webapi/resources/remote_repository.py reviewboard/webapi/resources/base_screenshot.py reviewboard/webapi/resources/watched_review_request.py reviewboard/webapi/resources/screenshot_comment.py reviewboard/webapi/resources/file_attachment_comment.py reviewboard/webapi/resources/search.py reviewboard/webapi/resources/filediff.py reviewboard/webapi/resources/review_group_user.py reviewboard/webapi/resources/review.py reviewboard/webapi/resources/user.py reviewboard/webapi/resources/watched.py reviewboard/webapi/resources/review_draft.py reviewboard/webapi/resources/review_reply_diff_comment.py Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/resources/draft_diff.py reviewboard/webapi/resources/repository.py reviewboard/webapi/resources/draft_original_file.py reviewboard/webapi/resources/repository_commits.py reviewboard/webapi/resources/repository_info.py reviewboard/webapi/resources/review_group.py reviewboard/webapi/resources/review_request_draft.py reviewboard/webapi/resources/draft_file_attachment.py reviewboard/webapi/resources/file_attachment.py reviewboard/webapi/resources/validate_diff.py reviewboard/webapi/resources/patched_file.py reviewboard/webapi/resources/base_watched_object.py reviewboard/webapi/resources/draft_screenshot.py reviewboard/webapi/resources/diff.py reviewboard/webapi/resources/hosting_service_account.py reviewboard/webapi/resources/review_diff_comment.py reviewboard/webapi/resources/review_reply.py reviewboard/webapi/resources/base_diff_comment.py reviewboard/webapi/resources/base_file_attachment.py reviewboard/webapi/resources/review_reply_file_attachment_comment.py reviewboard/webapi/resources/base_original_file.py reviewboard/webapi/resources/review_file_attachment_comment.py reviewboard/webapi/resources/change.py reviewboard/webapi/resources/session.py reviewboard/webapi/resources/review_request_last_update.py reviewboard/webapi/resources/draft_filediff.py reviewboard/webapi/resources/root.py reviewboard/webapi/resources/review_reply_screenshot_comment.py reviewboard/webapi/resources/api_token.py reviewboard/webapi/resources/base_comment.py reviewboard/webapi/resources/diff_file_attachment.py reviewboard/webapi/resources/base_screenshot_comment.py reviewboard/webapi/resources/screenshot.py reviewboard/webapi/resources/review_screenshot_comment.py reviewboard/webapi/resources/base_file_attachment_comment.py reviewboard/webapi/resources/review_request.py reviewboard/webapi/resources/default_reviewer.py reviewboard/webapi/resources/validation.py reviewboard/webapi/resources/original_file.py reviewboard/webapi/resources/base_review.py reviewboard/webapi/resources/server_info.py reviewboard/webapi/resources/repository_branches.py reviewboard/webapi/resources/review_reply_draft.py reviewboard/webapi/resources/hosting_service.py reviewboard/webapi/resources/filediff_comment.py reviewboard/webapi/resources/watched_review_group.py reviewboard/webapi/base.py reviewboard/webapi/resources/diff_context.py reviewboard/webapi/resources/base_patched_file.py reviewboard/webapi/resources/draft_patched_file.py reviewboard/webapi/resources/remote_repository.py reviewboard/webapi/resources/base_screenshot.py reviewboard/webapi/resources/watched_review_request.py reviewboard/webapi/resources/screenshot_comment.py reviewboard/webapi/resources/file_attachment_comment.py reviewboard/webapi/resources/search.py reviewboard/webapi/resources/filediff.py reviewboard/webapi/resources/review_group_user.py reviewboard/webapi/resources/review.py reviewboard/webapi/resources/user.py reviewboard/webapi/resources/watched.py reviewboard/webapi/resources/review_draft.py reviewboard/webapi/resources/review_reply_diff_comment.py
-
This is a great start, and will really help things! There's a few parts that need to be fixed up though:
- Since 1.5 was the first version, I don't think it's worth listing any 1.5 versions. Any 1.5 APIs have been around "forever," in terms of the API's lifeline, so it can just be assumed to be there.
- If a resource was added in a particular version, the fields don't need to have an
added_inmatching that version. Just fields introduced since the resource was added. APIToken, for example, wouldn't need to show 2.1 for the fields. - There are places where the code moved around, but the fields aren't actually new. For instance, you have
idandreply_to_idfor comments showing 2.0, but they weren't actually added in 2.0, and in fact have been around since 1.5 (in those specific cases).
- Summary:
-
Updated Web API Field definitions to include an "added_in" Entry.Updated Web API Docs "versionadded" entries and Web API Field definitions to include an "added_in" Entry.
- Description:
-
~ Not long ago we started adding an "added_in" entry, saying in which version a particular field was added, everytime we introduce a new field in a web API resource. It was pretty inconsistant, and there were a lot of fields that just never had those entires added in the first place.
~ Now all the fields in the web API resources have an "added_in" entry with the correct version. ~ We started adding an "added_in" entry, which tells us in which version a particular field was added, everytime we introduce a new field in a web API resource. It was pretty inconsistant, and some fields never had those entires added in the first place.
~ Now, all relevant fields in the web API resources have an "added_in" entry, and all releveant resources in the web API docs have a "versionadded" entry with the correct version. - Testing Done:
-
~ Used git blame, git log, and git tag to find the commit that added each field.
~ Used git blame, git log, and git tag to find the commit that added each field.
+ Built the docs. - Commit:
-
ce5c7f93ea4b2970844d080393598c5380d78fb2273b2afb6b1b54d208a98de471d02f45a2496281
- Diff:
-
Revision 3 (+188 -7)
-
Tool: Pyflakes Processed Files: reviewboard/webapi/resources/draft_diff.py reviewboard/webapi/resources/repository.py reviewboard/webapi/resources/draft_original_file.py reviewboard/webapi/resources/repository_commits.py reviewboard/webapi/resources/review_group.py reviewboard/webapi/resources/review_request_draft.py reviewboard/webapi/resources/draft_file_attachment.py reviewboard/webapi/resources/file_attachment.py reviewboard/webapi/resources/validate_diff.py reviewboard/webapi/resources/patched_file.py reviewboard/webapi/resources/diff.py reviewboard/webapi/resources/hosting_service_account.py reviewboard/webapi/resources/review_reply.py reviewboard/webapi/resources/base_diff_comment.py reviewboard/webapi/resources/base_file_attachment.py reviewboard/webapi/resources/review_reply_file_attachment_comment.py reviewboard/webapi/resources/base_original_file.py reviewboard/webapi/resources/review_file_attachment_comment.py reviewboard/webapi/resources/change.py reviewboard/webapi/resources/draft_filediff.py reviewboard/webapi/resources/base_comment.py reviewboard/webapi/resources/diff_file_attachment.py reviewboard/webapi/resources/base_screenshot_comment.py reviewboard/webapi/resources/base_file_attachment_comment.py reviewboard/webapi/resources/review_request.py reviewboard/webapi/resources/default_reviewer.py reviewboard/webapi/resources/original_file.py reviewboard/webapi/resources/base_review.py reviewboard/webapi/resources/server_info.py reviewboard/webapi/resources/repository_branches.py reviewboard/webapi/resources/hosting_service.py reviewboard/webapi/resources/user.py reviewboard/webapi/resources/diff_context.py reviewboard/webapi/resources/base_patched_file.py reviewboard/webapi/resources/draft_patched_file.py reviewboard/webapi/resources/remote_repository.py reviewboard/webapi/resources/base_screenshot.py reviewboard/webapi/resources/file_attachment_comment.py reviewboard/webapi/resources/search.py reviewboard/webapi/resources/filediff.py reviewboard/webapi/resources/review_group_user.py reviewboard/webapi/resources/validation.py Ignored Files: docs/manual/webapi/2.0/resources/repository-commits.rst docs/manual/webapi/2.0/resources/hosting-service.rst docs/manual/webapi/2.0/resources/default-reviewer.rst docs/manual/webapi/2.0/resources/hosting-service-account-list.rst docs/manual/webapi/2.0/resources/repository-branches.rst docs/manual/webapi/2.0/resources/search.rst docs/manual/webapi/2.0/resources/original-file.rst docs/manual/webapi/2.0/resources/draft-diff.rst docs/manual/webapi/2.0/resources/draft-patched-file.rst docs/manual/webapi/2.0/resources/api-token.rst docs/manual/webapi/2.0/resources/patched-file.rst docs/manual/webapi/2.0/resources/diff-context.rst docs/manual/webapi/2.0/resources/draft-original-file.rst docs/manual/webapi/2.0/resources/hosting-service-account.rst Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/resources/draft_diff.py reviewboard/webapi/resources/repository.py reviewboard/webapi/resources/draft_original_file.py reviewboard/webapi/resources/repository_commits.py reviewboard/webapi/resources/review_group.py reviewboard/webapi/resources/review_request_draft.py reviewboard/webapi/resources/draft_file_attachment.py reviewboard/webapi/resources/file_attachment.py reviewboard/webapi/resources/validate_diff.py reviewboard/webapi/resources/patched_file.py reviewboard/webapi/resources/diff.py reviewboard/webapi/resources/hosting_service_account.py reviewboard/webapi/resources/review_reply.py reviewboard/webapi/resources/base_diff_comment.py reviewboard/webapi/resources/base_file_attachment.py reviewboard/webapi/resources/review_reply_file_attachment_comment.py reviewboard/webapi/resources/base_original_file.py reviewboard/webapi/resources/review_file_attachment_comment.py reviewboard/webapi/resources/change.py reviewboard/webapi/resources/draft_filediff.py reviewboard/webapi/resources/base_comment.py reviewboard/webapi/resources/diff_file_attachment.py reviewboard/webapi/resources/base_screenshot_comment.py reviewboard/webapi/resources/base_file_attachment_comment.py reviewboard/webapi/resources/review_request.py reviewboard/webapi/resources/default_reviewer.py reviewboard/webapi/resources/original_file.py reviewboard/webapi/resources/base_review.py reviewboard/webapi/resources/server_info.py reviewboard/webapi/resources/repository_branches.py reviewboard/webapi/resources/hosting_service.py reviewboard/webapi/resources/user.py reviewboard/webapi/resources/diff_context.py reviewboard/webapi/resources/base_patched_file.py reviewboard/webapi/resources/draft_patched_file.py reviewboard/webapi/resources/remote_repository.py reviewboard/webapi/resources/base_screenshot.py reviewboard/webapi/resources/file_attachment_comment.py reviewboard/webapi/resources/search.py reviewboard/webapi/resources/filediff.py reviewboard/webapi/resources/review_group_user.py reviewboard/webapi/resources/validation.py Ignored Files: docs/manual/webapi/2.0/resources/repository-commits.rst docs/manual/webapi/2.0/resources/hosting-service.rst docs/manual/webapi/2.0/resources/default-reviewer.rst docs/manual/webapi/2.0/resources/hosting-service-account-list.rst docs/manual/webapi/2.0/resources/repository-branches.rst docs/manual/webapi/2.0/resources/search.rst docs/manual/webapi/2.0/resources/original-file.rst docs/manual/webapi/2.0/resources/draft-diff.rst docs/manual/webapi/2.0/resources/draft-patched-file.rst docs/manual/webapi/2.0/resources/api-token.rst docs/manual/webapi/2.0/resources/patched-file.rst docs/manual/webapi/2.0/resources/diff-context.rst docs/manual/webapi/2.0/resources/draft-original-file.rst docs/manual/webapi/2.0/resources/hosting-service-account.rst
- Commit:
-
273b2afb6b1b54d208a98de471d02f45a2496281480129304a300acea18fda4781b9aa873ee17e9e
- Diff:
-
Revision 4 (+40 -1)
-
Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/resources/review_group_user.py reviewboard/webapi/resources/base_screenshot_comment.py Ignored Files: docs/manual/webapi/2.0/resources/change-list.rst docs/manual/webapi/2.0/resources/review-reply-file-attachment-comment-list.rst docs/manual/webapi/2.0/resources/review-reply-file-attachment-comment.rst docs/manual/webapi/2.0/resources/draft-diff-list.rst docs/manual/webapi/2.0/resources/hosting-service-list.rst docs/manual/webapi/2.0/resources/diff-context.rst docs/manual/webapi/2.0/resources/file-attachment-list.rst docs/manual/webapi/2.0/resources/change.rst docs/manual/webapi/2.0/resources/file-attachment-comment-list.rst docs/manual/webapi/2.0/resources/draft-file-diff-list.rst docs/manual/webapi/2.0/resources/original-file.rst docs/manual/webapi/2.0/resources/api-token-list.rst docs/manual/webapi/2.0/resources/draft-original-file.rst docs/manual/webapi/2.0/resources/hosting-service.rst docs/manual/webapi/2.0/resources/hosting-service-account.rst docs/manual/webapi/2.0/resources/remote-repository-list.rst docs/manual/webapi/2.0/resources/hosting-service-account-list.rst docs/manual/webapi/2.0/resources/default-reviewer-list.rst docs/manual/webapi/2.0/resources/remote-repository.rst docs/manual/webapi/2.0/resources/patched-file.rst docs/manual/webapi/2.0/resources/draft-file-attachment.rst docs/manual/webapi/2.0/resources/review-file-attachment-comment.rst docs/manual/webapi/2.0/resources/repository-commits.rst docs/manual/webapi/2.0/resources/default-reviewer.rst docs/manual/webapi/2.0/resources/draft-file-diff.rst docs/manual/webapi/2.0/resources/draft-file-attachment-list.rst docs/manual/webapi/2.0/resources/search.rst docs/manual/webapi/2.0/resources/file-attachment.rst docs/manual/webapi/2.0/resources/draft-diff.rst docs/manual/webapi/2.0/resources/draft-patched-file.rst docs/manual/webapi/2.0/resources/review-file-attachment-comment-list.rst docs/manual/webapi/2.0/resources/api-token.rst docs/manual/webapi/2.0/resources/repository-branches.rst Tool: Pyflakes Processed Files: reviewboard/webapi/resources/review_group_user.py reviewboard/webapi/resources/base_screenshot_comment.py Ignored Files: docs/manual/webapi/2.0/resources/change-list.rst docs/manual/webapi/2.0/resources/review-reply-file-attachment-comment-list.rst docs/manual/webapi/2.0/resources/review-reply-file-attachment-comment.rst docs/manual/webapi/2.0/resources/draft-diff-list.rst docs/manual/webapi/2.0/resources/hosting-service-list.rst docs/manual/webapi/2.0/resources/diff-context.rst docs/manual/webapi/2.0/resources/file-attachment-list.rst docs/manual/webapi/2.0/resources/change.rst docs/manual/webapi/2.0/resources/file-attachment-comment-list.rst docs/manual/webapi/2.0/resources/draft-file-diff-list.rst docs/manual/webapi/2.0/resources/original-file.rst docs/manual/webapi/2.0/resources/api-token-list.rst docs/manual/webapi/2.0/resources/draft-original-file.rst docs/manual/webapi/2.0/resources/hosting-service.rst docs/manual/webapi/2.0/resources/hosting-service-account.rst docs/manual/webapi/2.0/resources/remote-repository-list.rst docs/manual/webapi/2.0/resources/hosting-service-account-list.rst docs/manual/webapi/2.0/resources/default-reviewer-list.rst docs/manual/webapi/2.0/resources/remote-repository.rst docs/manual/webapi/2.0/resources/patched-file.rst docs/manual/webapi/2.0/resources/draft-file-attachment.rst docs/manual/webapi/2.0/resources/review-file-attachment-comment.rst docs/manual/webapi/2.0/resources/repository-commits.rst docs/manual/webapi/2.0/resources/default-reviewer.rst docs/manual/webapi/2.0/resources/draft-file-diff.rst docs/manual/webapi/2.0/resources/draft-file-attachment-list.rst docs/manual/webapi/2.0/resources/search.rst docs/manual/webapi/2.0/resources/file-attachment.rst docs/manual/webapi/2.0/resources/draft-diff.rst docs/manual/webapi/2.0/resources/draft-patched-file.rst docs/manual/webapi/2.0/resources/review-file-attachment-comment-list.rst docs/manual/webapi/2.0/resources/api-token.rst docs/manual/webapi/2.0/resources/repository-branches.rst
- Commit:
-
480129304a300acea18fda4781b9aa873ee17e9e5de340ed6bf674e8613cf63f421e908d5aff3f51
- Diff:
-
Revision 5 (+226 -6)
-
Tool: Pyflakes Processed Files: reviewboard/webapi/resources/draft_diff.py reviewboard/webapi/resources/repository.py reviewboard/webapi/resources/draft_original_file.py reviewboard/webapi/resources/repository_commits.py reviewboard/webapi/resources/review_group.py reviewboard/webapi/resources/review_request_draft.py reviewboard/webapi/resources/draft_file_attachment.py reviewboard/webapi/resources/file_attachment.py reviewboard/webapi/resources/validate_diff.py reviewboard/webapi/resources/patched_file.py reviewboard/webapi/resources/diff.py reviewboard/webapi/resources/hosting_service_account.py reviewboard/webapi/resources/review_reply.py reviewboard/webapi/resources/base_diff_comment.py reviewboard/webapi/resources/base_file_attachment.py reviewboard/webapi/resources/review_reply_file_attachment_comment.py reviewboard/webapi/resources/base_original_file.py reviewboard/webapi/resources/review_file_attachment_comment.py reviewboard/webapi/resources/change.py reviewboard/webapi/resources/draft_filediff.py reviewboard/webapi/resources/base_comment.py reviewboard/webapi/resources/diff_file_attachment.py reviewboard/webapi/resources/base_screenshot_comment.py reviewboard/webapi/resources/base_file_attachment_comment.py reviewboard/webapi/resources/review_request.py reviewboard/webapi/resources/default_reviewer.py reviewboard/webapi/resources/original_file.py reviewboard/webapi/resources/base_review.py reviewboard/webapi/resources/server_info.py reviewboard/webapi/resources/repository_branches.py reviewboard/webapi/resources/hosting_service.py reviewboard/webapi/resources/user.py reviewboard/webapi/resources/diff_context.py reviewboard/webapi/resources/base_patched_file.py reviewboard/webapi/resources/draft_patched_file.py reviewboard/webapi/resources/remote_repository.py reviewboard/webapi/resources/base_screenshot.py reviewboard/webapi/resources/file_attachment_comment.py reviewboard/webapi/resources/search.py reviewboard/webapi/resources/filediff.py reviewboard/webapi/resources/review_group_user.py reviewboard/webapi/resources/validation.py Ignored Files: docs/manual/webapi/2.0/resources/change-list.rst docs/manual/webapi/2.0/resources/review-reply-file-attachment-comment-list.rst docs/manual/webapi/2.0/resources/review-reply-file-attachment-comment.rst docs/manual/webapi/2.0/resources/draft-diff-list.rst docs/manual/webapi/2.0/resources/hosting-service-list.rst docs/manual/webapi/2.0/resources/diff-context.rst docs/manual/webapi/2.0/resources/file-attachment-list.rst docs/manual/webapi/2.0/resources/change.rst docs/manual/webapi/2.0/resources/file-attachment-comment-list.rst docs/manual/webapi/2.0/resources/draft-file-diff-list.rst docs/manual/webapi/2.0/resources/original-file.rst docs/manual/webapi/2.0/resources/api-token-list.rst docs/manual/webapi/2.0/resources/draft-original-file.rst docs/manual/webapi/2.0/resources/hosting-service.rst docs/manual/webapi/2.0/resources/hosting-service-account.rst docs/manual/webapi/2.0/resources/remote-repository-list.rst docs/manual/webapi/2.0/resources/hosting-service-account-list.rst docs/manual/webapi/2.0/resources/default-reviewer-list.rst docs/manual/webapi/2.0/resources/remote-repository.rst docs/manual/webapi/2.0/resources/patched-file.rst docs/manual/webapi/2.0/resources/draft-file-attachment.rst docs/manual/webapi/2.0/resources/review-file-attachment-comment.rst docs/manual/webapi/2.0/resources/repository-commits.rst docs/manual/webapi/2.0/resources/default-reviewer.rst docs/manual/webapi/2.0/resources/draft-file-diff.rst docs/manual/webapi/2.0/resources/draft-file-attachment-list.rst docs/manual/webapi/2.0/resources/search.rst docs/manual/webapi/2.0/resources/file-attachment.rst docs/manual/webapi/2.0/resources/draft-diff.rst docs/manual/webapi/2.0/resources/draft-patched-file.rst docs/manual/webapi/2.0/resources/review-file-attachment-comment-list.rst docs/manual/webapi/2.0/resources/api-token.rst docs/manual/webapi/2.0/resources/repository-branches.rst Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/resources/draft_diff.py reviewboard/webapi/resources/repository.py reviewboard/webapi/resources/draft_original_file.py reviewboard/webapi/resources/repository_commits.py reviewboard/webapi/resources/review_group.py reviewboard/webapi/resources/review_request_draft.py reviewboard/webapi/resources/draft_file_attachment.py reviewboard/webapi/resources/file_attachment.py reviewboard/webapi/resources/validate_diff.py reviewboard/webapi/resources/patched_file.py reviewboard/webapi/resources/diff.py reviewboard/webapi/resources/hosting_service_account.py reviewboard/webapi/resources/review_reply.py reviewboard/webapi/resources/base_diff_comment.py reviewboard/webapi/resources/base_file_attachment.py reviewboard/webapi/resources/review_reply_file_attachment_comment.py reviewboard/webapi/resources/base_original_file.py reviewboard/webapi/resources/review_file_attachment_comment.py reviewboard/webapi/resources/change.py reviewboard/webapi/resources/draft_filediff.py reviewboard/webapi/resources/base_comment.py reviewboard/webapi/resources/diff_file_attachment.py reviewboard/webapi/resources/base_screenshot_comment.py reviewboard/webapi/resources/base_file_attachment_comment.py reviewboard/webapi/resources/review_request.py reviewboard/webapi/resources/default_reviewer.py reviewboard/webapi/resources/original_file.py reviewboard/webapi/resources/base_review.py reviewboard/webapi/resources/server_info.py reviewboard/webapi/resources/repository_branches.py reviewboard/webapi/resources/hosting_service.py reviewboard/webapi/resources/user.py reviewboard/webapi/resources/diff_context.py reviewboard/webapi/resources/base_patched_file.py reviewboard/webapi/resources/draft_patched_file.py reviewboard/webapi/resources/remote_repository.py reviewboard/webapi/resources/base_screenshot.py reviewboard/webapi/resources/file_attachment_comment.py reviewboard/webapi/resources/search.py reviewboard/webapi/resources/filediff.py reviewboard/webapi/resources/review_group_user.py reviewboard/webapi/resources/validation.py Ignored Files: docs/manual/webapi/2.0/resources/change-list.rst docs/manual/webapi/2.0/resources/review-reply-file-attachment-comment-list.rst docs/manual/webapi/2.0/resources/review-reply-file-attachment-comment.rst docs/manual/webapi/2.0/resources/draft-diff-list.rst docs/manual/webapi/2.0/resources/hosting-service-list.rst docs/manual/webapi/2.0/resources/diff-context.rst docs/manual/webapi/2.0/resources/file-attachment-list.rst docs/manual/webapi/2.0/resources/change.rst docs/manual/webapi/2.0/resources/file-attachment-comment-list.rst docs/manual/webapi/2.0/resources/draft-file-diff-list.rst docs/manual/webapi/2.0/resources/original-file.rst docs/manual/webapi/2.0/resources/api-token-list.rst docs/manual/webapi/2.0/resources/draft-original-file.rst docs/manual/webapi/2.0/resources/hosting-service.rst docs/manual/webapi/2.0/resources/hosting-service-account.rst docs/manual/webapi/2.0/resources/remote-repository-list.rst docs/manual/webapi/2.0/resources/hosting-service-account-list.rst docs/manual/webapi/2.0/resources/default-reviewer-list.rst docs/manual/webapi/2.0/resources/remote-repository.rst docs/manual/webapi/2.0/resources/patched-file.rst docs/manual/webapi/2.0/resources/draft-file-attachment.rst docs/manual/webapi/2.0/resources/review-file-attachment-comment.rst docs/manual/webapi/2.0/resources/repository-commits.rst docs/manual/webapi/2.0/resources/default-reviewer.rst docs/manual/webapi/2.0/resources/draft-file-diff.rst docs/manual/webapi/2.0/resources/draft-file-attachment-list.rst docs/manual/webapi/2.0/resources/search.rst docs/manual/webapi/2.0/resources/file-attachment.rst docs/manual/webapi/2.0/resources/draft-diff.rst docs/manual/webapi/2.0/resources/draft-patched-file.rst docs/manual/webapi/2.0/resources/review-file-attachment-comment-list.rst docs/manual/webapi/2.0/resources/api-token.rst docs/manual/webapi/2.0/resources/repository-branches.rst -
-
-
-
- Commit:
-
5de340ed6bf674e8613cf63f421e908d5aff3f517948f8bcfc100a2050c61e27eb644e5ee6028b63
- Diff:
-
Revision 6 (+226 -6)
-
Tool: Pyflakes Processed Files: reviewboard/webapi/resources/draft_diff.py reviewboard/webapi/resources/repository.py reviewboard/webapi/resources/draft_original_file.py reviewboard/webapi/resources/repository_commits.py reviewboard/webapi/resources/review_group.py reviewboard/webapi/resources/review_request_draft.py reviewboard/webapi/resources/draft_file_attachment.py reviewboard/webapi/resources/file_attachment.py reviewboard/webapi/resources/validate_diff.py reviewboard/webapi/resources/patched_file.py reviewboard/webapi/resources/diff.py reviewboard/webapi/resources/hosting_service_account.py reviewboard/webapi/resources/review_reply.py reviewboard/webapi/resources/base_diff_comment.py reviewboard/webapi/resources/base_file_attachment.py reviewboard/webapi/resources/review_reply_file_attachment_comment.py reviewboard/webapi/resources/base_original_file.py reviewboard/webapi/resources/review_file_attachment_comment.py reviewboard/webapi/resources/change.py reviewboard/webapi/resources/draft_filediff.py reviewboard/webapi/resources/base_comment.py reviewboard/webapi/resources/diff_file_attachment.py reviewboard/webapi/resources/base_screenshot_comment.py reviewboard/webapi/resources/base_file_attachment_comment.py reviewboard/webapi/resources/review_request.py reviewboard/webapi/resources/default_reviewer.py reviewboard/webapi/resources/original_file.py reviewboard/webapi/resources/base_review.py reviewboard/webapi/resources/server_info.py reviewboard/webapi/resources/repository_branches.py reviewboard/webapi/resources/hosting_service.py reviewboard/webapi/resources/user.py reviewboard/webapi/resources/diff_context.py reviewboard/webapi/resources/base_patched_file.py reviewboard/webapi/resources/draft_patched_file.py reviewboard/webapi/resources/remote_repository.py reviewboard/webapi/resources/base_screenshot.py reviewboard/webapi/resources/file_attachment_comment.py reviewboard/webapi/resources/search.py reviewboard/webapi/resources/filediff.py reviewboard/webapi/resources/review_group_user.py reviewboard/webapi/resources/validation.py Ignored Files: docs/manual/webapi/2.0/resources/change-list.rst docs/manual/webapi/2.0/resources/review-reply-file-attachment-comment-list.rst docs/manual/webapi/2.0/resources/review-reply-file-attachment-comment.rst docs/manual/webapi/2.0/resources/draft-diff-list.rst docs/manual/webapi/2.0/resources/hosting-service-list.rst docs/manual/webapi/2.0/resources/diff-context.rst docs/manual/webapi/2.0/resources/file-attachment-list.rst docs/manual/webapi/2.0/resources/change.rst docs/manual/webapi/2.0/resources/file-attachment-comment-list.rst docs/manual/webapi/2.0/resources/draft-file-diff-list.rst docs/manual/webapi/2.0/resources/original-file.rst docs/manual/webapi/2.0/resources/api-token-list.rst docs/manual/webapi/2.0/resources/draft-original-file.rst docs/manual/webapi/2.0/resources/hosting-service.rst docs/manual/webapi/2.0/resources/hosting-service-account.rst docs/manual/webapi/2.0/resources/remote-repository-list.rst docs/manual/webapi/2.0/resources/hosting-service-account-list.rst docs/manual/webapi/2.0/resources/default-reviewer-list.rst docs/manual/webapi/2.0/resources/remote-repository.rst docs/manual/webapi/2.0/resources/patched-file.rst docs/manual/webapi/2.0/resources/draft-file-attachment.rst docs/manual/webapi/2.0/resources/review-file-attachment-comment.rst docs/manual/webapi/2.0/resources/repository-commits.rst docs/manual/webapi/2.0/resources/default-reviewer.rst docs/manual/webapi/2.0/resources/draft-file-diff.rst docs/manual/webapi/2.0/resources/draft-file-attachment-list.rst docs/manual/webapi/2.0/resources/search.rst docs/manual/webapi/2.0/resources/file-attachment.rst docs/manual/webapi/2.0/resources/draft-diff.rst docs/manual/webapi/2.0/resources/draft-patched-file.rst docs/manual/webapi/2.0/resources/review-file-attachment-comment-list.rst docs/manual/webapi/2.0/resources/api-token.rst docs/manual/webapi/2.0/resources/repository-branches.rst Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/resources/draft_diff.py reviewboard/webapi/resources/repository.py reviewboard/webapi/resources/draft_original_file.py reviewboard/webapi/resources/repository_commits.py reviewboard/webapi/resources/review_group.py reviewboard/webapi/resources/review_request_draft.py reviewboard/webapi/resources/draft_file_attachment.py reviewboard/webapi/resources/file_attachment.py reviewboard/webapi/resources/validate_diff.py reviewboard/webapi/resources/patched_file.py reviewboard/webapi/resources/diff.py reviewboard/webapi/resources/hosting_service_account.py reviewboard/webapi/resources/review_reply.py reviewboard/webapi/resources/base_diff_comment.py reviewboard/webapi/resources/base_file_attachment.py reviewboard/webapi/resources/review_reply_file_attachment_comment.py reviewboard/webapi/resources/base_original_file.py reviewboard/webapi/resources/review_file_attachment_comment.py reviewboard/webapi/resources/change.py reviewboard/webapi/resources/draft_filediff.py reviewboard/webapi/resources/base_comment.py reviewboard/webapi/resources/diff_file_attachment.py reviewboard/webapi/resources/base_screenshot_comment.py reviewboard/webapi/resources/base_file_attachment_comment.py reviewboard/webapi/resources/review_request.py reviewboard/webapi/resources/default_reviewer.py reviewboard/webapi/resources/original_file.py reviewboard/webapi/resources/base_review.py reviewboard/webapi/resources/server_info.py reviewboard/webapi/resources/repository_branches.py reviewboard/webapi/resources/hosting_service.py reviewboard/webapi/resources/user.py reviewboard/webapi/resources/diff_context.py reviewboard/webapi/resources/base_patched_file.py reviewboard/webapi/resources/draft_patched_file.py reviewboard/webapi/resources/remote_repository.py reviewboard/webapi/resources/base_screenshot.py reviewboard/webapi/resources/file_attachment_comment.py reviewboard/webapi/resources/search.py reviewboard/webapi/resources/filediff.py reviewboard/webapi/resources/review_group_user.py reviewboard/webapi/resources/validation.py Ignored Files: docs/manual/webapi/2.0/resources/change-list.rst docs/manual/webapi/2.0/resources/review-reply-file-attachment-comment-list.rst docs/manual/webapi/2.0/resources/review-reply-file-attachment-comment.rst docs/manual/webapi/2.0/resources/draft-diff-list.rst docs/manual/webapi/2.0/resources/hosting-service-list.rst docs/manual/webapi/2.0/resources/diff-context.rst docs/manual/webapi/2.0/resources/file-attachment-list.rst docs/manual/webapi/2.0/resources/change.rst docs/manual/webapi/2.0/resources/file-attachment-comment-list.rst docs/manual/webapi/2.0/resources/draft-file-diff-list.rst docs/manual/webapi/2.0/resources/original-file.rst docs/manual/webapi/2.0/resources/api-token-list.rst docs/manual/webapi/2.0/resources/draft-original-file.rst docs/manual/webapi/2.0/resources/hosting-service.rst docs/manual/webapi/2.0/resources/hosting-service-account.rst docs/manual/webapi/2.0/resources/remote-repository-list.rst docs/manual/webapi/2.0/resources/hosting-service-account-list.rst docs/manual/webapi/2.0/resources/default-reviewer-list.rst docs/manual/webapi/2.0/resources/remote-repository.rst docs/manual/webapi/2.0/resources/patched-file.rst docs/manual/webapi/2.0/resources/draft-file-attachment.rst docs/manual/webapi/2.0/resources/review-file-attachment-comment.rst docs/manual/webapi/2.0/resources/repository-commits.rst docs/manual/webapi/2.0/resources/default-reviewer.rst docs/manual/webapi/2.0/resources/draft-file-diff.rst docs/manual/webapi/2.0/resources/draft-file-attachment-list.rst docs/manual/webapi/2.0/resources/search.rst docs/manual/webapi/2.0/resources/file-attachment.rst docs/manual/webapi/2.0/resources/draft-diff.rst docs/manual/webapi/2.0/resources/draft-patched-file.rst docs/manual/webapi/2.0/resources/review-file-attachment-comment-list.rst docs/manual/webapi/2.0/resources/api-token.rst docs/manual/webapi/2.0/resources/repository-branches.rst
Tool: Pyflakes Processed Files: reviewboard/webapi/resources/draft_diff.py reviewboard/webapi/resources/repository.py reviewboard/webapi/resources/draft_original_file.py reviewboard/webapi/resources/repository_commits.py reviewboard/webapi/resources/repository_info.py reviewboard/webapi/resources/review_group.py reviewboard/webapi/resources/review_request_draft.py reviewboard/webapi/resources/draft_file_attachment.py reviewboard/webapi/resources/file_attachment.py reviewboard/webapi/resources/validate_diff.py reviewboard/webapi/resources/patched_file.py reviewboard/webapi/resources/base_watched_object.py reviewboard/webapi/resources/draft_screenshot.py reviewboard/webapi/resources/diff.py reviewboard/webapi/resources/hosting_service_account.py reviewboard/webapi/resources/review_diff_comment.py reviewboard/webapi/resources/review_reply.py reviewboard/webapi/resources/base_diff_comment.py reviewboard/webapi/resources/base_file_attachment.py reviewboard/webapi/resources/review_reply_file_attachment_comment.py reviewboard/webapi/resources/base_original_file.py reviewboard/webapi/resources/review_file_attachment_comment.py reviewboard/webapi/resources/change.py reviewboard/webapi/resources/session.py reviewboard/webapi/resources/review_request_last_update.py reviewboard/webapi/resources/draft_filediff.py reviewboard/webapi/resources/root.py reviewboard/webapi/resources/review_reply_screenshot_comment.py reviewboard/webapi/resources/api_token.py reviewboard/webapi/resources/base_comment.py reviewboard/webapi/resources/diff_file_attachment.py reviewboard/webapi/resources/base_screenshot_comment.py reviewboard/webapi/resources/screenshot.py reviewboard/webapi/resources/review_screenshot_comment.py reviewboard/webapi/resources/base_file_attachment_comment.py reviewboard/webapi/resources/review_request.py reviewboard/webapi/resources/default_reviewer.py reviewboard/webapi/resources/validation.py reviewboard/webapi/resources/original_file.py reviewboard/webapi/resources/base_review.py reviewboard/webapi/resources/server_info.py reviewboard/webapi/resources/repository_branches.py reviewboard/webapi/resources/review_reply_draft.py reviewboard/webapi/resources/hosting_service.py reviewboard/webapi/resources/filediff_comment.py reviewboard/webapi/resources/watched_review_group.py reviewboard/webapi/base.py reviewboard/webapi/resources/diff_context.py reviewboard/webapi/resources/base_patched_file.py reviewboard/webapi/resources/draft_patched_file.py reviewboard/webapi/resources/remote_repository.py reviewboard/webapi/resources/base_screenshot.py reviewboard/webapi/resources/watched_review_request.py reviewboard/webapi/resources/screenshot_comment.py reviewboard/webapi/resources/file_attachment_comment.py reviewboard/webapi/resources/search.py reviewboard/webapi/resources/filediff.py reviewboard/webapi/resources/review_group_user.py reviewboard/webapi/resources/review.py reviewboard/webapi/resources/user.py reviewboard/webapi/resources/watched.py reviewboard/webapi/resources/review_draft.py reviewboard/webapi/resources/review_reply_diff_comment.py Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/resources/draft_diff.py reviewboard/webapi/resources/repository.py reviewboard/webapi/resources/draft_original_file.py reviewboard/webapi/resources/repository_commits.py reviewboard/webapi/resources/repository_info.py reviewboard/webapi/resources/review_group.py reviewboard/webapi/resources/review_request_draft.py reviewboard/webapi/resources/draft_file_attachment.py reviewboard/webapi/resources/file_attachment.py reviewboard/webapi/resources/validate_diff.py reviewboard/webapi/resources/patched_file.py reviewboard/webapi/resources/base_watched_object.py reviewboard/webapi/resources/draft_screenshot.py reviewboard/webapi/resources/diff.py reviewboard/webapi/resources/hosting_service_account.py reviewboard/webapi/resources/review_diff_comment.py reviewboard/webapi/resources/review_reply.py reviewboard/webapi/resources/base_diff_comment.py reviewboard/webapi/resources/base_file_attachment.py reviewboard/webapi/resources/review_reply_file_attachment_comment.py reviewboard/webapi/resources/base_original_file.py reviewboard/webapi/resources/review_file_attachment_comment.py reviewboard/webapi/resources/change.py reviewboard/webapi/resources/session.py reviewboard/webapi/resources/review_request_last_update.py reviewboard/webapi/resources/draft_filediff.py reviewboard/webapi/resources/root.py reviewboard/webapi/resources/review_reply_screenshot_comment.py reviewboard/webapi/resources/api_token.py reviewboard/webapi/resources/base_comment.py reviewboard/webapi/resources/diff_file_attachment.py reviewboard/webapi/resources/base_screenshot_comment.py reviewboard/webapi/resources/screenshot.py reviewboard/webapi/resources/review_screenshot_comment.py reviewboard/webapi/resources/base_file_attachment_comment.py reviewboard/webapi/resources/review_request.py reviewboard/webapi/resources/default_reviewer.py reviewboard/webapi/resources/validation.py reviewboard/webapi/resources/original_file.py reviewboard/webapi/resources/base_review.py reviewboard/webapi/resources/server_info.py reviewboard/webapi/resources/repository_branches.py reviewboard/webapi/resources/review_reply_draft.py reviewboard/webapi/resources/hosting_service.py reviewboard/webapi/resources/filediff_comment.py reviewboard/webapi/resources/watched_review_group.py reviewboard/webapi/base.py reviewboard/webapi/resources/diff_context.py reviewboard/webapi/resources/base_patched_file.py reviewboard/webapi/resources/draft_patched_file.py reviewboard/webapi/resources/remote_repository.py reviewboard/webapi/resources/base_screenshot.py reviewboard/webapi/resources/watched_review_request.py reviewboard/webapi/resources/screenshot_comment.py reviewboard/webapi/resources/file_attachment_comment.py reviewboard/webapi/resources/search.py reviewboard/webapi/resources/filediff.py reviewboard/webapi/resources/review_group_user.py reviewboard/webapi/resources/review.py reviewboard/webapi/resources/user.py reviewboard/webapi/resources/watched.py reviewboard/webapi/resources/review_draft.py reviewboard/webapi/resources/review_reply_diff_comment.py