Remove illegal characters from XML strings before parsing.

Review Request #6670 — Created Dec. 2, 2014 and submitted

Information

Review Board
release-2.0.x
65f16e6...

Reviewers

It's easy for people to unintentionally inject XML-unsafe characters
into a string from a copy/paste when filling out the Description or
Testing Done fields of a review request.

We now sanitize the XML before attempting to parse it, removing any
illegal characters. The result is a string that can be safely parsed
with no noticeably defects.

Unit tests pass.

Manually tested with a string containing the unsafe 0x0C character.

Description From Last Updated

Should have two blank lines.

daviddavid
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/markdown_utils.py
        reviewboard/reviews/tests.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/markdown_utils.py
        reviewboard/reviews/tests.py
    
    
  2. 
      
chipx86
david
  1. 
      
  2. reviewboard/reviews/markdown_utils.py (Diff revision 1)
     
     
     
     
    Show all issues

    Should have two blank lines.

  3. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-2.0.x (09f027d)