Sandbox reviewboard.hostingsvcs.service.HostingService

Review Request #6652 — Created Nov. 28, 2014 and discarded — Latest diff uploaded

Information

Review Board
master

Reviewers

Extensions that create a HostingService subclass (using the HostingServiceHook) can throw exceptions inside Reviewboard. The parts of Reviewboard that call those methods have been sandboxed.

Now when a HostingService subclass from an extension throws an exception; Reviewboard logs the errors with enough information to find which method in the HostingService subclass threw the exception.

Unit tests have been written to make sure that functions from a Widget subclass have been called, and when an exception is thrown it gets logged.

The tests fail without the sanboxing, and succeed with it.

Diff Revision 2

This is not the most recent revision of the diff. The latest diff is revision 6. See what's changed.

orig
1
2
3
4
5
6
reviewboard/hostingsvcs/models.py
reviewboard/hostingsvcs/tests.py
reviewboard/scmtools/tests.py
Loading...