Summary

Fix formatting errors in scmtools module according to PEP8

Review Request #6636 — Created Nov. 23, 2014 and submitted Nov. 28, 2014, 9:49 p.m.

Information

Owner

justy777

Repository

Review Board

Branch

master

Bugs

Depends On

Commit

5087460...

Reviewers

Groups

reviewboard, students

People

Description

Fixed the following format errors:
scmtools/clearcase.py:86:12: E713 test for membership should be 'not in'
scmtools/clearcase.py:274:18: E713 test for membership should be 'not in'
scmtools/clearcase.py:418:1: E302 expected 2 blank lines, found 1
scmtools/cvs.py:343:17: E713 test for membership should be 'not in'
scmtools/svn/init.py:41:12: E221 multiple spaces before operator
scmtools/svn/init.py:42:16: E221 multiple spaces before operator
scmtools/svn/init.py:43:15: E221 multiple spaces before operator
scmtools/svn/base.py:25:18: E241 multiple spaces after ':'
scmtools/svn/base.py:26:16: E241 multiple spaces after ':'
scmtools/svn/base.py:27:20: E241 multiple spaces after ':'
scmtools/svn/base.py:28:19: E241 multiple spaces after ':'
scmtools/svn/base.py:29:14: E241 multiple spaces after ':'
scmtools/svn/base.py:30:18: E241 multiple spaces after ':'
scmtools/svn/base.py:33:25: E241 multiple spaces after ':'
scmtools/svn/base.py:34:27: E241 multiple spaces after ':'
scmtools/svn/base.py:36:15: E241 multiple spaces after ':'
scmtools/svn/base.py:37:15: E241 multiple spaces after ':'
scmtools/tests.py:557:80: E501 line too long (88 > 79 characters)
scmtools/tests.py:606:80: E501 line too long (88 > 79 characters)
scmtools/tests.py:619:80: E501 line too long (88 > 79 characters)
scmtools/tests.py:633:80: E501 line too long (88 > 79 characters)
scmtools/tests.py:653:80: E501 line too long (88 > 79 characters)
scmtools/tests.py:678:80: E501 line too long (87 > 79 characters)
scmtools/tests.py:2691:80: E501 line too long (81 > 79 characters)
scmtools/tests.py:2829:80: E501 line too long (81 > 79 characters)
scmtools/tests.py:2921:80: E501 line too long (80 > 79 characters)

Testing Done

Ran unit tests for scmtools module, and ran pep8 again.

Issues

Description	From	Last Updated
I prefer the old way, even if pep8 is upset about it.	chipx86	Nov. 24, 2014, 3:41 p.m.
We're matching what diffs provide, so this cannot be changed. Same below.	chipx86	Nov. 24, 2014, 3:56 p.m.
self should be indented one more. Same below.	chipx86	Nov. 24, 2014, 3:57 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/scmtools/clearcase.py
    reviewboard/scmtools/svn/base.py
    reviewboard/scmtools/managers.py
    reviewboard/scmtools/tests.py
    reviewboard/scmtools/cvs.py
    reviewboard/scmtools/svn/__init__.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/scmtools/clearcase.py
    reviewboard/scmtools/svn/base.py
    reviewboard/scmtools/managers.py
    reviewboard/scmtools/tests.py
    reviewboard/scmtools/cvs.py
    reviewboard/scmtools/svn/__init__.py

reviewboard/scmtools/managers.py (Diff revision 1)
The issue has been resolved. Show all issues
```
I prefer the old way, even if pep8 is upset about it.
```
reviewboard/scmtools/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
We're matching what diffs provide, so this cannot be changed.
Same below.
```
reviewboard/scmtools/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
self should be indented one more. Same below.
```

Description:

		Fixed the following format errors:
		scmtools/clearcase.py:86:12: E713 test for membership should be 'not in'
		scmtools/clearcase.py:274:18: E713 test for membership should be 'not in'
		scmtools/clearcase.py:418:1: E302 expected 2 blank lines, found 1
		scmtools/cvs.py:343:17: E713 test for membership should be 'not in'
-		scmtools/managers.py:80:46: E251 unexpected spaces around keyword / parameter equals
		scmtools/svn/init.py:41:12: E221 multiple spaces before operator
		scmtools/svn/init.py:42:16: E221 multiple spaces before operator
		scmtools/svn/init.py:43:15: E221 multiple spaces before operator
		scmtools/svn/base.py:25:18: E241 multiple spaces after ':'
		scmtools/svn/base.py:26:16: E241 multiple spaces after ':'
		scmtools/svn/base.py:27:20: E241 multiple spaces after ':'
		scmtools/svn/base.py:28:19: E241 multiple spaces after ':'
		scmtools/svn/base.py:29:14: E241 multiple spaces after ':'
		scmtools/svn/base.py:30:18: E241 multiple spaces after ':'
		scmtools/svn/base.py:33:25: E241 multiple spaces after ':'
		scmtools/svn/base.py:34:27: E241 multiple spaces after ':'
		scmtools/svn/base.py:36:15: E241 multiple spaces after ':'
		scmtools/svn/base.py:37:15: E241 multiple spaces after ':'
		scmtools/tests.py:557:80: E501 line too long (88 > 79 characters)
		scmtools/tests.py:606:80: E501 line too long (88 > 79 characters)
		scmtools/tests.py:619:80: E501 line too long (88 > 79 characters)
		scmtools/tests.py:633:80: E501 line too long (88 > 79 characters)
		scmtools/tests.py:653:80: E501 line too long (88 > 79 characters)
		scmtools/tests.py:678:80: E501 line too long (87 > 79 characters)
		scmtools/tests.py:2691:80: E501 line too long (81 > 79 characters)
		scmtools/tests.py:2829:80: E501 line too long (81 > 79 characters)
		scmtools/tests.py:2921:80: E501 line too long (80 > 79 characters)

Commit:

181943b5b508685036f6e8335aaab729111c22a7

5087460f84fe45a70dfa34f57ffafd9fbf3185eb

Diff:

Revision 2 (+35 -25)

Show changes

	reviewboard/scmtools/clearcase.py
	reviewboard/scmtools/cvs.py
	reviewboard/scmtools/tests.py
	reviewboard/scmtools/svn/__init__.py
	reviewboard/scmtools/svn/base.py

Tool: Pyflakes
Processed Files:
    reviewboard/scmtools/cvs.py
    reviewboard/scmtools/clearcase.py
    reviewboard/scmtools/svn/__init__.py
    reviewboard/scmtools/svn/base.py
    reviewboard/scmtools/tests.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/scmtools/cvs.py
    reviewboard/scmtools/clearcase.py
    reviewboard/scmtools/svn/__init__.py
    reviewboard/scmtools/svn/base.py
    reviewboard/scmtools/tests.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.0.x (e8e95e6)