• 
      

    Fix formatting errors in reviews module according to PEP8

    Review Request #6635 — Created Nov. 23, 2014 and submitted

    Information

    Review Board
    master
    bab7e07...

    Reviewers

    Fixed the following format errors:
    reviews/management/commands/fill-database.py:127:49: E128 continuation line under-indented for visual indent
    reviews/management/commands/fill-database.py:169:54: E128 continuation line under-indented for visual indent
    reviews/models/base_comment.py:15:9: E221 multiple spaces before operator
    reviews/models/base_comment.py:16:13: E221 multiple spaces before operator
    reviews/models/base_comment.py:17:12: E221 multiple spaces before operator
    reviews/models/base_comment.py:20:15: E241 multiple spaces after ','
    reviews/models/base_comment.py:21:19: E241 multiple spaces after ','
    reviews/models/base_comment.py:22:18: E241 multiple spaces after ','
    reviews/models/base_review_request_details.py:117:29: E131 continuation line unaligned for hanging indent
    reviews/models/review_request.py:133:14: E221 multiple spaces before operator
    reviews/models/review_request.py:134:14: E221 multiple spaces before operator
    reviews/models/review_request.py:138:20: E241 multiple spaces after ','
    reviews/models/review_request.py:139:20: E241 multiple spaces after ','
    reviews/models/review_request.py:911:37: E128 continuation line under-indented for visual indent
    reviews/models/review_request.py:912:37: E128 continuation line under-indented for visual indent
    reviews/templatetags/reviewtags.py:380:80: E501 line too long (81 > 79 characters)
    reviews/templatetags/reviewtags.py:384:25: E123 closing bracket does not match indentation of opening bracket's line
    reviews/tests.py:644:29: E127 continuation line over-indented for visual indent
    reviews/tests.py:649:29: E127 continuation line over-indented for visual indent
    reviews/tests.py:1283:1: E302 expected 2 blank lines, found 1
    reviews/tests.py:2678:80: E501 line too long (82 > 79 characters)
    reviews/views.py:70:1: E265 block comment should start with '# '
    reviews/views.py:230:1: E265 block comment should start with '# '

    Ran unit tests for hostingsvcs module, and ran pep8 again.

    Description From Last Updated

    I want to keep this how it was.

    chipx86chipx86

    I want to keep this how it was.

    chipx86chipx86

    Indent the right-hand side of the equality check.

    chipx86chipx86

    elf hsould be indented one more.

    chipx86chipx86

    Col: 29 E131 continuation line unaligned for hanging indent

    reviewbotreviewbot
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/reviews/views.py
          reviewboard/reviews/models/base_comment.py
          reviewboard/reviews/tests.py
          reviewboard/reviews/templatetags/reviewtags.py
          reviewboard/reviews/models/review_request.py
          reviewboard/reviews/models/base_review_request_details.py
          reviewboard/reviews/management/commands/fill-database.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/reviews/views.py
          reviewboard/reviews/models/base_comment.py
          reviewboard/reviews/tests.py
          reviewboard/reviews/templatetags/reviewtags.py
          reviewboard/reviews/models/review_request.py
          reviewboard/reviews/models/base_review_request_details.py
          reviewboard/reviews/management/commands/fill-database.py
      
      
    2. 
        
    chipx86
    1. 
        
    2. Show all issues

      I want to keep this how it was.

    3. reviewboard/reviews/models/review_request.py (Diff revision 1)
       
       
       
       
       
      Show all issues

      I want to keep this how it was.

    4. Show all issues

      Indent the right-hand side of the equality check.

    5. reviewboard/reviews/tests.py (Diff revision 1)
       
       
       
      Show all issues

      elf hsould be indented one more.

    6. 
        
    justy777
    reviewbot
    1. Tool: Pyflakes
      Processed Files:
          reviewboard/reviews/views.py
          reviewboard/reviews/models/base_comment.py
          reviewboard/reviews/tests.py
          reviewboard/reviews/templatetags/reviewtags.py
          reviewboard/reviews/models/review_request.py
          reviewboard/reviews/management/commands/fill-database.py
      
      
      
      Tool: PEP8 Style Checker
      Processed Files:
          reviewboard/reviews/views.py
          reviewboard/reviews/models/base_comment.py
          reviewboard/reviews/tests.py
          reviewboard/reviews/templatetags/reviewtags.py
          reviewboard/reviews/models/review_request.py
          reviewboard/reviews/management/commands/fill-database.py
      
      
    2. Show all issues
      Col: 29
       E131 continuation line unaligned for hanging indent
      
    3. 
        
    chipx86
    1. Ship It!
    2. 
        
    justy777
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (4fa442b)