Summary

Drag 'n Drop Inline Images Backend - View

Review Request #6616 — Created Nov. 21, 2014 and submitted Dec. 4, 2014, 12:46 a.m.

Information

Owner

dkus

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard, students

People

Description

Part of a set of changes to add support for dragging and dropping images into the markdown editor.

Adding a view that redirects to a FileAttachment's file. Adding a uuid field to the FileAttachment model, to be used by the view as non-guessable identifier for the FileAttachment.
This view can be accessed at the following url: /users/<username>/file-attachments/<uuid>/

Testing Done

All unit tests pass after making the changes.

Did some manual testing to make sure the view properly redirects to the file, and the file can be viewed.

Issues

Description	From	Last Updated
Since this is a "view", the view_ prefix seems superfluous - maybe just call this user_file_attachment.	mike_conley	Nov. 28, 2014, 4:34 p.m.
Isn't the user already available at request.user?	mike_conley	Nov. 28, 2014, 5:32 p.m.
We're using single quotes throughout the rest of this file - might as well stick with the convention. Same applies …	mike_conley	Nov. 28, 2014, 4:34 p.m.
Why the double $?	mike_conley	Nov. 28, 2014, 4:34 p.m.
Might as well just be "user-file-attachment"	mike_conley	Nov. 28, 2014, 4:34 p.m.
"URL", "UUID", and "a its" -> "its".	chipx86	Nov. 30, 2014, 5 p.m.

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/attachments/evolutions/file_attachment_uuid.py
    reviewboard/attachments/evolutions/__init__.py
    reviewboard/attachments/views.py
    reviewboard/attachments/models.py
    reviewboard/urls.py



Tool: Pyflakes
Processed Files:
    reviewboard/attachments/evolutions/file_attachment_uuid.py
    reviewboard/attachments/evolutions/__init__.py
    reviewboard/attachments/views.py
    reviewboard/attachments/models.py
    reviewboard/urls.py

Change Summary:: Updating description.
Description:: Part of a set of changes to add support for dragging and dropping images into the markdown editor.

~
Adding a view that redirects to a FileAttachment's file. Adding a uuid field to the FileAttachment model, to be used by the view as non-guessable identifier for the FileAttachment.
~
Adding a view that redirects to a FileAttachment's file. Adding a uuid field to the FileAttachment model, to be used by the view as non-guessable identifier for the FileAttachment.
+ This view can be accessed at the following url: /users/<username>/file-attachments/<uuid>/

reviewboard/attachments/views.py (Diff revision 1)

The issue has been resolved. Show all issues

Since this is a "view", the view_ prefix seems superfluous - maybe just call this user_file_attachment.

reviewboard/attachments/views.py (Diff revision 1)

The issue has been dropped. Show all issues

Isn't the user already available at request.user?

dkus Nov. 28, 2014, 4:38 p.m.

Isn't request.user the requesting user? That's not what I want to get here, I want to get the user specified in the url, which may not be the requesting user.

mike_conley Nov. 28, 2014, 5:32 p.m.
```
Yep, you're absolutely right.
```

reviewboard/urls.py (Diff revision 1)

The issue has been resolved. Show all issues

We're using single quotes throughout the rest of this file - might as well stick with the convention. Same applies with the rest of your changes in here.

reviewboard/urls.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Why the double $?
```
1. dkus Nov. 28, 2014, 4:38 p.m.
  Oops, did some refactoring here and didn't notice.
reviewboard/urls.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Might as well just be "user-file-attachment"
```

Change Summary:

Code review changes

Diff:

Revision 2 (+53 -3)

Show changes

	reviewboard/urls.py
	reviewboard/attachments/models.py
	reviewboard/attachments/views.py
	reviewboard/attachments/evolutions/__init__.py
	reviewboard/attachments/evolutions/file_attachment_uuid.py

Tool: Pyflakes
Processed Files:
    reviewboard/attachments/evolutions/file_attachment_uuid.py
    reviewboard/attachments/evolutions/__init__.py
    reviewboard/attachments/views.py
    reviewboard/attachments/models.py
    reviewboard/urls.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/attachments/evolutions/file_attachment_uuid.py
    reviewboard/attachments/evolutions/__init__.py
    reviewboard/attachments/views.py
    reviewboard/attachments/models.py
    reviewboard/urls.py

Ship it!

reviewboard/attachments/views.py (Diff revision 2)
The issue has been resolved. Show all issues
```
"URL", "UUID", and "a its" -> "its".
```

Change Summary:

Fixing some comments

Diff:

Revision 3 (+53 -3)

Show changes

	reviewboard/urls.py
	reviewboard/attachments/models.py
	reviewboard/attachments/views.py
	reviewboard/attachments/evolutions/__init__.py
	reviewboard/attachments/evolutions/file_attachment_uuid.py

Tool: Pyflakes
Processed Files:
    reviewboard/attachments/evolutions/file_attachment_uuid.py
    reviewboard/attachments/evolutions/__init__.py
    reviewboard/attachments/views.py
    reviewboard/attachments/models.py
    reviewboard/urls.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/attachments/evolutions/file_attachment_uuid.py
    reviewboard/attachments/evolutions/__init__.py
    reviewboard/attachments/views.py
    reviewboard/attachments/models.py
    reviewboard/urls.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to ucosp/dkus/dnd-inline-images (c48f1be)